Re: Review Request 49465: Implemented GET_EXECUTORS Call in v1 master API.

2016-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49465/#review140307 --- Bad patch! Reviews applied: [49465, 49464] Failed command:

Re: Review Request 49223: Enhance value parsing.

2016-06-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review140294 --- src/common/values.cpp (line 604)

Re: Review Request 49480: Added installing NVML headers with --enable-install-module-dependencies.

2016-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49480/#review140301 --- Bad patch! Reviews applied: [49480, 49456] Failed command:

Re: Review Request 49242: Add ReadFile protobuf message.

2016-06-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49242/#review140296 --- include/mesos/agent/agent.proto (lines 80 - 82)

Re: Review Request 49479: Removed --sandbox flag from mesos-containerizer launch command.

2016-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49479/#review140295 --- Patch looks great! Reviews applied: [49415, 49424, 49425, 49472,

Re: Review Request 49487: Refactor master::Http::getTasks into helper function.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49487/ --- (Updated July 1, 2016, 2:59 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49487: Refactormaster::Http::getTasks into helper function.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49487/ --- (Updated July 1, 2016, 2:58 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 49489: Refactor master::Http::getFrameworks to resuable helper.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.

Re: Review Request 49488: Refactor master::Http::getAgents into helper function.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/ --- (Updated July 1, 2016, 2:47 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49488: Refactor master::Http::GetAgents into helper function.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/ --- (Updated July 1, 2016, 2:47 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 49488: Refactor master::Http::GetAgents into helper function.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.

Review Request 49487: Refactor mesos::master::getTasks into helper function.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49487/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.

Re: Review Request 49469: Added new utility function, `frameworkHasCapability()`.

2016-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49469/#review140292 --- Patch looks great! Reviews applied: [49469] Passed command:

Re: Review Request 49485: Fixed Mac OS build.

2016-06-30 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49485/#review140291 --- Ship it! Ship It! - Jiang Yan Xu On June 30, 2016, 6:55

Review Request 49485: Fixed Mac OS build.

2016-06-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49485/ --- Review request for mesos, Benjamin Mahler, Jie Yu, and Jiang Yan Xu. Bugs:

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47973/#review140290 --- src/tests/gc_tests.cpp (line 42)

Re: Review Request 49412: Updated SSL.md with 'SSL_VERIFY_IPADD'.

2016-06-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49412/ --- (Updated July 1, 2016, 1:09 a.m.) Review request for mesos, Adam B, Albert

Re: Review Request 49411: Updated CHANGELOG for MESOS-5724.

2016-06-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49411/ --- (Updated July 1, 2016, 1:08 a.m.) Review request for mesos, Adam B, Albert

Re: Review Request 49402: Added tests for IP based certificate validation.

2016-06-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49402/ --- (Updated July 1, 2016, 12:51 a.m.) Review request for mesos, Adam B, Albert

Re: Review Request 49400: Extended utilities to render certificate extension for IP.

2016-06-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49400/ --- (Updated July 1, 2016, 12:49 a.m.) Review request for mesos, Adam B, Albert

Re: Review Request 49190: Enabled calculateShare() to ignore the fairnessExcludeResourceNames.

2016-06-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49190/#review140270 --- Fix it, then Ship it!

Re: Review Request 48908: Added test case for exclude resources from sorter.

2016-06-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48908/#review140280 --- Fix it, then Ship it!

Re: Review Request 48907: Enabled allocator transfer the fairnessExcludeResourceNames to sorter.

2016-06-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48907/#review140274 --- Ship it! src/master/allocator/mesos/hierarchical.cpp (lines

Re: Review Request 48904: Updated allocator initialize() to include fairnessExcludeResourceNames.

2016-06-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48904/#review140268 --- Ship it! src/master/allocator/mesos/hierarchical.hpp (line

Re: Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

2016-06-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48895/#review140237 --- Ship it! Here is a suggestion for a more descriptive commit

Review Request 49483: Add Charles Allen to contributors

2016-06-30 Thread Charles Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49483/ --- Review request for mesos. Repository: mesos Description --- Add Charles

Re: Review Request 49257: Added documentation on coarse grain authorization for endpoints.

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49257/#review140286 --- Ship it! Ship It! - Vinod Kone On June 30, 2016, 5:22 p.m.,

Re: Review Request 49201: Added validation for the `get_endpoints` ACL.

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49201/#review140283 --- Fix it, then Ship it! src/common/http.cpp (line 73)

Re: Review Request 49464: Updated operator APIs proto files for `GET_EXECUTORS` call.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49464/#review140284 --- include/mesos/master/master.proto (line 61)

Re: Review Request 49465: Implemented GET_EXECUTORS Call in v1 master API.

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49465/#review140281 --- src/master/http.cpp (line 1524)

Re: Review Request 49464: Updated operator APIs proto files for `GET_EXECUTORS` call.

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49464/#review140279 --- include/mesos/master/master.proto (lines 356 - 358)

Re: Review Request 49370: Updateted documentation for roles endpoint filtering.

2016-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49370/#review140278 --- Bad patch! Reviews applied: [49370, 49369] Failed command:

Re: Review Request 49480: Added installing NVML headers with --enable-install-module-dependencies.

2016-06-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49480/ --- (Updated June 30, 2016, 11:54 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 49420: Updated GetFrameworks v1 call in master.

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49420/ --- (Updated June 30, 2016, 11:34 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49419: Updated GetTasks v1 call in master.

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49419/ --- (Updated June 30, 2016, 11:33 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 49480: Added installing NVML headers with --enable-install-module-dependencies.

2016-06-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49480/ --- Review request for mesos, Alexander Rojas, Kapil Arya, and Till Toenshoff.

Re: Review Request 49419: Updated GetTasks v1 call in master.

2016-06-30 Thread Vinod Kone
> On June 30, 2016, 5:20 p.m., Anand Mazumdar wrote: > > src/master/http.cpp, lines 3212-3213 > > > > > > whoops, this is leaking memory. yikes. good catch. - Vinod

Re: Review Request 49419: Updated GetTasks v1 call in master.

2016-06-30 Thread Vinod Kone
> On June 30, 2016, 4:12 a.m., Zhitao Li wrote: > > src/master/http.cpp, lines 3240-3251 > > > > > > Not necessarily part of this patch, but I wonder whether we should have > > authorization of who can see an

Re: Review Request 49418: Decoupled implementation of `tasks()` and `getTasks()` in master.

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49418/ --- (Updated June 30, 2016, 11:30 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49420: Updated GetFrameworks v1 call in master.

2016-06-30 Thread Vinod Kone
> On June 30, 2016, 2:18 a.m., haosdent huang wrote: > > src/master/http.cpp, line 1395 > > > > > > I saw > > https://github.com/apache/mesos/commit/856416754f09530582f74858566202cb5b244c70 > > > > Do we

Review Request 49479: Removed --sandbox flag from mesos-containerizer launch command.

2016-06-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49479/ --- Review request for mesos, Benjamin Mahler, Gilbert Song, and Ian Downes. Bugs:

Re: Review Request 49257: Added documentation on coarse grain authorization for endpoints.

2016-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49257/#review140260 --- Bad patch! Reviews applied: [49257, 49201, 49196] Failed

Re: Review Request 49448: Added testcases for LIST_FILES call.

2016-06-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49448/#review140250 --- LGTM! - Can we add a test for the unhappy case too i.e.

Re: Review Request 49465: Implemented GET_EXECUTORS Call in v1 master API.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49465/#review140259 --- Ship it! Looks good for building GetState on top. - Zhitao Li

Re: Review Request 49465: Implemented GET_EXECUTORS Call in v1 master API.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49465/#review140258 --- src/master/http.cpp (lines 1443 - 1447)

Re: Review Request 49464: Updated operator APIs proto files for `GET_EXECUTORS` call.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49464/#review140256 --- Fix it, then Ship it! Other than sequence number, looks good.

Re: Review Request 49447: Implemented LIST_FILES Call in v1 agent API.

2016-06-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49447/#review140248 --- Similar comments as for the master implementation apply to this

Re: Review Request 49446: Implemented LIST_FILES Call in v1 master API.

2016-06-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49446/#review140242 --- include/mesos/master/master.proto (line 110)

Re: Review Request 49412: Updated SSL.md with 'SSL_VERIFY_IPADD'.

2016-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49412/#review140245 --- Patch looks great! Reviews applied: [49400, 49401, 49402, 49411,

Re: Review Request 49402: Added tests for IP based certificate validation.

2016-06-30 Thread Till Toenshoff
> On June 30, 2016, 4:03 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp, lines 781-783 > > > > > > Let's parameterize the existing tests these are copied from since the > >

Re: Review Request 49401: Updated certificate validation to check 'IP Address' SAN.

2016-06-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49401/ --- (Updated June 30, 2016, 9:52 p.m.) Review request for mesos, Adam B, Albert

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

2016-06-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49445/#review140238 --- src/files/files.hpp (lines 20 - 26)

Re: Review Request 49401: Updated certificate validation to check 'IP Address' SAN.

2016-06-30 Thread Till Toenshoff
> On June 30, 2016, 3:58 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp, line 527 > > > > > > "verify the SSL connection later" > > => > > "verify the certificate

Review Request 49473: Made control pipe to mesos-containerizer launch optional.

2016-06-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49473/ --- Review request for mesos, Benjamin Mahler, Gilbert Song, and Ian Downes. Bugs:

Review Request 49469: Added new utility function, `frameworkHasCapability()`.

2016-06-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49469/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 49444: Added a helper function to construct JSON:Object from FileInfo protobuf.

2016-06-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49444/#review140236 --- Fix it, then Ship it! src/common/http.cpp (line 396)

Re: Review Request 49422: Have maven run in batch mode

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49422/#review140235 --- Ship it! Ship It! - Vinod Kone On June 30, 2016, 3:59 a.m.,

Re: Review Request 49443: Include a function to construct FileInfo protobuf message.

2016-06-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49443/#review140221 --- Looks good! Left a few minor cleanup/style comments.

Re: Review Request 49370: Updateted documentation for roles endpoint filtering.

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49370/#review140233 --- CHANGELOG (line 50)

Re: Review Request 49369: Introduced authorization based filtering for /roles.

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49369/#review140231 --- include/mesos/authorizer/acls.proto (line 167)

Review Request 49472: Fixed some style issue in stout Makefile.

2016-06-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49472/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 49460: Added backport of MESOS-5691, 5723, 5748 to 0.28.3.

2016-06-30 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49460/ --- (Updated June 30, 2016, 1:50 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 49461: Added backport of MESOS-5691, 5723, 5748 to 0.27.4.

2016-06-30 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49461/ --- (Updated June 30, 2016, 1:50 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 49448: Added testcases for LIST_FILES call.

2016-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49448/#review140229 --- Patch looks great! Reviews applied: [49301, 49443, 49444, 49445,

Re: Review Request 49394: Added support for VIEW_FLAGS authorization action in HTTP API.

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49394/#review140228 --- Fix it, then Ship it! src/master/master.hpp (line 1306)

Re: Review Request 49313: Added the VIEW_FLAGS authorization action.

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49313/#review140227 --- Fix it, then Ship it!

Re: Review Request 49400: Extended utilities to render certificate extension for IP.

2016-06-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49400/ --- (Updated June 30, 2016, 8:01 p.m.) Review request for mesos, Adam B, Albert

Re: Review Request 49400: Extended utilities to render certificate extension for IP.

2016-06-30 Thread Till Toenshoff
> On June 30, 2016, 2:51 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/ssl/utilities.cpp, lines 240-243 > > > > > > I'm not sure I understand why this works. > > `in_addr.get().s_addr` is a uint.

Re: Review Request 49370: Updateted documentation for roles endpoint filtering.

2016-06-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49370/ --- (Updated June 30, 2016, 7:37 p.m.) Review request for mesos and Adam B.

Re: Review Request 49369: Introduced authorization based filtering for /roles.

2016-06-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49369/ --- (Updated June 30, 2016, 7:36 p.m.) Review request for mesos and Adam B.

Re: Review Request 49181: Fixed a typo in hierarchical.hpp.

2016-06-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49181/#review140223 --- Ship it! Ship It! - Benjamin Mahler On June 29, 2016, 12:13

Re: Review Request 49352: Added a flag parser for std::set.

2016-06-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49352/#review140220 --- Fix it, then Ship it! src/common/parse.hpp (lines 143 - 144)

Re: Review Request 49461: Added backport of MESOS-5691, 5723, 5748 to 0.27.4.

2016-06-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49461/#review140219 --- Ship it! Ship It! - Benjamin Mahler On June 30, 2016, 6:55

Re: Review Request 49460: Added backport of MESOS-5691, 5723, 5748 to 0.28.3.

2016-06-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49460/#review140218 --- Ship it! Ship It! - Benjamin Mahler On June 30, 2016, 6:55

Review Request 49465: Implemented GET_EXECUTORS Call in v1 master API.

2016-06-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49465/ --- Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay

Review Request 49464: Updated operator APIs proto files for `GET_EXECUTORS` call.

2016-06-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49464/ --- Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay

Review Request 49461: Added backport of MESOS-5691, 5723, 5748 to 0.27.4.

2016-06-30 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49461/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Joris Van

Review Request 49460: Added backport of MESOS-5691, 5723, 5748 to 0.28.3.

2016-06-30 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49460/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Joris Van

Re: Review Request 49420: Updated GetFrameworks v1 call in master.

2016-06-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49420/#review140194 --- Fix it, then Ship it! LGTM!

Re: Review Request 49422: Have maven run in batch mode

2016-06-30 Thread haosdent huang
> On June 30, 2016, 5:47 p.m., haosdent huang wrote: > > Hi, may you elaborate why no-interactive mode is necessary here? I think we > > didn't require any user inputs during maven build. > > Charles Allen wrote: > Here's the kind of junk it does without `-B` > > ``` > [INFO]

Re: Review Request 49422: Have maven run in batch mode

2016-06-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49422/#review140212 --- Ship it! Ship It! - haosdent huang On June 30, 2016, 3:59

Re: Review Request 49422: Have maven run in batch mode

2016-06-30 Thread Charles Allen
> On June 30, 2016, 5:47 p.m., haosdent huang wrote: > > Hi, may you elaborate why no-interactive mode is necessary here? I think we > > didn't require any user inputs during maven build. Here's the kind of junk it does without `-B` ``` [INFO] Scanning for projects... [INFO]

Re: Review Request 49250: Regenerated endpoint documention.

2016-06-30 Thread Joerg Schad
> On June 30, 2016, 6:04 p.m., Alexander Rukletsov wrote: > > docs/endpoints/master/state.md, line 103 > > > > > > Comma is missing in the patch. Have you checked the generated docs? Yes, must have missed it. Will

Re: Review Request 49251: Added missing AUTHORIZATION endpoint documentation.

2016-06-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49251/#review140203 --- src/master/http.cpp (line 2851)

Re: Review Request 49251: Added missing AUTHORIZATION endpoint documentation.

2016-06-30 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49251/#review140202 --- src/master/http.cpp (line 2851)

Re: Review Request 49250: Regenerated endpoint documention.

2016-06-30 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49250/#review140201 --- docs/endpoints/master/state-summary.md (line 34)

Re: Review Request 49394: Added support for VIEW_FLAGS authorization action in HTTP API.

2016-06-30 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49394/ --- (Updated June 30, 2016, 7:45 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 49313: Added the VIEW_FLAGS authorization action.

2016-06-30 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49313/ --- (Updated June 30, 2016, 7:45 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 49313: Added the VIEW_FLAGS authorization action.

2016-06-30 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49313/ --- (Updated June 30, 2016, 7:41 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 49436: Added test cases for tcp health check.

2016-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49436/#review140195 --- Patch looks great! Reviews applied: [49351, 36816, 49360, 49434,

Re: Review Request 49313: Added the VIEW_FLAGS authorization action.

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49313/#review140193 --- src/master/http.cpp (lines 2275 - 2276)

Re: Review Request 49257: Added documentation on coarse grain authorization for endpoints.

2016-06-30 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49257/ --- (Updated June 30, 2016, 7:22 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 49419: Updated GetTasks v1 call in master.

2016-06-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49419/#review140186 --- Fix it, then Ship it! LGTM, modulo earlier comments from

Re: Review Request 49456: Added the #gpus slack channel to the GPU working group documentation.

2016-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49456/#review140192 --- Ship it! Ship It! - Vinod Kone On June 30, 2016, 4:56 p.m.,

Re: Review Request 49456: Added the #gpus slack channel to the GPU working group documentation.

2016-06-30 Thread Vinod Kone
> On June 30, 2016, 5:02 p.m., Tom Runyon wrote: > > I think you should add a link to subscribe to the Mesos slack channel as > > well for those who aren't currently slack members: > > https://mesos-slackin.herokuapp.com/ > > Kevin Klues wrote: > I agree this should be somewhere in the

Re: Review Request 49257: Added documentation on coarse grain authorization for endpoints.

2016-06-30 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49257/#review140144 --- docs/authorization.md (line 749)

Re: Review Request 49456: Added the #gpus slack channel to the GPU working group documentation.

2016-06-30 Thread Kevin Klues
> On June 30, 2016, 5:02 p.m., Tom Runyon wrote: > > I think you should add a link to subscribe to the Mesos slack channel as > > well for those who aren't currently slack members: > > https://mesos-slackin.herokuapp.com/ I agree this should be somewhere in the document, but it seems

Re: Review Request 49456: Added the #gpus slack channel to the GPU working group documentation.

2016-06-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49456/#review140189 --- Ship it! Ship It! - haosdent huang On June 30, 2016, 4:56

Re: Review Request 49456: Added the #gpus slack channel to the GPU working group documentation.

2016-06-30 Thread Tom Runyon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49456/#review140188 --- I think you should add a link to subscribe to the Mesos slack

Re: Review Request 49456: Added the #gpus slack channel to the GPU working group documentation.

2016-06-30 Thread Kevin Klues
> On June 30, 2016, 4:49 p.m., haosdent huang wrote: > > docs/working-groups.md, line 21 > > > > > > How about use `https://mesos.slack.com/messages/gpus/` instead? Good idea. See the updated patch. - Kevin

  1   2   >