Review Request 49569: Added an option to the launch helper binary to unshare mount namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49569/ --- Review request for mesos, Benjamin Mahler, Gilbert Song, Ian Downes, and Joshua

Review Request 49568: Simplified a flag in the launch helper binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49568/ --- Review request for mesos, Gilbert Song and Ian Downes. Bugs: MESOS-5753

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/#review140541 --- Ship it! Ship It! - Jie Yu On July 2, 2016, 9:50 p.m.,

Re: Review Request 49518: Initial snapshot for v1 master event stream.

> On July 3, 2016, 2:23 a.m., haosdent huang wrote: > > src/tests/api_tests.cpp, line 1458 > > > > > > Add a blank line above. Refer to

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/#review140539 --- I think we should split the test cases for `SUBSCRIBE` instead of

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/#review140538 --- src/tests/api_tests.cpp (line 1425)

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49445/#review140537 --- src/files/files.cpp (line 185)

Re: Review Request 49243: Create readFile method in FilesProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49243/#review140536 --- src/files/files.cpp (line 517)

Re: Review Request 49509: Revised protobuf definition of GetState response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49509/#review140535 --- Ship it! Ship It! - haosdent huang On July 1, 2016, 11:43

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49445/#review140534 --- src/files/files.cpp (lines 85 - 87)

Re: Review Request 49446: Implemented LIST_FILES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49446/#review140533 --- src/master/http.cpp (line 2815)

Re: Review Request 49550: Added evolve function for `FileInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49550/#review140532 --- Ship it! Ship It! - haosdent huang On July 2, 2016, 7:37

Re: Review Request 49551: Overloaded equality(==) operator for `FileInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49551/#review140531 --- include/mesos/v1/mesos.hpp (line 55)

Re: Review Request 49529: Removed jsonFileInfo implementation from files.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49529/#review140530 --- Ship it! Ship It! - haosdent huang On July 2, 2016, 7:51

Re: Review Request 49447: Implemented LIST_FILES Call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49447/#review140529 --- src/slave/http.cpp (line 748)

Re: Review Request 49448: Added testcases for LIST_FILES call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49448/#review140528 --- Ship it! Ship It! - haosdent huang On July 2, 2016, 7:50

Re: Review Request 49546: Added device support to Docker::run.

> On July 2, 2016, 8:18 p.m., Kevin Klues wrote: > > src/docker/docker.cpp, line 677 > > > > > > If all permissions are `false`, do we still want to include the ":" > > here? Does this work with docker? Thanks!

Re: Review Request 49544: Made stout::Path default constructible / assignable / copyable.

> On July 2, 2016, 7:56 p.m., Kevin Klues wrote: > > 3rdparty/stout/include/stout/path.hpp, lines 255-261 > > > > > > Do we really need this function? It looks like just casting it to a > > string would be enough

Re: Review Request 49567: Cleaned up some logic in stout/elf.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49567/#review140524 --- Ship it! Let's split the bug fix into a separate patch. Also

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

> On July 2, 2016, 5:46 a.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 580 > > > > > > Please use UUID::random here. > > Haris Choudhary wrote: > I've made the changes. But

Re: Review Request 49565: Added a new 'NvidiaVolume' component.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49565/#review140520 --- Fix it, then Ship it!

Re: Review Request 49566: Integrated the 'NvidiaVolume' component into 'NvidiaComponents'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49566/#review140522 --- Ship it! Ship It! - Benjamin Mahler On July 2, 2016, 7:43

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/#review140521 --- Patch looks great! Reviews applied: [49414] Passed command:

Review Request 49567: Cleaned up some logic in stout/elf.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49567/ --- Review request for mesos. Repository: mesos Description --- Cleaned up

Re: Review Request 49564: Added `get_abi_version()` to the ELF parsing abstraction.

> On July 2, 2016, 10:22 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/elf.hpp, line 84 > > > > > > Cleanups in a separate patch next time? Whoops! I must have squashed this into the wrong commit. I

Re: Review Request 49559: Added ELFIO as bundled dependency in Mesos.

> On July 2, 2016, 9:51 p.m., Benjamin Mahler wrote: > > 3rdparty/Makefile.am, line 175 > > > > > > Looks like we need the following: > > > > ``` > > $(ELFIO)/elfio/elf_types.hpp: $(ELFIO)-stamp > >

Re: Review Request 49564: Added `get_abi_version()` to the ELF parsing abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49564/#review140516 --- Fix it, then Ship it! 3rdparty/stout/include/stout/elf.hpp

Re: Review Request 49562: Reimplemented the stout ELF abstraction in terms of ELFIO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49562/#review140511 --- Fix it, then Ship it! 3rdparty/stout/include/stout/elf.hpp

Re: Review Request 49563: Reimplemented ldcache_test.cpp using the new ELF abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49563/#review140515 --- Ship it! Ship It! - Benjamin Mahler On July 2, 2016, 7:35

Re: Review Request 49559: Added ELFIO as bundled dependency in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49559/#review140510 --- Fix it, then Ship it! 3rdparty/Makefile.am (line 175)

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

> On July 2, 2016, 5:46 a.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 580 > > > > > > Please use UUID::random here. I've made the changes. But consider if both UUID's were the

Re: Review Request 49560: Added ELFIO as bundled dependency in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49560/#review140513 --- Ship it! Ship It! - Benjamin Mahler On July 2, 2016, 7:26

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/ --- (Updated July 2, 2016, 9:50 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 49562: Reimplemented the stout ELF abstraction in terms of ELFIO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49562/#review140509 --- 3rdparty/stout/include/stout/elf.hpp (line 76)

Re: Review Request 49561: Added ELFIO as bundled dependency in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49561/ --- (Updated July 2, 2016, 8:29 p.m.) Review request for mesos and Benjamin

Re: Review Request 49558: Added Nvidia License information for our bundled NVML header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49558/#review140508 --- Ship it! Ship It! - Benjamin Mahler On July 2, 2016, 8:22

Re: Review Request 49558: Added Nvidia License information for our bundled NVML header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49558/ --- (Updated July 2, 2016, 8:22 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 49546: Added device support to Docker::run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49546/#review140507 --- Fix it, then Ship it! src/docker/docker.cpp (line 677)

Re: Review Request 49473: Made control pipe to mesos-containerizer launch optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49473/#review140505 --- Fix it, then Ship it! LGTM! Just find some nits not from your

Re: Review Request 49559: Added ELFIO as bundled dependency in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49559/ --- (Updated July 2, 2016, 8:08 p.m.) Review request for mesos and Benjamin

Re: Review Request 49566: Integrated the 'NvidiaVolume' component into 'NvidiaComponents'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49566/#review140506 --- Bad patch! Reviews applied: [49566, 49565, 49564, 49563, 49562,

Re: Review Request 49545: Updated code to use Path::string() instead of Path::value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49545/#review140504 --- Assuming we still want to have the `.string()` function on the

Re: Review Request 49544: Made stout::Path default constructible / assignable / copyable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49544/#review140503 --- 3rdparty/stout/include/stout/path.hpp (lines 255 - 261)

Review Request 49566: Integrated the 'NvidiaVolume' component into 'NvidiaComponents'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49566/ --- Review request for mesos, Benjamin Mahler, Yubo Li, and Vikrama Ditya. Bugs:

Review Request 49565: Added a new 'NvidiaVolume' component.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49565/ --- Review request for mesos, Benjamin Mahler, Yubo Li, and Vikrama Ditya. Bugs:

Review Request 49564: Added `get_abi_version()` to the ELF parsing abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49564/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5769

Review Request 49563: Reimplemented ldcache_test.cpp using the new ELF abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49563/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5768

Review Request 49562: Reimplemented the stout ELF abstraction in terms of ELFIO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49562/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5768

Review Request 49561: Added ELFIO as bundled dependency in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49561/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5767

Review Request 49560: Added ELFIO as bundled dependency in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49560/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5767

Review Request 49559: Added ELFIO as bundled dependency in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49559/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5767

Review Request 49558: Added Nvidia License information for our bundled NVML header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49558/ --- Review request for mesos, Benjamin Mahler and Vikrama Ditya. Bugs: MESOS-5766

Re: Review Request 49370: Updateted documentation for roles endpoint filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49370/ --- (Updated July 2, 2016, 5:41 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 49369: Introduced authorization based filtering for /roles.

> On July 1, 2016, 6:58 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 2908-2950 > > > > > > not completely yours, but would you mind refactoring this part into > > `_roles()` so that both `roles()` and

Re: Review Request 49554: Fixed HealthCheck typo in `launcher/executor.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49554/#review140499 --- Ship it! Ship It! - Timothy Chen On July 2, 2016, 3:12

Re: Review Request 49553: Fixed indentions of HealthCheck files in src/Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49553/#review140498 --- Ship it! Ship It! - Timothy Chen On July 2, 2016, 3:12

Re: Review Request 49424: Added an abstraction os::raw::Argv in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49424/#review140451 --- 3rdparty/stout/include/stout/os/raw/argv.hpp (line 27)

Re: Review Request 49436: Added test cases for tcp health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49436/#review140497 --- Patch looks great! Reviews applied: [49553, 49554, 49555, 49556,

Re: Review Request 49516: Refactor Master::Http::getExecutors into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49516/#review140495 --- Ship it! Ship It! - haosdent huang On July 1, 2016, 11:45

Re: Review Request 49489: Refactor master::Http::getFrameworks to helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/#review140494 --- Ship it! Ship It! - haosdent huang On July 1, 2016, 11:42

Re: Review Request 49489: Refactor master::Http::getFrameworks to helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/#review140493 --- Ship it! Ship It! - haosdent huang On July 1, 2016, 11:42

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/#review140492 --- Ship it! Ship It! - haosdent huang On July 1, 2016, 11:34

Re: Review Request 49487: Refactor Master::Http::getTasks into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49487/#review140491 --- Ship it! Ship It! - haosdent huang On July 1, 2016, 11:32

Re: Review Request 49443: Include a function to construct FileInfo protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49443/#review140490 --- Ship it! Ship It! - haosdent huang On July 1, 2016, 7:49

Re: Review Request 49556: Removed the binary way of HealthCheck.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49556/ --- (Updated July 2, 2016, 3:13 p.m.) Review request for mesos, Alexander

Re: Review Request 49553: Fixed indentions of HealthCheck files in src/Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49553/ --- (Updated July 2, 2016, 3:12 p.m.) Review request for mesos, Alexander

Re: Review Request 49554: Fixed HealthCheck typo in `launcher/executor.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49554/ --- (Updated July 2, 2016, 3:12 p.m.) Review request for mesos, Alexander

Review Request 49556: Removed the binary way of HealthCheck.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49556/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song,

Re: Review Request 49436: Added test cases for tcp health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49436/ --- (Updated July 2, 2016, 3:10 p.m.) Review request for mesos, Alexander

Re: Review Request 49435: Added test cases for http health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49435/ --- (Updated July 2, 2016, 3:08 p.m.) Review request for mesos, Alexander

Re: Review Request 49434: Clean up `HealthCheckTest.populateTasks` methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49434/ --- (Updated July 2, 2016, 3:08 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP check in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated July 2, 2016, 3:08 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated July 2, 2016, 3:07 p.m.) Review request for mesos, Alexander

Re: Review Request 49351: Clean up HealthCheck code in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49351/ --- (Updated July 2, 2016, 3:07 p.m.) Review request for mesos, Alexander

Review Request 49555: Updated docker executor to use HealthCheck via library way.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49555/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song,

Review Request 49553: Fixed indentions of HealthCheck files in src/Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49553/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song,

Re: Review Request 49426: Added implementation to Appc runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49426/#review140488 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 49552: Fixed typo in docker runtime.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49552/#review140487 --- Patch looks great! Reviews applied: [49552] Passed command:

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/#review140485 --- Seems most comments are style issue, so I would suggest that you

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

> On 七月 2, 2016, 10:19 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/appc/runtime.cpp, lines 202-205 > > > > > > 1. s/Exec/'Exec' > > 2. Add period to the end of each comment. > > > >

Re: Review Request 49426: Added implementation to Appc runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49426/#review140484 --- Srini, do you want to drop this as this is same with

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/#review140475 --- src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line

Review Request 49552: Fixed typo in docker runtime.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49552/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 49448: Added testcases for LIST_FILES call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49448/#review140483 --- Patch looks great! Reviews applied: [49301, 49443, 49444, 49445,

Re: Review Request 49524: Fixed a const ref issue in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49524/#review140482 --- Ship it! Ship It! - Qian Zhang On July 2, 2016, 2:02 a.m.,

Re: Review Request 49447: Implemented LIST_FILES Call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49447/ --- (Updated July 2, 2016, 7:55 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49529: Removed jsonFileInfo implementation from files.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49529/ --- (Updated July 2, 2016, 7:51 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49448: Added testcases for LIST_FILES call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49448/ --- (Updated July 2, 2016, 7:50 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49448: Added testcases for LIST_FILES call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49448/ --- (Updated July 2, 2016, 7:45 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 49551: Overloaded equality(==) operator for `FileInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49551/ --- Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod

Review Request 49550: Added evolve function for `FileInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49550/ --- Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod

Re: Review Request 49446: Implemented LIST_FILES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49446/ --- (Updated July 2, 2016, 7:35 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49445/ --- (Updated July 2, 2016, 7:32 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/#review140480 --- Bad patch! Reviews applied: [49414] Failed command: