Re: Review Request 51865: Added validation for `ContainerInfo`.

> On Sept. 19, 2016, 9:24 a.m., Jan Schlicht wrote: > > src/master/validation.cpp, lines 63-78 > > > > > > This will cause problems with tasks that don't use a container image: > > While `ContainerInfo.type` is

Re: Review Request 51870: Added a test for reservation info in the agent's endpoint.

> On Sept. 18, 2016, 11:35 a.m., Anindya Sinha wrote: > > src/tests/reservation_endpoints_tests.cpp, line 1671 > > > > > > This test verifies the keys `reserved_resources` as well as > > `reserved_resources_full`,

Re: Review Request 51870: Added a test for reservation info in the agent's endpoint.

> On Sept. 18, 2016, 7:37 a.m., haosdent huang wrote: > > src/tests/reservation_endpoints_tests.cpp, lines 1652-1654 > > > > > > I think you `settle` here to wait for `Slave::checkpointResources` > > finished,

Re: Review Request 51868: Expose full reservation info in the agent's http endpoint.

> On Sept. 18, 2016, 7:01 a.m., haosdent huang wrote: > > The documents `docs/persistent-volume.md` and `docs/reservation.md` need to > > be updated. True. Will do as a separate reviews. - Jiang Yan --- This is an automatically

Re: Review Request 51869: Export "reserved_resources" in the agent HTTP endpoint.

> On Sept. 18, 2016, 6:51 a.m., haosdent huang wrote: > > It would be better that we add this in the new operator api as well. Should > > I create a ticket at https://issues.apache.org/jira/browse/MESOS-6007 ? We should (my comment above). I'll take care of it. - Jiang Yan

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/#review149490 --- src/common/resources.cpp (lines 616 - 648)

Re: Review Request 51654: Fixed help display for mesos-containerizer subcommands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51654/#review149491 --- Patch looks great! Reviews applied: [51654] Passed command:

Re: Review Request 51879: Determine disk size when not specified in static resources.

> On Sept. 18, 2016, 6:22 p.m., haosdent huang wrote: > > src/slave/containerizer/containerizer.cpp, line 201 > > > > > > `!resource.has_disk()` It is possible that has_disk() is false and `name` is "disk". Let me

Re: Review Request 51865: Added validation for `ContainerInfo`.

> On Sept. 19, 2016, 9:24 a.m., Jan Schlicht wrote: > > src/master/validation.cpp, lines 63-78 > > > > > > This will cause problems with tasks that don't use a container image: > > While `ContainerInfo.type` is

Re: Review Request 52034: Disabled error dialog in WebUI when user is unauthorized to see metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52034/#review149481 --- Patch looks great! Reviews applied: [52034] Passed command:

Review Request 52042: Changed error message in pailer if user is unauthorized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52042/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Review Request 52039: Avoided using SIGUSR1 in two test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52039/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 51715: Added a parallel gtest runner.

> On Sept. 15, 2016, 3:16 a.m., Kevin Klues wrote: > > support/mesos-gtest-runner.py, lines 36-37 > > > > > > What is a shard in this context? I introduce this term in the script docstring now. > On Sept. 15,

Re: Review Request 51715: Added a parallel gtest runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- (Updated Sept. 19, 2016, 4:35 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 19, 2016, 4:21 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 10, 2016, 8:23 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/capabilities.cpp, lines 47-49 > > > > > > We need to have special case for command tasks (i.e., > >

Review Request 51930: Introduced Linux capabilities support for Mesos executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51930/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5275

Review Request 51931: Added `ping` to test linux rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51931/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5275

Re: Review Request 51654: Fixed help display for mesos-containerizer subcommands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51654/ --- (Updated Sept. 19, 2016, 4:19 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52033/#review149473 --- Patch looks great! Reviews applied: [52031, 52033] Passed

Re: Review Request 52020: Fixed indent in allocator.

> On 九月 19, 2016, 1:20 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1653 > > > > > > This looks fine: 4 spaces after '('. Does the indent always start from begining? 1)

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52033/ --- (Updated Sept. 19, 2016, 1:50 p.m.) Review request for mesos, Joris Van

Re: Review Request 52033: Escalated logs from VLOG to LOG INFO..

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52033/ --- (Updated Sept. 19, 2016, 1:49 p.m.) Review request for mesos, Joris Van

Review Request 52034: Disabled error dialog in WebUI when user is unauthorized to see metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52034/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Re: Review Request 52023: Added the JIRA link for MESOS-3938 in quota.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52023/#review149465 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 19, 2016,

Re: Review Request 52020: Fixed indent in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52020/#review149464 --- src/master/allocator/mesos/hierarchical.cpp (line 1653)

Re: Review Request 51376: Adjusted existing tests to use MockRegistrar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51376/ --- (Updated Sept. 19, 2016, 1:15 p.m.) Review request for mesos and Vinod Kone.

Review Request 52033: Escalated some openssl logs from VLOG to INFO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52033/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Bugs: MESOS-5320

Review Request 52031: Added openssl error string output to initializing failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52031/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Bugs: MESOS-5320

Re: Review Request 52025: Replaced unchecked `dynamic_cast` with `static_cast`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52025/#review149462 --- Patch looks great! Reviews applied: [52025] Passed command:

Re: Review Request 52002: Added helper methods to determine types of disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review149440 --- src/common/resources.cpp (lines 930 - 931)

Re: Review Request 52023: Added the JIRA link for MESOS-3938 in quota.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52023/#review149457 --- Patch looks great! Reviews applied: [52023] Passed command:

Re: Review Request 51840: Fixed leak of task.

> On Sept. 13, 2016, 3:16 p.m., Anand Mazumdar wrote: > > Thanks for fixing this. > > > > Ideally, I would like to not create the `Task` object/delete the key from > > `queuedTasks` on L6549/L6554 but instead do it in the `else` block on > > L6569. I would take care of cleaning it up as part

Re: Review Request 51865: Added validation for `ContainerInfo`.

> On Sept. 19, 2016, 11:24 a.m., Jan Schlicht wrote: > > src/master/validation.cpp, lines 63-78 > > > > > > This will cause problems with tasks that don't use a container image: > > While `ContainerInfo.type` is

Review Request 52025: Replaced unchecked `dynamic_cast` with `static_cast`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52025/ --- Review request for mesos. Repository: mesos Description --- `Process`

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/docker/docker.hpp, lines 73-84 > > > > > > In general, we don't typically have constructors for `structs` like > > this. Instead, we just set its fields

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149448 --- Bad patch! Reviews applied: [51978, 51991, 51990, 51623] Failed

Re: Review Request 51865: Added validation for `ContainerInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51865/#review149445 --- src/master/validation.cpp (lines 63 - 78)

Review Request 52023: Added the JIRA link for MESOS-3938 in quota.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52023/ --- Review request for mesos, Alexander Rukletsov and Joseph Wu. Repository: mesos

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 九月 19, 2016, 7:17 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 九月 19, 2016, 7:16 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

> On 八月 25, 2016, 5:29 p.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, lines 1275-1289 > > > > > > This should probably just be moved into the next patch since it doesn't > > really do much here

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/ --- (Updated Sept. 19, 2016, 6:54 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/#review149433 --- Ditto for v1 src/common/resources.cpp (line 610)

Re: Review Request 52020: Fixed indent in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52020/#review149439 --- Patch looks great! Reviews applied: [52020] Passed command:

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51978/#review149436 --- Fix it, then Ship it! Ship It! src/cli/execute.cpp (line

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, lines 666-668 > > > > > > I would do this as the first check in this function. If we don't have > > an allocator set, then

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51978/ --- (Updated Sept. 19, 2016, 6:14 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review149431 --- include/mesos/resources.hpp (line 184)

Re: Review Request 51999: Refactor parsing of resources to include all valid resources.

> On 九月 19, 2016, 6 a.m., Guangya Liu wrote: > > Ditto for all v1 files. - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review149431

<    1   2