Re: Review Request 54328: Fixed HttpServeTests to connect to a non-ANY address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54328/#review157890 --- Patch looks great! Reviews applied: [54328] Passed command:

Review Request 54337: Fixed the attach input call validation on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54337/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review157888 --- Patch looks great! Reviews applied: [53096, 45962, 49571]

Re: Review Request 54198: Added Resource.Allocation in Offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54198/#review157883 --- Ship it! include/mesos/mesos.proto (lines 1325 - 1329)

Review Request 54333: Fixed error messages to say "form body" rather than "query parameter".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54333/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/#review157867 --- src/master/master.hpp (line 672)

Re: Review Request 54302: Added three tests to ensure master validates roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54302/#review157882 --- Fix it, then Ship it! Looks good, just some minor suggestions.

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 3, 2016, 2:07 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 54300: Added a test for validateRoles method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54300/#review157881 --- Some minor suggestions, I'll make the edits prior to committing.

Re: Review Request 54300: Added a test for validateRoles method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54300/#review157880 --- Ship it! Ship It! - Benjamin Mahler On Dec. 3, 2016, 1:49

Re: Review Request 54302: Added three tests to ensure master validates roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54302/ --- (Updated Dec. 3, 2016, 1:55 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 52382: Added stubs for OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52382/ --- (Updated Dec. 3, 2016, 9:51 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 52349: Add protobuf messages for OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52349/ --- (Updated Dec. 3, 2016, 9:50 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 52379: Added agent flag '--oci_store_dir'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52379/ --- (Updated Dec. 3, 2016, 9:51 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54300: Added a test for validateRoles method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54300/ --- (Updated Dec. 3, 2016, 1:49 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 54304: Added explicit break statements in switch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54304/#review157879 --- Ship it! Ship It! - Benjamin Mahler On Dec. 2, 2016, 10:48

Re: Review Request 54301: Introduced 'roles' validation in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54301/#review157843 --- Ship it! src/master/master.cpp (lines 2382 - 2386)

Re: Review Request 53688: Implement a namespace/ipc isolator.

> On Dec. 2, 2016, 6:20 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp, line 28 > > > > > > Any reason why we are not inhertiting it from a `MesosIsolatorProcess` > > ?

Re: Review Request 53688: Implement a namespace/ipc isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53688/#review157875 --- src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp (line

Re: Review Request 54062: Introduced validateRoles method for FrameworkInfo.

> On Dec. 2, 2016, 8:19 a.m., Qian Zhang wrote: > > src/master/master.cpp, line 2373 > > > > > > I think you can merge the logic of `isValidFailoverTimeout()` into the > > method

Re: Review Request 53931: Don't expect an init process in a FreeBSD jail.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53931/#review157872 --- Ship it! Ship It! - Ian Downes On Nov. 19, 2016, 11:13

Re: Review Request 54300: Added a test for validateRoles method.

> On 十二月 2, 2016, 10:17 p.m., Benjamin Mahler wrote: > > src/tests/master_validation_tests.cpp, lines 2371-2380 > > > > > > How about splitting each case with a block? As it stands its a bit hard > > to read what

Re: Review Request 53927: Check isJailed in tests that call mknod.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53927/#review157871 --- Ship it! Ship It! - Ian Downes On Nov. 18, 2016, 10:45

Re: Review Request 53926: Move isJailed for FreeBSD into utils.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53926/#review157869 --- Ship it! Ship It! - Ian Downes On Nov. 19, 2016, 4:42 p.m.,

Re: Review Request 53925: Fix wait macros on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53925/#review157868 --- Ship it! Ship It! - Ian Downes On Nov. 18, 2016, 10:17

Re: Review Request 53913: Disable sentinel checks for clang on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53913/#review157866 --- Ship it! Ship It! - Ian Downes On Nov. 18, 2016, 4:11 p.m.,

Re: Review Request 53912: Fix xattr for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53912/#review157865 --- Ship it! Ship It! - Ian Downes On Nov. 18, 2016, 4:10 p.m.,

Re: Review Request 53882: Fix configure on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53882/#review157864 --- Ship it! Ship It! - Ian Downes On Nov. 18, 2016, 4:11 p.m.,

Re: Review Request 52778: Added Windows support to Agent test environment harness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52778/ --- (Updated Dec. 3, 2016, 12:06 a.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 53552: Remove unnecessary use of `typename` causing Windows build break.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53552/ --- (Updated Dec. 3, 2016, 12:06 a.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 53550: Rename symbols in log.proto to avoid naming collision in win32 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53550/ --- (Updated Dec. 3, 2016, 12:06 a.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 53551: Fix namespace resolution issue for Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53551/ --- (Updated Dec. 3, 2016, 12:06 a.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 52210: Fixed warnings in `getcwd.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52210/#review157861 --- Ship it! Ship It! - Joseph Wu On Nov. 13, 2016, 9:47 p.m.,

Re: Review Request 54324: Fixed switchboard build break on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54324/#review157857 --- Ship it! Ship It! - Joseph Wu On Dec. 2, 2016, 2:15 p.m.,

Re: Review Request 54309: Fixed ownership semantics of `DynamicLibrary`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54309/#review157856 --- Ship it! Ship It! - Joseph Wu On Dec. 2, 2016, 7:45 a.m.,

Review Request 54328: Fixed HttpServeTests to connect to a non-ANY address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54328/ --- Review request for mesos, Benjamin Mahler and Alex Clemmer. Repository: mesos

Re: Review Request 53896: Refactored representation of framework connectedness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53896/#review157852 --- src/master/master.hpp (line 2527)

Re: Review Request 54311: Fixes for whitespace, style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54311/#review157851 --- Patch looks great! Reviews applied: [54310, 54311] Passed

Re: Review Request 54300: Added a test for validateRoles method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54300/#review157842 --- src/tests/master_validation_tests.cpp (lines 2366 - 2368)

Re: Review Request 54324: Fixed switchboard build break on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54324/ --- (Updated Dec. 2, 2016, 10:15 p.m.) Review request for mesos, Andrew

Re: Review Request 52778: Added Windows support to Agent test environment harness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52778/#review157837 --- Fix it, then Ship it! src/tests/utils.cpp (lines 38 - 42)

Re: Review Request 54036: Fixed WebUI error on Firefox 45.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54036/#review157836 --- Ship it! Ship It! - Benjamin Mahler On Nov. 23, 2016, 4:53

Re: Review Request 54062: Introduced validateRoles method for FrameworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review157830 --- Ship it! src/master/validation.cpp (lines 267 - 268)

Re: Review Request 53895: Changed the allocator API to allow adding inactive frameworks.

> On Dec. 2, 2016, 9:42 p.m., Vinod Kone wrote: > > Since allocator is modularized, can you add a blurb to CHANGELOG that it > > breaks the interface? Done. I also create a new JIRA (MESOS-6675) for the allocator API change. - Neil

Re: Review Request 53895: Changed the allocator API to allow adding inactive frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53895/ --- (Updated Dec. 2, 2016, 9:50 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53895: Changed the allocator API to allow adding inactive frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53895/ --- (Updated Dec. 2, 2016, 9:47 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Dec. 2, 2016, 9:43 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Dec. 2, 2016, 9:43 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53096/ --- (Updated Dec. 2, 2016, 9:43 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53895: Changed the allocator API to allow adding inactive frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53895/#review157831 --- Since allocator is modularized, can you add a blurb to CHANGELOG

Re: Review Request 53894: Added helper function, `Master::isCompletedFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53894/#review157829 --- Ship it! Ship It! - Vinod Kone On Nov. 18, 2016, 7:19 p.m.,

Re: Review Request 53893: Avoided sending `LostSlaveMessage` to disconnected frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53893/#review157828 --- Ship it! Ship It! - Vinod Kone On Nov. 18, 2016, 7:19 p.m.,

Re: Review Request 53892: Fixed typo, removed hard tab character.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53892/#review157827 --- Ship it! Ship It! - Vinod Kone On Nov. 18, 2016, 7:18 p.m.,

Re: Review Request 53891: Replaced "slave" with "agent" in status update messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53891/#review157826 --- Ship it! Yay! Thanks. - Vinod Kone On Nov. 18, 2016, 7:17

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Dec. 2, 2016, 8:56 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53890: Tweaked usage of `getFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53890/#review157820 --- Ship it! Ship It! - Vinod Kone On Nov. 21, 2016, 9:26 p.m.,

Re: Review Request 53889: Improved comments in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53889/#review157818 --- Ship it! Ship It! - Vinod Kone On Nov. 18, 2016, 7:15 p.m.,

Re: Review Request 53888: Improved SlaveRecoveryTest.ReconcileShutdownFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53888/ --- (Updated Dec. 2, 2016, 8:40 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53887: Improved FaultToleranceTest.FrameworkReregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53887/ --- (Updated Dec. 2, 2016, 8:38 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53886: Improved TeardownTest.Success.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53886/ --- (Updated Dec. 2, 2016, 8:38 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54304: Added explicit break statements in switch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54304/#review157816 --- 3rdparty/libprocess/include/process/address.hpp (lines 358 -

Re: Review Request 54309: Fixed ownership semantics of `DynamicLibrary`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54309/#review157815 --- Patch looks great! Reviews applied: [54309] Passed command:

Re: Review Request 54295: Added a synchronous version of loop for io::read/write/redirect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54295/#review157814 --- Fix it, then Ship it!

Re: Review Request 54262: Added macOS 10.12 instructions to the getting started page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54262/ --- (Updated Dec. 2, 2016, 8:18 p.m.) Review request for mesos, Jie Yu and James

Re: Review Request 54262: Added macOS 10.12 instructions to the getting started page.

> On Dec. 2, 2016, 5:51 p.m., James Peach wrote: > > docs/getting-started.md, line 98 > > > > > > I would do: > > ``` > > --with-apr=$(brew --prefix apr)/libexec > > --with-svn=$(brew --prefix subversion)

Re: Review Request 54279: Made `configure.ac` default to use brew apr on OS X in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54279/#review157812 --- Ship it! Maybe document that this brings it on par with the

Re: Review Request 54280: Made `configure.ac` default to use to brew apr on OS X in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54280/#review157811 --- Ship it! Maybe document that this brings it on par with the

Re: Review Request 54278: Made `configure.ac` default to use brew apr on OS X in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54278/#review157810 --- Ship it! Thanks! This should simplify my update to the getting

Re: Review Request 54292: Added os::setctty to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54292/#review157802 --- 3rdparty/stout/include/stout/posix/os.hpp (lines 494 - 501)

Re: Review Request 54291: Added os::ptsname to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/#review157800 --- 3rdparty/stout/include/stout/posix/os.hpp (line 480)

Re: Review Request 54290: Added a ErrnoFailure similar to ErrnoError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54290/#review157798 --- Ship it! Ship It! - Kevin Klues On Dec. 2, 2016, 6:29 p.m.,

Re: Review Request 54289: Added a check to require I/O switchboard server for TTY support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54289/#review157796 --- Ship it! Ship It! - Kevin Klues On Dec. 2, 2016, 6:29 p.m.,

Re: Review Request 54304: Added explicit break statements in switch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54304/#review157791 --- Patch looks great! Reviews applied: [54304] Passed command:

Re: Review Request 53888: Improved SlaveRecoveryTest.ReconcileShutdownFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53888/#review157790 --- Fix it, then Ship it! src/tests/slave_recovery_tests.cpp

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157789 --- src/slave/containerizer/mesos/io/switchboard.cpp (lines 947 -

Re: Review Request 53887: Improved FaultToleranceTest.FrameworkReregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53887/#review157784 --- Fix it, then Ship it! src/tests/fault_tolerance_tests.cpp

Re: Review Request 53886: Improved TeardownTest.Success.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53886/#review157782 --- Fix it, then Ship it! src/tests/teardown_tests.cpp (line 115)

Re: Review Request 53885: Removed stuttering from teardown test names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53885/#review157781 --- Ship it! Ship It! - Vinod Kone On Nov. 18, 2016, 7:12 p.m.,

Re: Review Request 53310: Updated no-longer-accurate comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53310/#review157780 --- Ship it! Ship It! - Vinod Kone On Oct. 31, 2016, 5:20 p.m.,

Re: Review Request 54294: Added an I/O switchboard test with TTY enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54294/ --- (Updated Dec. 2, 2016, 6:30 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54293: Supported TTY in I/O switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54293/ --- (Updated Dec. 2, 2016, 6:29 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54292: Added os::setctty to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54292/ --- (Updated Dec. 2, 2016, 6:29 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54291: Added os::ptsname to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/ --- (Updated Dec. 2, 2016, 6:29 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54289: Added a check to require I/O switchboard server for TTY support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54289/ --- (Updated Dec. 2, 2016, 6:29 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54290: Added a ErrnoFailure similar to ErrnoError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54290/ --- (Updated Dec. 2, 2016, 6:29 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157775 --- Let me commit the attach output review/`serv()` to use the

Re: Review Request 54296: Updated the IOSwitchboard http handler to work with streaming requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54296/#review157774 --- Fix it, then Ship it! LGTM, I would fix the minor nit before

Re: Review Request 54262: Added macOS 10.12 instructions to the getting started page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54262/#review157770 --- docs/getting-started.md (line 98)

Re: Review Request 53688: Implement a namespace/ipc isolator.

> On Dec. 2, 2016, 6:20 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp, line 28 > > > > > > Any reason why we are not inhertiting it from a `MesosIsolatorProcess` > > ?

Re: Review Request 54310: Added missing break statements.

> On Dec. 2, 2016, 5:38 p.m., Benjamin Bannier wrote: > > There's already https://reviews.apache.org/r/54304/. Sure, either change is fine -- although benh is probably too busy to review. Note that this _is_ a functional change. - Neil

Re: Review Request 54310: Added missing break statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54310/#review157766 --- There's already https://reviews.apache.org/r/54304/. - Benjamin

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Dec. 2, 2016, 5:18 p.m.) Review request for mesos and Vinod Kone.

Review Request 54312: Added TASK_UNREACHABLE to master's state-summary endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54312/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6388

Review Request 54311: Fixes for whitespace, style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54311/ --- Review request for mesos. Repository: mesos Description --- Fixes for

Review Request 54310: Added missing break statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54310/ --- Review request for mesos. Repository: mesos Description --- Spotted via

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157762 --- Patch looks great! Reviews applied: [54274, 54296, 54297]

Review Request 54309: Fixed ownership semantics of `DynamicLibrary`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54309/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-6672

Re: Review Request 54295: Added a synchronous version of loop for io::read/write/redirect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54295/#review157754 --- Patch looks great! Reviews applied: [54295] Passed command:

Re: Review Request 54302: Added three tests to ensure master validates roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54302/#review157748 --- Fix it, then Ship it! The `Testing Done` section needs some

Re: Review Request 54300: Added a test for validateRoles method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54300/#review157742 --- Can you please update the `Testing Done` section by adding some

  1   2   >