Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.

> On Dec. 22, 2016, 4:21 a.m., haosdent huang wrote: > > Basically it looks good to me. > > > > Have some simple issues we would like to discuss more: > > > > * Should we keep so much fields in `RunOptions`? > > * Should we use `vector cmd` in `RunOptions`? Or use `CommandInfo` > > directly.

Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54821/#review160032 --- src/docker/docker.hpp (line 171)

Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.

> On Dec. 22, 2016, 4:21 a.m., haosdent huang wrote: > > Basically it looks good to me. > > > > Have some simple issues we would like to discuss more: > > > > * Should we keep so much fields in `RunOptions`? > > * Should we use `vector cmd` in `RunOptions`? Or use `CommandInfo` > > directly.

Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.

> On Dec. 22, 2016, 4:21 a.m., haosdent huang wrote: > > Basically it looks good to me. > > > > Have some simple issues we would like to discuss more: > > > > * Should we keep so much fields in `RunOptions`? > > * Should we use `vector cmd` in `RunOptions`? Or use `CommandInfo` > > directly.

Re: Review Request 55006: CMake: renamed test binaries to match autotools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55006/ --- (Updated Dec. 22, 2016, 6:22 p.m.) Review request for mesos, Alex Clemmer and

Review Request 55005: CMake: renamed `process_tests` to `libprocess-tests` to match autotools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55005/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos

Review Request 55006: CMake: renamed test binaries to match autotools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55006/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos

Review Request 55004: CMake: renamed `stout_tests` to `stout-tests` to match autotools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55004/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos

Re: Review Request 54983: Fixed the CMake test target in stout.

> On Dec. 22, 2016, 10:41 a.m., Joseph Wu wrote: > > I thought you were also going to rename the `stout_tests` target to > > `stout-tests`? I will :) - Michael --- This is an automatically generated e-mail. To reply, visit:

Review Request 54999: Fixed test flakiness due to floating point conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54999/ --- Review request for mesos, Alexander Rukletsov and Benjamin Bannier. Bugs:

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- (Updated Dec. 22, 2016, 9:24 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54993: Modify LevelDB patch to add ARM64/AArch64 support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54993/ --- (Updated Dec. 22, 2016, 9:10 p.m.) Review request for mesos and Jie Yu.

Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6835

Re: Review Request 54993: Modify LevelDB patch to add ARM64/AArch64 support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54993/ --- (Updated Dec. 22, 2016, 9:02 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54993: Modify LevelDB patch to add ARM64/AArch64 support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54993/ --- (Updated Dec. 22, 2016, 9 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54952: Made `getpwnam_r` error handling more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54952/ --- (Updated Dec. 22, 2016, 8:50 p.m.) Review request for mesos and Alexander

Review Request 54993: Modify LevelDB patch to add ARM64/AArch64 support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54993/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6834

Re: Review Request 54987: Updated `docs/monitoring/md` for new slave event queue metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54987/#review160001 --- Ship it! Ship It! - Jason Lai On Dec. 22, 2016, 5:13 p.m.,

Re: Review Request 54986: Added metric for slave message queue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54986/#review159998 --- Ship it! LGTM - Jason Lai On Dec. 22, 2016, 5:12 p.m.,

Review Request 54688: Added a `docker_store_dir` flag to tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54688/ --- Review request for mesos. Repository: mesos Description --- We can use

Re: Review Request 54952: Added EINVAL to the list of expected `getpwnam_r()` errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54952/#review159995 --- I'm not quite sure the error processing logic of the functions

Re: Review Request 54985: Fixed the CMake test target in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54985/#review159993 --- Ship it! Ship It! - Joseph Wu On Dec. 22, 2016, 8:41 a.m.,

Re: Review Request 54984: Fixed the CMake test target in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54984/#review159992 --- Ship it! I thought you were also going to rename the

Re: Review Request 54983: Fixed the CMake test target in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54983/#review159991 --- Ship it! I thought you were also going to rename the

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.

> On Dec. 22, 2016, 4:21 a.m., haosdent huang wrote: > > Basically it looks good to me. > > > > Have some simple issues we would like to discuss more: > > > > * Should we keep so much fields in `RunOptions`? > > * Should we use `vector cmd` in `RunOptions`? Or use `CommandInfo` > > directly.

Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54821/ --- (Updated Dec. 22, 2016, 5:17 p.m.) Review request for mesos, Xiaojian Huang,

Review Request 54987: Updated `docs/monitoring/md` for new slave event queue metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54987/ --- Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Jason Lai. Bugs:

Review Request 54986: Added metric for slave message queue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54986/ --- Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Jason Lai. Bugs:

Review Request 54985: Fixed the CMake test target in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54985/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos

Review Request 54983: Fixed the CMake test target in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54983/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos

Re: Review Request 54889: Handled all possible offers in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54889/#review159966 --- Ship it! Ship It! - Alexander Rukletsov On Dec. 20, 2016,

Re: Review Request 54974: Actually overloaded function from base class in LibeventSSLSocketImpl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54974/#review159953 --- See https://issues.apache.org/jira/browse/MESOS-6789 for more

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/#review159950 --- Looks pretty reasonable to me, but I've got a few questions about

Re: Review Request 54928: Added initial random delay to agent (re)registration.

> On Dec. 22, 2016, 3:49 a.m., Joseph Wu wrote: > > Note: Even with this chain of reviews, the following tests continue to fail when `HAS_AUTHENTICATION=0`: ``` [ FAILED ] AuthenticationTest.UnauthenticatedFramework [ FAILED ] AuthenticationTest.UnauthenticatedSlave [ FAILED ]

Re: Review Request 54909: Fixed spurious registration bug in framework and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54909/#review159945 --- Fix it, then Ship it! I'm going to add this comment block

Re: Review Request 54927: Fixed partition to pass when `HAS_AUTHENTICATED` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54927/#review159948 --- Ship it! Note: typo in your commit summary `HAS_AUTHENTICATED`

Re: Review Request 54910: Fixed more tests to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54910/#review159947 --- Ship it! - Joseph Wu On Dec. 20, 2016, 2:09 p.m., Alex

Re: Review Request 54928: Added initial random delay to agent (re)registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54928/#review159949 --- Ship it! - Joseph Wu On Dec. 20, 2016, 7:16 p.m., Alex

Review Request 54974: Actually overloaded function from base class in LibeventSSLSocketImpl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54974/ --- Review request for mesos, Benjamin Hindman and Benjamin Mahler. Repository:

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/#review159850 --- Ship it! Confirmed that these changes will fix the tests when

Re: Review Request 54896: Fixed copy-template-and-create-symlink make target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54896/#review159943 --- Ship it! Ship It! - Till Toenshoff On Dec. 21, 2016, 11:20

Re: Review Request 54753: Leaked module libraries to avoid inconsitencies in library unloading.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54753/#review159941 --- Ship it! This change is sufficient to fix what the (cmake)