Re: Review Request 55542: Re-enabled a test.

2017-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55542/#review161654 --- Bad patch! Reviews applied: [55539, 55540, 55541, 55542] Failed

Re: Review Request 55496: Fixed parsing of proxy CONNECT responses.

2017-01-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55496/#review161653 --- 3rdparty/libprocess/src/decoder.hpp (lines 414 - 423)

Review Request 55542: Re-enabled a test.

2017-01-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55542/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Benjamin Mahler,

Re: Review Request 55491: Added a `jenkins/tidybot.sh`.

2017-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55491/#review161652 --- Bad patch! Reviews applied: [55487, 55488, 55489, 55490, 55491]

Review Request 55540: Re-enabled disabled test.

2017-01-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55540/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Benjamin Mahler,

Review Request 55539: Replaced recursive implementation in http::Connection with loop.

2017-01-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55539/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Kevin Klues.

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

2017-01-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review161648 --- src/master/master.cpp (lines 2473 - 2506)

Re: Review Request 55491: Added a `jenkins/tidybot.sh`.

2017-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55491/ --- (Updated Jan. 14, 2017, 12:04 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 55491: Added a `jenkins/tidybot.sh`.

2017-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55491/ --- (Updated Jan. 14, 2017, 12:03 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 55489: Used CMake to generate the compilation database instead.

2017-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55489/ --- (Updated Jan. 14, 2017, 12:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/ --- (Updated Jan. 14, 2017, 12:02 p.m.) Review request for mesos and Benjamin

Re: Review Request 55488: Slimmed down the size of the docker image from 2GB to roughly 650MB.

2017-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55488/ --- (Updated Jan. 14, 2017, 12:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 55489: Used CMake to generate the compilation database instead.

2017-01-14 Thread Benjamin Bannier
> On Jan. 13, 2017, 1 p.m., Benjamin Bannier wrote: > > support/mesos-tidy/entrypoint.sh, line 27 > > > > > > Left over debug tooling? > > Michael Park wrote: > I use this a bunch of times below. I think we

Re: Review Request 52379: Added agent flag '--oci_store_dir'.

2017-01-14 Thread Qian Zhang
> On Jan. 9, 2017, 5:03 p.m., Gilbert Song wrote: > > src/slave/flags.cpp, line 174 > > > > > > Why not consistent with docker/appc store? This was a suggestion of Avinash when he reviewed the design doc, the

Re: Review Request 55488: Slimmed down the size of the docker image from 2GB to roughly 650MB.

2017-01-14 Thread Benjamin Bannier
> On Jan. 13, 2017, 12:53 p.m., Benjamin Bannier wrote: > > support/mesos-tidy/Dockerfile, lines 69-77 > > > > > > These packages are from the Mesos getting started guide, and I am not > > sure we would like to

Re: Review Request 55509: Validate the StatusUpdate UUID in Master::statusUpdate.

2017-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55509/#review161642 --- Bad patch! Reviews applied: [55509] Failed command: ['bash',