Re: Review Request 54836: Added helpers to allocate / unallocate Resources.

2017-01-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54836/#review162937 --- src/tests/resources_tests.cpp (line 2759)

Re: Review Request 55827: Added the ability to devolve v1 Resources.

2017-01-25 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55827/#review162935 --- Ship it! Ship It! - Michael Park On Jan. 22, 2017, 6:05 p.m.

Re: Review Request 55825: Augmented printing of Resources to include AllocationInfo.

2017-01-25 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55825/#review162933 --- Fix it, then Ship it! src/common/resources.cpp (line 1942)

Re: Review Request 55826: Added a missing include to evolve.hpp.

2017-01-25 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55826/#review162934 --- Ship it! Ship It! - Michael Park On Jan. 22, 2017, 6:05 p.m.

Re: Review Request 54836: Added helpers to allocate / unallocate Resources.

2017-01-25 Thread Guangya Liu
> On 一月 25, 2017, 9:54 a.m., Michael Park wrote: > > include/mesos/resources.hpp, lines 332-339 > > > > > > I would've expected: > > ```cpp > > void allocate(const std::string& role); > > void unallocate(

Re: Review Request 54836: Added helpers to allocate / unallocate Resources.

2017-01-25 Thread Guangya Liu
> On 十二月 18, 2016, 1:10 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 1062 > > > > > > Shall we add a `CHECK` here to make sure this resource was not > > allocated to any role? > > Benjamin Mahler wr

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

2017-01-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55893/#review162929 --- @Yan, I posted some comments at https://reviews.apache.org/r/51027

Re: Review Request 54836: Added helpers to allocate / unallocate Resources.

2017-01-25 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54836/#review162927 --- Fix it, then Ship it! include/mesos/resources.hpp (lines 332 -

Re: Review Request 55889: Fixes to comments in review 54216.

2017-01-25 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55889/#review162928 --- Patch looks great! Reviews applied: [55889] Passed command: expo

<    1   2