Re: Review Request 57059: Updated default executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57059/#review166802 --- Patch looks great! Reviews applied: [57058, 57059] Passed

Re: Review Request 57059: Updated default executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57059/#review166800 --- LGTM, holding off the ship it due to a minor comment/query around

Re: Review Request 56753: Implemented the JWT authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/#review166801 --- 3rdparty/libprocess/src/jwt_authenticator.cpp (lines 81 - 102)

Re: Review Request 57058: Updated default executor tests to exclusively use v1 protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57058/#review166799 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp

Review Request 57059: Updated default executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57059/ --- Review request for mesos, Anand Mazumdar and Gilbert Song. Repository: mesos

Review Request 57058: Updated default executor tests to exclusively use v1 protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57058/ --- Review request for mesos, Anand Mazumdar and Gilbert Song. Repository: mesos

Re: Review Request 56362: Windows: Create the Windows container launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56362/#review166640 --- This is definitely the direction we want to head towards (Job

Review Request 57052: CMake: Add `config.hpp.in` for `BUILD_TIME` variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57052/ --- Review request for mesos, Alex Clemmer, Joseph Wu, and Michael Park. Bugs:

Re: Review Request 56813: Updated master handlers to use 'AuthenticationContext'.

> On Feb. 24, 2017, 2:31 a.m., Vinod Kone wrote: > > src/master/http.cpp, line 842 > > > > > > is it possible that this is none? See comment in previous patch for agent handlers; new authenticator modules may

Re: Review Request 56813: Updated master handlers to use 'AuthenticationContext'.

> On Feb. 24, 2017, 2:31 a.m., Vinod Kone wrote: > > The description talks about the agent instead of master. Copy paste error? Thanks; fixed. - Greg --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 57054: Fixed a bug in master and agent handler authorization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57054/#review166780 --- Ship it! Ship It! - Vinod Kone On Feb. 24, 2017, 11:06

Re: Review Request 56812: Updated agent handlers to use 'AuthenticationContext'.

> On Feb. 24, 2017, 2:07 a.m., Vinod Kone wrote: > > src/slave/http.cpp, line 831 > > > > > > so previously we were sending an empty subject (`Subject()`) but now we > > are sending `Option::None()` to

Re: Review Request 56813: Updated master handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56813/ --- (Updated Feb. 24, 2017, 11:07 p.m.) Review request for mesos, Adam B,

Re: Review Request 56812: Updated agent handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56812/ --- (Updated Feb. 24, 2017, 11:06 p.m.) Review request for mesos, Adam B,

Re: Review Request 56619: Updated 'Files' handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56619/ --- (Updated Feb. 24, 2017, 11:06 p.m.) Review request for mesos, Adam B,

Review Request 57054: Fixed a bug in master and agent handler authorization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57054/ --- Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, and Vinod Kone.

Re: Review Request 57031: Added allocation role validation for Reserve operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57031/#review166765 --- Fix it, then Ship it! src/master/validation.cpp (lines 1654 -

Re: Review Request 57032: Added allocation role validation for Create operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57032/#review166766 --- Fix it, then Ship it! src/master/validation.cpp (lines 1797 -

Re: Review Request 56939: Added allocation role validation for ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56939/#review166749 --- Fix it, then Ship it! src/master/validation.cpp (lines 587 -

Re: Review Request 57030: Added allocation role validation for TaskInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57030/#review166764 --- Fix it, then Ship it! src/tests/master_validation_tests.cpp

Re: Review Request 56813: Updated master handlers to use 'AuthenticationContext'.

> On Feb. 24, 2017, 2:31 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 3446 > > > > > > This sounds like we should call it AuthenticatedEntity or > > authentication::Entity instead :) Also, I'm wondering

Re: Review Request 56812: Updated agent handlers to use 'AuthenticationContext'.

> On Feb. 24, 2017, 2:07 a.m., Vinod Kone wrote: > > src/slave/http.cpp, line 831 > > > > > > so previously we were sending an empty subject (`Subject()`) but now we > > are sending `Option::None()` to

Re: Review Request 56812: Updated agent handlers to use 'AuthenticationContext'.

> On Feb. 24, 2017, 2:07 a.m., Vinod Kone wrote: > > src/slave/http.cpp, line 831 > > > > > > so previously we were sending an empty subject (`Subject()`) but now we > > are sending `Option::None()` to

Re: Review Request 56813: Updated master handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56813/ --- (Updated Feb. 24, 2017, 5:59 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56901: Updated master validation code to use 'AuthenticationContext'.

> On Feb. 24, 2017, 1:53 a.m., Vinod Kone wrote: > > src/master/validation.cpp, line 339 > > > > > > Should this be a CHECK? When is this possible? We'll soon be adding an authentication module (the JWT

Re: Review Request 56901: Updated master validation code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56901/#review166737 --- src/master/validation.cpp (line 339)

Re: Review Request 57032: Added allocation role validation for Create operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57032/#review166689 --- Patch looks great! Reviews applied: [56938, 56939, 57030, 57031,

Re: Review Request 57032: Added allocation role validation for Create operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57032/ --- (Updated Feb. 24, 2017, 7:05 p.m.) Review request for mesos and Benjamin

Review Request 57031: Added allocation role validation for Reserve operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57031/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6636

Review Request 57032: Added allocation role validation for Create operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57032/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6636

Review Request 57030: Added allocation role validation for TaskInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57030/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6636

Re: Review Request 56939: Added allocation role validation for ExecutorInfo.

> On Feb. 24, 2017, 6:51 p.m., Jay Guo wrote: > > src/master/validation.cpp, lines 590-609 > > > > > > Could we leverage `Resources::allocations()` to help with mix > > detection? e.g. > > ``` > > If

Re: Review Request 56939: Added allocation role validation for ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56939/#review166680 --- src/master/validation.cpp (lines 590 - 609)

Re: Review Request 56939: Added allocation role validation for ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56939/ --- (Updated Feb. 24, 2017, 6:48 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 57023: Added a test to ensure agent could be upgrade to MULTI_ROLE capable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57023/#review166670 --- Patch looks great! Reviews applied: [56967, 56837, 56530, 57021,

Review Request 57023: Added a test to ensure agent could be upgrade to MULTI_ROLE capable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57023/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and

Review Request 57021: Added agent capabilities to `updateSlave` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57021/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and

Re: Review Request 56530: Prevent resource of old agents being allocated to MULTI_ROLE frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56530/ --- (Updated Feb. 24, 2017, 4:44 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 56837: Added agent capabilities to HierarchicalAllocatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56837/ --- (Updated Feb. 24, 2017, 4:43 p.m.) Review request for mesos, Benjamin Bannier,