Re: Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57106/#review167655 --- Ship it! Ship It! - Jay Guo On Feb. 28, 2017, 6:11 a.m.,

Re: Review Request 57193: Updated WebUI to display role information under tab 'Agents'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57193/ --- (Updated March 2, 2017, 11:34 a.m.) Review request for mesos and Benjamin

Re: Review Request 57192: Updated WebUI to display role information under tab 'Frameworks'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57192/ --- (Updated March 2, 2017, 11:34 a.m.) Review request for mesos and Benjamin

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review167640 --- Patch looks great! Reviews applied: [53369] Passed command:

Re: Review Request 57195: Updated WebUI to display role information of tasks in homepage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57195/#review167637 --- Ship it! Ship It! - Benjamin Mahler On March 1, 2017, 10:24

Re: Review Request 57166: Updated role validation for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57166/#review167623 --- src/common/roles.cpp Line 71 (original), 71 (patched)

Re: Review Request 55790: Support the full CNI DNS specification.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55790/#review167620 --- Patch looks great! Reviews applied: [55790] Passed command:

Re: Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`.

> On Feb. 27, 2017, 6:42 p.m., Benjamin Mahler wrote: > > src/messages/messages.proto > > Lines 574-575 (patched) > > > > > > Just one thing, looking at the subsequent patch, it appears that the > > agent updates

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review167592 --- Patch looks great! Reviews applied: [55887, 55888] Passed

Re: Review Request 57052: CMake: Add `build_config.hpp.in` for `BUILD_TIME` variables.

> On March 1, 2017, 2:13 a.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Line 291 (original), 291 (patched) > > > > > > Not yours, but looks like this one actually doesn't work on Posix. > > > >

Re: Review Request 57052: CMake: Add `build_config.hpp.in` for `BUILD_TIME` variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57052/ --- (Updated March 1, 2017, 10:18 p.m.) Review request for mesos, Alex Clemmer,

Re: Review Request 57194: Updated WebUI to display role information under tab 'Offers'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57194/#review167583 --- Fix it, then Ship it! src/webui/master/static/offers.html

Re: Review Request 57013: Expose offer allocation info within the master /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57013/#review167578 --- Ship it! Ship It! - Michael Park On Feb. 23, 2017, 5:27

Re: Review Request 57191: Fixed flakiness in three MULTI_ROLE related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57191/#review167576 --- Ship it! Ship It! - Benjamin Mahler On March 1, 2017, 5:22

Re: Review Request 57052: CMake: Add `build_config.hpp.in` for `BUILD_TIME` variables.

> On March 1, 2017, 2:13 a.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Line 291 (original), 291 (patched) > > > > > > Not yours, but looks like this one actually doesn't work on Posix. > > > >

Re: Review Request 57108: Handled the `FrameworkInfo` field added to the `UpdateFrameworkMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57108/ --- (Updated March 1, 2017, 12:51 p.m.) Review request for mesos and Benjamin

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

> On Dec. 6, 2016, 10:42 p.m., Benjamin Mahler wrote: > > Thanks Ilya! > > > > Have you looked at other pidfile related libraries? Looks like BSD provides > > some functions for this (they're also available on Linux): > > https://www.freebsd.org/cgi/man.cgi?query=pidfile=3=FreeBSD+6.1-RELEASE

Re: Review Request 57190: Updated agent for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57190/#review167564 --- Bad review! Reviews applied: [57190, 57166, 56805, 57165, 57164]

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/#review167557 --- src/checks/checker.cpp Line 297 (original), 309 (patched)

Re: Review Request 56017: Added a helper for building a task status from an existing one.

> On March 1, 2017, 7:46 p.m., Vinod Kone wrote: > > src/common/protobuf_utils.hpp > > Lines 96-98 (original), 98-100 (patched) > > > > > > The last sentence seems un-necssary because the it's clear from the > >

Re: Review Request 56017: Added a helper for building a task status from an existing one.

> On March 1, 2017, 7:46 p.m., Vinod Kone wrote: > > src/common/protobuf_utils.hpp > > Lines 96-98 (original), 98-100 (patched) > > > > > > The last sentence seems un-necssary because the it's clear from the > >

Re: Review Request 56017: Added a helper for building a task status from an existing one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/#review167556 --- Fix it, then Ship it! src/common/protobuf_utils.hpp Lines

Re: Review Request 56016: Added a note about task status updates in scheduler and internal API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56016/#review167555 --- Ship it! Ship It! - Vinod Kone On Feb. 28, 2017, 3:46 p.m.,

Re: Review Request 57195: Updated WebUI to display role information of tasks in homepage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57195/#review167553 --- Patch looks great! Reviews applied: [57013, 57132, 57192, 57193,

Re: Review Request 57132: Fixed WebUI data-key.

> On March 1, 2017, 6:55 p.m., Benjamin Mahler wrote: > > There are probably other `data-key`s that are broken too, I didn't do a > > sweep when I had suggested fixing these :) By the way, you can test if the data-key is correct by clicking the table headers and seeing if it sorts in

Re: Review Request 57132: Fixed WebUI data-key.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57132/#review167541 --- Ship it! There are probably other `data-key`s that are broken

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/ --- (Updated March 1, 2017, 6:50 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 50463: Added code to build libmesosjava shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/#review167519 --- Closing this review due to inactivity. Please see our

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54693/#review167535 --- Closing this review due to inactivity. Please see our

Re: Review Request 50523: Updated docker recovery to account for GPU resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50523/#review167532 --- Closing this review due to inactivity. Please see our

Re: Review Request 54769: Fixed a cleanup related bug in the IO switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54769/#review167526 --- Closing this review due to inactivity. Please see our

Re: Review Request 52071: Updated docs to handle resources with no size in agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52071/#review167533 --- Closing this review due to inactivity. Please see our

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT or PATH disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51880/#review167531 --- Closing this review due to inactivity. Please see our

Re: Review Request 50415: Added build step to build Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50415/#review167521 --- Closing this review due to inactivity. Please see our

Re: Review Request 52002: Added helper methods to determine types of disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review167527 --- Closing this review due to inactivity. Please see our

Re: Review Request 53713: Reversed recoursive path creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53713/#review167529 --- Closing this review due to inactivity. Please see our

Re: Review Request 54655: Renamed LocalNestedContainerObjectApprover for a more generic name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54655/#review167523 --- Closing this review due to inactivity. Please see our

Re: Review Request 50459: Added code to generate JNI Header files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50459/#review167517 --- Closing this review due to inactivity. Please see our

Re: Review Request 54636: Added LOCAL_IP to disk_full_framework_test.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54636/#review167520 --- Closing this review due to inactivity. Please see our

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review167537 --- Closing this review due to inactivity. Please see our

Re: Review Request 46425: Add helper function to simplify tokenize handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46425/#review167525 --- Closing this review due to inactivity. Please see our

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/#review167528 --- Closing this review due to inactivity. Please see our

Re: Review Request 53707: Added a Windows isolator. Removed `#ifdef`-ed block from Posix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53707/#review167530 --- Closing this review due to inactivity. Please see our

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/#review167522 --- Closing this review due to inactivity. Please see our

Re: Review Request 54085: Made internal Mesos headers more standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54085/#review167524 --- Closing this review due to inactivity. Please see our

Re: Review Request 50460: Added code to build libstate shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50460/#review167518 --- Closing this review due to inactivity. Please see our

Re: Review Request 54986: Added metric for slave message queue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54986/#review167536 --- Closing this review due to inactivity. Please see our

Re: Review Request 54828: Fixed flags::fetch() to support Windows file paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54828/#review167534 --- Closing this review due to inactivity. Please see our

Re: Review Request 50458: Added code to build mesos-java.jar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50458/#review167516 --- Closing this review due to inactivity. Please see our

Re: Review Request 50457: Added code to generate MesosNativeLibrary.java.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50457/#review167515 --- Closing this review due to inactivity. Please see our

Re: Review Request 57177: Clarified naming rules in C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57177/#review167510 --- Ship it! Ship It! - Vinod Kone On March 1, 2017, 6:34 p.m.,

Re: Review Request 50455: Enabled Java builds if Java is found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50455/#review167507 --- Closing this review due to inactivity. Please see our

Re: Review Request 50456: Added custom command to generate Java protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50456/#review167509 --- Closing this review due to inactivity. Please see our

Re: Review Request 53608: Added --enable-seccomp flag to configure options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53608/#review167481 --- Closing this review due to inactivity. Please see our

Re: Review Request 53605: Added --seccomp_profile flag to Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53605/#review167492 --- Closing this review due to inactivity. Please see our

Re: Review Request 53912: Fix xattr for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53912/#review167500 --- Closing this review due to inactivity. Please see our

Re: Review Request 53604: Added SeccompInfo protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53604/#review167491 --- Closing this review due to inactivity. Please see our

Re: Review Request 53607: Added Seccomp imeplementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53607/#review167480 --- Closing this review due to inactivity. Please see our

Re: Review Request 54104: Adjusted code style in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54104/#review167484 --- Closing this review due to inactivity. Please see our

Re: Review Request 53121: Added a child hook for entering the target pid's namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53121/#review167488 --- Closing this review due to inactivity. Please see our

Re: Review Request 53122: Used child hooks to enter namespaces in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53122/#review167489 --- Closing this review due to inactivity. Please see our

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46230/#review167478 --- Closing this review due to inactivity. Please see our

Re: Review Request 54587: Introduced a ScaleTestContainerizer suitable for scale testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54587/#review167506 --- Closing this review due to inactivity. Please see our

Re: Review Request 53926: Move isJailed for FreeBSD into utils.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53926/#review167503 --- Closing this review due to inactivity. Please see our

Re: Review Request 53925: Fix wait macros on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53925/#review167502 --- Closing this review due to inactivity. Please see our

Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/#review167497 --- Closing this review due to inactivity. Please see our

Re: Review Request 46228: Create persistent volume with a supplied user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46228/#review167496 --- Closing this review due to inactivity. Please see our

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/#review167475 --- Closing this review due to inactivity. Please see our

Re: Review Request 53146: Added a child hook for switching the user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53146/#review167485 --- Closing this review due to inactivity. Please see our

Re: Review Request 50414: Added variables for building Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50414/#review167508 --- Closing this review due to inactivity. Please see our

Re: Review Request 53606: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53606/#review167493 --- Closing this review due to inactivity. Please see our

Re: Review Request 53882: Fix configure on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53882/#review167499 --- Closing this review due to inactivity. Please see our

Re: Review Request 46229: Add unit tests for adding a user for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46229/#review167495 --- Closing this review due to inactivity. Please see our

Re: Review Request 53931: Don't expect an init process in a FreeBSD jail.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53931/#review167505 --- Closing this review due to inactivity. Please see our

Re: Review Request 53913: Disable sentinel checks for clang on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53913/#review167501 --- Closing this review due to inactivity. Please see our

Re: Review Request 53927: Check isJailed in tests that call mknod.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53927/#review167504 --- Closing this review due to inactivity. Please see our

Re: Review Request 53695: Allows caching extractable files when outputFile is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53695/#review167494 --- Closing this review due to inactivity. Please see our

Re: Review Request 54084: Made public Mesos header standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54084/#review167482 --- Closing this review due to inactivity. Please see our

Re: Review Request 53119: Moved `ns.hpp` to stout [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53119/#review167483 --- Closing this review due to inactivity. Please see our

Re: Review Request 50010: Added example framework for handling inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50010/#review167479 --- Closing this review due to inactivity. Please see our

Re: Review Request 53147: Made health check run under the same user with tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53147/#review167486 --- Closing this review due to inactivity. Please see our

Re: Review Request 53120: Moved `ns.hpp` to stout [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53120/#review167487 --- Closing this review due to inactivity. Please see our

Re: Review Request 53123: Made `process::defaultClone` private.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53123/#review167490 --- Closing this review due to inactivity. Please see our

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review167472 --- Closing this review due to inactivity. Please see our

Re: Review Request 46227: Added an user to indicate owner of persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46227/#review167476 --- Closing this review due to inactivity. Please see our

Re: Review Request 52980: Updated os::mkdir() to take the mode as an input.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52980/#review167477 --- Closing this review due to inactivity. Please see our

Re: Review Request 50125: Added `--devices` flag to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review167473 --- Closing this review due to inactivity. Please see our

Re: Review Request 50496: Added pid group module to `createPIDGroup` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50496/#review167460 --- Closing this review due to inactivity. Please see our

Re: Review Request 53702: Added a factory method to produce PIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53702/#review167462 --- Closing this review due to inactivity. Please see our

Re: Review Request 50498: Added --master_pid_group flag in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50498/#review167463 --- Closing this review due to inactivity. Please see our

Re: Review Request 50128: Overloaded the << operator for `Docker::Device`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review167469 --- Closing this review due to inactivity. Please see our

Re: Review Request 53532: Added `parse` helper function for `Docker::Device`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53532/#review167471 --- Closing this review due to inactivity. Please see our

Re: Review Request 50838: Updated modules documentation to reflect PIDGroup module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50838/#review167467 --- Closing this review due to inactivity. Please see our

Re: Review Request 50947: Only check `gpu/nvidia` isolator for mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/#review167470 --- Closing this review due to inactivity. Please see our

Re: Review Request 53533: Extended `dockerFlags()` to pass `devices` to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53533/#review167474 --- Closing this review due to inactivity. Please see our

Re: Review Request 53701: Renamed `group` in ZooKeeperPIDGroup to `observer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53701/#review167465 --- Closing this review due to inactivity. Please see our

Re: Review Request 52735: Updated comments for killing some garbage containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/#review167468 --- Closing this review due to inactivity. Please see our

Re: Review Request 50493: Added `base` to PIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50493/#review167466 --- Closing this review due to inactivity. Please see our

Re: Review Request 50497: Added new constructors in Log and LogProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50497/#review167461 --- Closing this review due to inactivity. Please see our

Re: Review Request 50499: Added logic in master/main.cpp to use pid_group module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50499/#review167464 --- Closing this review due to inactivity. Please see our

  1   2   3   >