Re: Review Request 60013: Resources: Updated the validation logic.

2017-06-16 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60013/#review178145 --- Fix it, then Ship it! src/common/resources.cpp Lines 511-512

Re: Review Request 60145: Update Linux capabilities isolator tests.

2017-06-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60145/#review178143 --- Ship it! Ship It! - Jie Yu On June 16, 2017, 4:50 a.m.,

Re: Review Request 60101: Prevent the fetcher from setting overly-permissive fs permissions.

2017-06-16 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60101/#review178134 --- Chatted with Silas offline. So the problem we are trying to

Re: Review Request 59739: Replaced use of `net::IPNetwork` by `net::IP::Network`.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59739/ --- (Updated June 16, 2017, 11:30 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/#review178133 --- Fix it, then Ship it! include/mesos/mesos.proto Lines 349

Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- (Updated June 16, 2017, 3:51 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- (Updated June 16, 2017, 3:29 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 59861: Added protobuf changes for reservation refinement.

2017-06-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- (Updated June 16, 2017, 2:43 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 59739: Replaced use of `net::IPNetwork` by `net::IP::Network`.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59739/ --- (Updated June 16, 2017, 8:51 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 60062: Prevented reserve/create with hierarchical roles on a non-capable agent.

2017-06-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60062/#review178122 --- Ship it! Ship It! - Neil Conway On June 16, 2017, 7:48

Re: Review Request 60062: Prevented reserve/create with hierarchical roles on a non-capable agent.

2017-06-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60062/ --- (Updated June 16, 2017, 12:48 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 60139: Avoided needless copy of `Owned` in libprocess.

2017-06-16 Thread Benjamin Bannier
> On June 16, 2017, 1:25 p.m., Benjamin Bannier wrote: > > I do not agree with this change. > > > > An `Owned` cannot be copied semantically. If we pass an `Owned` at all, it > > should be by value, not by reference, so potential copies happen on > > interface boundaries and we do not need to

Re: Review Request 60139: Avoided needless copy of `Owned` in libprocess.

2017-06-16 Thread Neil Conway
> On June 16, 2017, 11:25 a.m., Benjamin Bannier wrote: > > I do not agree with this change. > > > > An `Owned` cannot be copied semantically. If we pass an `Owned` at all, it > > should be by value, not by reference, so potential copies happen on > > interface boundaries and we do not need

Review Request 60162: Fixed bug in GroupTest.ConnectTimer, GroupTest.TimerCleanup.

2017-06-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60162/ --- Review request for mesos and Andrei Budnik. Repository: mesos Description

Review Request 60161: Cleaned up zookeeper binding code slightly.

2017-06-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60161/ --- Review request for mesos and Andrei Budnik. Repository: mesos Description

Re: Review Request 60008: Fixed bug causing FUTURE_DISPATCH to react on irrelevant dispatch (WIP).

2017-06-16 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60008/ --- (Updated June 16, 2017, 5:34 p.m.) Review request for mesos, Alexander

Re: Review Request 60067: Updated of documents including authorization in operator endpoints.

2017-06-16 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60067/#review178116 --- Ship it! Ship It! - Till Toenshoff On June 14, 2017, 9:48

Re: Review Request 59688: Moved `net::IPNetwork` to `net::IP:Network`.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59688/ --- (Updated June 16, 2017, 4:50 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 59127: Added IPv6 flags for Mesos agent.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59127/ --- (Updated June 16, 2017, 4:48 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 59128: Added initialization logic in Mesos agent for IPv6 flags.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59128/ --- (Updated June 16, 2017, 4:48 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 59739: Replaced use of `net::IPNetwork` by `net::IP::Network`.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59739/ --- (Updated June 16, 2017, 4:47 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 59129: Introduced `inet6::Address` to handle IPv6 addresses in `libprocess`.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59129/ --- (Updated June 16, 2017, 4:47 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 59721: Refactored net::IP and added net::IPv4 and net::IPv6.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59721/ --- (Updated June 16, 2017, 4:46 p.m.) Review request for mesos, Benjamin Hindman

Review Request 60136: Refactored inet::Address to base of inet4::Address and inet6::Address.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60136/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-7488

Review Request 60148: Mesos updates for new inet4::Address.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60148/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-7488

Re: Review Request 60149: Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60149/ --- (Updated June 16, 2017, 4:41 p.m.) Review request for mesos, Benjamin Hindman

Review Request 60149: Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60149/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos

Re: Review Request 59131: Added an IPv6 address storage to UPID.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59131/ --- (Updated June 16, 2017, 4:38 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59130/ --- (Updated June 16, 2017, 4:36 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 59233: Updated v6 address for containers running on host network.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59233/ --- (Updated June 16, 2017, 4:36 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 59233: Updated v6 address for containers running on host network.

2017-06-16 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59233/ --- (Updated June 16, 2017, 3:54 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 60139: Avoided needless copy of `Owned` in libprocess.

2017-06-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60139/#review178098 --- I do not agree with this change. An `Owned` cannot be copied

Re: Review Request 60088: CLI: Added 'agent' key as an acceptable key in config.toml.

2017-06-16 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60088/#review178092 --- LGTM - Andrei Budnik On June 14, 2017, 3:17 p.m., Armand

Re: Review Request 60139: Avoided needless copy of `Owned` in libprocess.

2017-06-16 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60139/#review178084 --- Ship it! Ship It! - Alexander Rojas On June 16, 2017, 1:16