Re: Review Request 61182: Sent a resource provider message when providers subscribe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61182/#review183197 --- Can you rebase? - Jie Yu On Aug. 1, 2017, 5:42 p.m., Benjamin

Re: Review Request 61704: Added CSI client classes to talk to CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61704/#review183196 --- include/mesos/csi/csi.hpp Lines 60 (patched)

Re: Review Request 61705: Added a mock CSI plugin and a unit test for CSI client classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61705/#review183195 --- Fix it, then Ship it! src/tests/csi_client_tests.cpp Lines 50

Re: Review Request 60592: Configure the `network/ports` isolator watch interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60592/#review183194 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 18, 2017, 2:39 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 66-67 (patched) > > > > > > Usually when we define a `xxxProcess` class, we want it to do some

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review183190 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 61725: Added secrets docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/#review183192 --- Patch looks great! Reviews applied: [61725] Passed command:

Review Request 61725: Added secrets docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61725/ --- Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff. Bugs:

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review183191 --- Patch looks great! Reviews applied: [61189] Passed command:

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 17, 2017, 10:45 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 156-157 (patched) > > > > > > Do we really need this? I think showing pid like what you did

Re: Review Request 61313: Bumped minimum required CMake version to 3.7.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61313/#review183188 --- Patch looks great! Reviews applied: [61313] Passed command:

Re: Review Request 61704: Added CSI client classes to talk to CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61704/#review183186 --- include/mesos/csi/csi.hpp Lines 1 (patched)

Re: Review Request 61703: Bundled CSI v0.1.0 into 3rdparty libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61703/#review183185 --- Ship it! Ship It! - Jie Yu On Aug. 16, 2017, 11:06 p.m.,

Re: Review Request 61271: Implemented HTTP connection handling for the resource provider driver.

> On Aug. 17, 2017, 4:11 a.m., Jie Yu wrote: > > src/resource_provider/http_connection.hpp > > Lines 321 (patched) > > > > > > This should be `UNREACHABLE` as well? > > Jan Schlicht wrote: > No, the instance

Re: Review Request 61320: Added `elfio` interface library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61320/#review183183 --- Ship it! Might squash this into

Re: Review Request 61318: Added `concurrentqueue` interface library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61318/#review183182 --- Ship it! Might squash this into

Re: Review Request 61271: Implemented HTTP connection handling for the resource provider driver.

> On Aug. 17, 2017, 4:11 a.m., Jie Yu wrote: > > src/resource_provider/http_connection.hpp > > Lines 214 (patched) > > > > > > Why we need `latest` here? Should use just use `endpoint` instead? > > Jan Schlicht

Re: Review Request 61408: Added test cases for V1 teardown Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61408/#review183180 --- Patch looks great! Reviews applied: [61222, 61408] Passed

Re: Review Request 61723: Bumped version to 1.5.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61723/#review183179 --- Ship it! Ship It! - Adam B On Aug. 17, 2017, 4:41 p.m.,

Review Request 61723: Bumped version to 1.5.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61723/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Re: Review Request 61408: Added test cases for V1 teardown Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61408/#review183178 --- Patch looks great! Reviews applied: [61222, 61408] Logs

Re: Review Request 61558: Move duplicate comment closer to implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61558/#review183177 --- Bad patch! Reviews applied: [61495, 61558] Logs available here:

Re: Review Request 61314: Added `boost` interface library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61314/#review183174 --- Ship it! LGTM. - Joseph Wu On Aug. 1, 2017, 5:57 p.m.,

Re: Review Request 61558: Move duplicate comment closer to implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61558/#review183176 --- Patch looks great! Reviews applied: [61495, 61558] Passed

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/ --- (Updated Aug. 17, 2017, 10:59 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 61312: Switched Linux build of `protobuf` to use CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61312/ --- (Updated Aug. 17, 2017, 3:37 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 61312: Switched Linux build of `protobuf` to use CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61312/#review183170 --- I'm going to squash this review into

Re: Review Request 61313: Bumped minimum required CMake version to 3.7.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61313/#review183169 --- Ship it! I'll take care of updating some other dependencies

Re: Review Request 61495: Add documentation for possible task reasons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61495/#review183161 --- docs/task-state-reasons.md Lines 55-58 (patched)

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review183166 --- Patch looks great! Reviews applied: [61262] Passed command:

Re: Review Request 59029: Added a script to publish JARs to maven snapshot repository.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59029/#review183160 --- Patch looks great! Reviews applied: [59029] Passed command:

Re: Review Request 61408: Added test cases for V1 teardown Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61408/ --- (Updated Aug. 17, 2017, 9:33 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 61558: Move duplicate comment closer to implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61558/#review183157 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 10, 2017,

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/ --- (Updated Aug. 17, 2017, 9:20 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 59029: Added a script to publish JARs to maven snapshot repository.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59029/#review183154 --- Ship it! Ship It! - Kapil Arya On May 5, 2017, 4:03 p.m.,

Re: Review Request 59029: Added a script to publish JARs to maven snapshot repository.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59029/#review183153 --- support/snapshot.sh Lines 60 (patched)

Re: Review Request 61309: Imported ZooKeeper library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61309/#review183151 --- Ship it! Hmm... I will not squash this one into the other

Re: Review Request 61308: Updated the ZooKeeper patch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61308/#review183150 --- Ship it! - Joseph Wu On Aug. 1, 2017, 6:04 p.m., Andrew

Re: Review Request 61303: Imported `curl` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61303/#review183149 --- Ship it! Another potential squash for

Re: Review Request 61302: Added CMake function `make_include()` to work around bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61302/#review183148 --- Ship it! LGTM. I'm going to expand on the commit description

Re: Review Request 61300: Imported `protoc` executable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61300/#review183100 --- Ship it! May possibly squash into

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

> On Aug. 15, 2017, 6:44 p.m., Greg Mann wrote: > > src/master/master.hpp > > Lines 309-311 (patched) > > > > > > Now that we're sending heartbeats for multiple purposes, I'm concerned > > that the logging will be

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 17, 2017, 2:45 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.hpp > > Lines 39 (patched) > > > > > > Should be a `static` variable. > > > > Or do we want to make

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- (Updated Aug. 17, 2017, 5:36 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 61536: Added network ports isolator socket utilities tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61536/ --- (Updated Aug. 17, 2017, 5:34 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review182691 --- src/slave/containerizer/mesos/isolators/network/ports.hpp Lines

Re: Review Request 61697: Included nested command checks output in the executor logs.

> On Aug. 16, 2017, 11:03 p.m., Greg Mann wrote: > > src/checks/checker_process.cpp > > Lines 143-144 (patched) > > > > > > "returns the merged stdout and stderr": is this true? Looks like you > > only use STDOUT

Re: Review Request 61697: Included nested command checks output in the executor logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61697/#review183121 --- src/checks/checker_process.cpp Lines 144-145 (patched)

Re: Review Request 61664: Libprocess: Added a timeout for send socket operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61664/#review183125 --- 3rdparty/libprocess/src/process.cpp Lines 254 (patched)

Re: Review Request 61271: Implemented HTTP connection handling for the resource provider driver.

> On Aug. 17, 2017, 6:11 a.m., Jie Yu wrote: > > src/resource_provider/http_connection.hpp > > Lines 214 (patched) > > > > > > Why we need `latest` here? Should use just use `endpoint` instead? Because `latest` is

Re: Review Request 61536: Added network ports isolator socket utilities tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61536/#review183113 --- src/tests/containerizer/ports_isolator_tests.cpp Lines 83-85