Re: Review Request 61874: Added a test for IPv6 containers on docker user networks.

> On Aug. 24, 2017, 10:21 a.m., Qian Zhang wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 4753 (patched) > > > > > > I think we should call this method in the end rather than at the >

Review Request 61908: Used path::absolute to replace some startsWith checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61908/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-7306

Review Request 61907: Moved host volume related tests to a dedicated file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61907/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-7306

Review Request 61906: Added a dependency check 'filesystem/linux' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61906/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-7306

Review Request 61905: Integrated 'volume/host_path' into MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61905/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-7306

Review Request 61904: Added volume/host_path isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61904/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-7306

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 18, 2017, 2:39 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 66-67 (patched) > > > > > > Usually when we define a `xxxProcess` class, we want it to do some

Review Request 61903: Fixed a indentation issue in linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61903/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-7306

Review Request 61902: Added master and agent validation for ContainerInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61902/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-7306

Review Request 61901: Added common validation for Volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61901/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-7306

Review Request 61900: Added equal operator for Error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61900/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-7306

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 21, 2017, 7:15 a.m., Qian Zhang wrote: > > src/slave/flags.cpp > > Lines 1012-1018 (patched) > > > > > > So by default this flag is not enabled, that means any libprocess-based > > exectuors (e.g.,

Review Request 61899: Added HOST_PATH volume source protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61899/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-7306

Re: Review Request 61799: Replaced ABORT with _EXIT in `childMain` to handle `os::execvpe` error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61799/#review183758 --- 3rdparty/libprocess/src/subprocess_posix.hpp Lines 200 (patched)

Re: Review Request 61798: Added _EXIT as alternative to ABORT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61798/#review183755 --- 3rdparty/stout/include/stout/exit.hpp Lines 39 (patched)

Re: Review Request 60621: Add new stout capability: os::copyfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/ --- (Updated Aug. 24, 2017, 10:39 p.m.) Review request for mesos, Andrew

Re: Review Request 61866: Adds port mapping information in NetworkInfo as part of `state` output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61866/#review183804 --- Ship it! Ship It! - Michael Park On Aug. 23, 2017, 3:05

Re: Review Request 61797: Added async-signal safe implementation of `write` function in stout.

> On Aug. 24, 2017, 6:28 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 66 (patched) > > > > > > Write returns `ssize_t` here and in all the other variants in this file. > > > >

Re: Review Request 61880: Fixed agent downgrades for reservation refinement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61880/#review183803 --- Ship it! src/slave/slave.cpp Lines 3457-3458 (patched)

Re: Review Request 61893: Fix garbage collection metrics test failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61893/ --- (Updated Aug. 24, 2017, 9:47 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 61893: Fix garbage collection metrics test failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61893/#review183801 --- Fix it, then Ship it! src/tests/gc_tests.cpp Line 1007

Re: Review Request 61892: Propagate the error from os::rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61892/#review183800 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 24, 2017, 12:34

Re: Review Request 60621: Add new stout capability: os::copyfile.

> On Aug. 16, 2017, 12:20 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/posix/copyfile.hpp > > Lines 26 (patched) > > > > > > Oops, can't include a namespace in a header. I removed this and resolved

Re: Review Request 61675: Updated doc for the changes of pid namespace sharing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61675/#review183786 --- docs/mesos-containerizer.md Lines 67 (patched)

Review Request 61893: Fix garbage collection metrics test failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61893/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Repository: mesos

Review Request 61892: Propagate the error from os::rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61892/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Repository: mesos

Re: Review Request 61797: Added async-signal safe implementation of `write` function in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61797/#review183754 --- 3rdparty/stout/include/stout/os/write.hpp Lines 66 (patched)

Re: Review Request 60620: Modify os::write to write binary files on Windows.

> On Aug. 16, 2017, 12:19 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 70 (patched) > > > > > > Should be an `#ifdef`. I took care of this since I'm re-working the commits. > On

Re: Review Request 61799: Replaced ABORT with _EXIT in `childMain` to handle `os::execvpe` error.

> On Aug. 22, 2017, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/subprocess_posix.hpp > > Line 194 (original), 195-197 (patched) > > > > > > Is this what `clang-format` suggests? > > Andrei

Re: Review Request 61874: Added a test for IPv6 containers on docker user networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61874/#review183724 --- Fix it, then Ship it!

Re: Review Request 61873: Added test filter for docker user network tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61873/#review183722 --- Fix it, then Ship it! src/tests/environment.cpp Line 296

Re: Review Request 61799: Replaced ABORT with _EXIT in `childMain` to handle `os::execvpe` error.

> On Aug. 22, 2017, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/subprocess_posix.hpp > > Line 194 (original), 195-197 (patched) > > > > > > Is this what `clang-format` suggests? > > Andrei

Re: Review Request 61797: Added async-signal safe implementation of `write` function in stout.

> On Aug. 22, 2017, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 67 (patched) > > > > > > `std::strlen`? > > Andrei Budnik wrote: > I'm not sure if `std::strlen`

Re: Review Request 61237: Updated docker executor to return IPv6 address of a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61237/#review183719 --- src/docker/docker.cpp Line 326 (original), 329 (patched)

Re: Review Request 61797: Added async-signal safe implementation of `write` function in stout.

> On Aug. 22, 2017, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 67 (patched) > > > > > > `std::strlen`? > > Andrei Budnik wrote: > I'm not sure if `std::strlen`

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 22, 2017, 5:09 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 242-246 (patched) > > > > > > Sorry for the back and forth, is it possile for

Review Request 61880: Fixed agent downgrades for reservation refinement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61880/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-7714

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 21, 2017, 3:15 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 183 (patched) > > > > > > This method is only called by

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Aug. 18, 2017, 10:39 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 66-67 (patched) > > > > > > Usually when we define a `xxxProcess` class, we want it to do

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review183709 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60766: Ignored containers that join CNI networks.

> On Aug. 23, 2017, 5:52 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Line 394 (original), 436 (patched) > > > > > > So here an empty `Info` object is put into `infos`?