Review Request 62322: Added initial doc for container volumes.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62322/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Re: Review Request 62308: Added the description for the isolators section.

2017-09-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62308/#review185345 --- FAIL: Some Mesos tests failed. Reviews applied: `['62295',

Review Request 62308: Added the description for the isolators section.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62308/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Review Request 62306: Added an index in the mesos containerizer doc about isolators.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62306/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Review Request 62307: Added gpu/nvidia isolator to the index.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62307/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Review Request 62304: Moved linux capabilities isolator doc to the isolators folder.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62304/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Review Request 62305: Moved posix rlimits isolator doc to the isolators folder.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62305/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Review Request 62302: Moved docker volume isolator doc to the isolators folder.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62302/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Review Request 62303: Moved IPC namespace isolator doc to the isolators folder.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62303/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

2017-09-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62246/#review185340 --- FAIL: The filename, directory name, or volume label syntax is

Review Request 62298: Moved disk du isolator doc to the isolators folder.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62298/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Review Request 62300: Moved docker runtime isolator doc to the isolators folder.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62300/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Review Request 62301: Moved cgroups net_cls isolator doc to the isolators folder.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62301/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Review Request 62299: Moved xfs disk isolator doc to the isolators folder.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62299/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Review Request 62296: Moved shared filesystem isolator doc to the isolators folder.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62296/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Review Request 62295: Moved port mapping isolator doc to the isolators folder.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62295/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Review Request 62297: Moved pid namespace isolator doc to the isolators folder.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62297/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos

Re: Review Request 62162: Revert usage of `-isystem` flag.

2017-09-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62162/#review185332 --- Bad patch! Reviews applied: [62162, 62161, 62160] Failed

Re: Review Request 62288: Added Log.Reader.catchup() method to Java bindings.

2017-09-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62288/#review185326 --- FAIL: Some Mesos tests failed. Reviews applied: `['62283',

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

2017-09-13 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62246/ --- (Updated Sept. 13, 2017, 6:01 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 62252: Added `process::Executor::execute()`.

2017-09-13 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62252/ --- (Updated Sept. 13, 2017, 5:34 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

2017-09-13 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review185310 --- src/docker/executor.cpp Lines 160 (patched)

Re: Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows.

2017-09-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62279/#review185306 --- FAIL: Some Mesos tests failed. Reviews applied: `['62279']`

Review Request 62288: Added Log.Reader.catchup() method to Java bindings.

2017-09-13 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62288/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7973

Review Request 62284: Fixed code style issues.

2017-09-13 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62284/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7973

Review Request 62287: Added Log::Reader::catchup() method.

2017-09-13 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62287/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7973

Review Request 62283: Fixed a comment typo.

2017-09-13 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62283/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7973

Review Request 62285: Added tombstone flag to NOP log action.

2017-09-13 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62285/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7973

Review Request 62286: Added recoverMissing log process.

2017-09-13 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62286/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7973

Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method.

2017-09-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62197/#review185304 --- src/tests/mesos.hpp Line 590 (original), 590 (patched)

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

2017-09-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/#review185303 --- FAIL: Mesos tests failed to build. Reviews applied: `['62212',

Re: Review Request 62282: Fixed 'operator==' for 'Resource::DiskInfo::Source'.

2017-09-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62282/#review185302 --- Ship it! Ship It! - Jie Yu On Sept. 13, 2017, 3:23 p.m.,

Re: Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows.

2017-09-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62279/#review185301 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 13, 2017,

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

2017-09-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/ --- (Updated Sept. 13, 2017, 5:23 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 62282: Fixed 'operator==' for 'Resource::DiskInfo::Source'.

2017-09-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62282/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 62252: Added `process::Executor::execute()`.

2017-09-13 Thread Chun-Hung Hsiao
> On Sept. 13, 2017, 5:10 a.m., Benjamin Hindman wrote: > > Thanks for taking this on Chun! A few high level comments to start. > > > > (1) I don't think we need to implement a version of `execute()` that takes > > arguments that we'll apply to the function. With lambda captures we can > >

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

2017-09-13 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/ --- (Updated Sept. 13, 2017, 2:52 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows.

2017-09-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62279/#review185293 --- FAIL: Some Mesos tests failed. Reviews applied: `['62279']`

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

2017-09-13 Thread Andrei Budnik
> On Sept. 12, 2017, 11:03 a.m., Andrei Budnik wrote: > > src/docker/executor.cpp > > Lines 141 (patched) > > > > > > Do we really need to send `TASK_STARTING`, if we know that right after > > sending

Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows.

2017-09-13 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62279/ --- Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Gilbert Song,

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-09-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review185268 --- FAIL: Failed to apply the current review. Failed command: