Re: Review Request 62609: Protect against Future callbacks deleting instance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62609/#review186373 --- PASS: Mesos patch 62609 was successfully built and tested.

Re: Review Request 62609: Protect against Future callbacks deleting instance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62609/#review186369 --- Ship it! Ship It! - Benjamin Mahler On Sept. 27, 2017, 3:16

Review Request 62609: Protect against Future callbacks deleting instance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62609/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8010

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62595/#review186359 --- PASS: Mesos patch 62595 was successfully built and tested.

Re: Review Request 62230: Avoid GC pruning events from blocking other processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62230/#review186341 --- Ship it! Ship It! - Jiang Yan Xu On Sept. 26, 2017, 3:04

Review Request 62592: Added basic HTTP authenticatee implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62592/ --- Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and

Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62595/ --- Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier,

Review Request 62587: Added HTTP authenticatee interface definition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62587/ --- Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and

Review Request 62591: Modularized HTTP authenticatee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62591/ --- Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and

Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62594/ --- Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier,

Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60511/#review186339 --- PASS: Mesos patch 60511 was successfully built and tested.

Re: Review Request 62554: Added the ability to prune the gone agent list from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62554/#review186337 --- FAIL: Some Mesos tests failed. Reviews applied: `['62475',

Re: Review Request 62230: Avoid GC pruning events from blocking other processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62230/ --- (Updated Sept. 26, 2017, 10:04 p.m.) Review request for mesos, Benjamin

Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62481/ --- (Updated Sept. 26, 2017, 8:45 p.m.) Review request for . Changes ---

Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62481/ --- (Updated Sept. 26, 2017, 8:45 p.m.) Review request for . Changes ---

Re: Review Request 62554: Added the ability to prune the gone agent list from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62554/#review186323 --- Ship it! Ship It! - Vinod Kone On Sept. 26, 2017, 8:30

Re: Review Request 62554: Added the ability to prune the gone agent list from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62554/ --- (Updated Sept. 26, 2017, 8:30 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 62477: Added the gone agents to the master registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62477/ --- (Updated Sept. 26, 2017, 8:25 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 62554: Added the ability to prune the gone agent list from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62554/ --- (Updated Sept. 26, 2017, 8:23 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- (Updated Sept. 26, 2017, 8:14 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 62579: [WIP] Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62579/#review186319 --- PASS: Mesos patch 62579 was successfully built and tested.

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/ --- (Updated Sept. 26, 2017, 7:09 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 62554: Added the ability to prune the gone agent list from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62554/#review186312 --- src/master/flags.cpp Line 603 (original), 603 (patched)

Re: Review Request 62479: Removed the logic for removing the latest symlink on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62479/#review186311 --- Can you also add a blurb to CHANGELOG about the new semantics? I

Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62481/#review186310 --- src/tests/gc_tests.cpp Line 381 (original)

Re: Review Request 62479: Removed the logic for removing the latest symlink on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62479/#review186308 --- Ship it! Ship It! - Vinod Kone On Sept. 21, 2017, 8:28

Re: Review Request 62478: Added the mark agent gone handler on the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62478/#review186306 --- Ship it! Ship It! - Vinod Kone On Sept. 21, 2017, 8:27

Re: Review Request 62581: Added `__removeSlave` function and made `_markUnreachable` use it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62581/#review186305 --- Ship it! Ship It! - Vinod Kone On Sept. 26, 2017, 6:05

Re: Review Request 62477: Added the gone agents to the master registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62477/#review186304 --- src/tests/registrar_tests.cpp Lines 384-385 (patched)

Re: Review Request 62477: Added the gone agents to the master registry.

> On Sept. 26, 2017, 12:02 a.m., Vinod Kone wrote: > > src/master/registry.proto > > Lines 60 (patched) > > > > > > s/master/operator/ ? > > Anand Mazumdar wrote: > hmm, not sure about this. The operator

Re: Review Request 62475: Added `MARK_AGENT_GONE` call to the v1 Master API.

> On Sept. 25, 2017, 11:41 p.m., Vinod Kone wrote: > > include/mesos/master/master.proto > > Lines 205-206 (patched) > > > > > > The last sentence is not strictly true right? A new agent with a new id > > but old

Re: Review Request 62554: Added the ability to prune the gone agent list from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62554/#review186301 --- PASS: Mesos patch 62554 was successfully built and tested.

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/ --- (Updated Sept. 26, 2017, 6:15 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 59687: Added tests for recovering ContainerConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/ --- (Updated Sept. 26, 2017, 6:14 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- (Updated Sept. 26, 2017, 6:13 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/#review186195 --- src/slave/containerizer/mesos/containerizer.cpp Line 1050

Re: Review Request 62230: Avoid GC pruning events from blocking other processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62230/#review186298 --- Fix it, then Ship it! src/slave/gc.cpp Lines 84 (patched)

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/ --- (Updated Sept. 26, 2017, 6:09 p.m.) Review request for mesos, Gilbert Song,

Review Request 62581: Added `__removeSlave` function and made `_markUnreachable` use it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62581/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 62475: Added `MARK_AGENT_GONE` call to the v1 Master API.

> On Sept. 25, 2017, 11:41 p.m., Vinod Kone wrote: > > include/mesos/master/master.proto > > Lines 205-206 (patched) > > > > > > The last sentence is not strictly true right? A new agent with a new id > > but old

Re: Review Request 62548: Reorganized and updated the contribution guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/#review186296 --- I like the idea of adding PR submissions for "trivial"

Re: Review Request 62479: Removed the logic for removing the latest symlink on the agent.

> On Sept. 26, 2017, 12:47 a.m., Vinod Kone wrote: > > src/slave/slave.cpp > > Line 889 (original) > > > > > > So sending a shutdown message now is only for shutting down the > > tasks/executors? Can we add/update

Re: Review Request 62478: Added the mark agent gone handler on the master.

> On Sept. 26, 2017, 12:41 a.m., Vinod Kone wrote: > > src/master/http.cpp > > Lines 5312-5338 (patched) > > > > > > These warnings and return messages seem inconsistent? Can we make them > > consistent? Looks

Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62481/ --- (Updated Sept. 26, 2017, 4:59 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 62477: Added the gone agents to the master registry.

> On Sept. 25, 2017, 11:56 p.m., Vinod Kone wrote: > > src/master/master.hpp > > Lines 2306 (patched) > > > > > > Looks like this is not possible according to the code in the next > > review. If so, can you return

Re: Review Request 62553: Fixed a flaky test.

> On Sept. 26, 2017, 1:08 a.m., Gilbert Song wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp > > Line 445 (original), 444 (patched) > > > > > > The flaky behavior is still reproducable: > > ``` > >

Review Request 62579: [WIP] Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62579/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8013

Re: Review Request 62067: Added 'mesos container list' command to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62067/#review186280 --- FAIL: Failed to apply the dependent review: 61212. Failed

Re: Review Request 61213: Added 'mesos task list' command to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61213/#review186279 --- PASS: Mesos patch 61213 was successfully built and tested.

Re: Review Request 61213: Added 'mesos task list' command to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61213/#review186265 --- Ship it! Ship It! - Kevin Klues On Sept. 26, 2017, 2:57

Re: Review Request 61213: Added 'mesos task list' command to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61213/ --- (Updated Sept. 26, 2017, 2:57 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 61213: Added 'mesos task list' command to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61213/#review186264 --- src/python/cli_new/lib/cli/plugins/task/main.py Lines 57

Re: Review Request 62065: Added 'mesos agent list' command to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62065/#review186263 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 61212: Added CLI utility function to verify addresses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61212/ --- (Updated Sept. 26, 2017, 2:15 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 62067: CLI: Added 'mesos container list' command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62067/#review186257 --- FAIL: Failed to apply the dependent review: 62573. Failed

Re: Review Request 61212: Added CLI utility function to verify addresses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61212/#review186254 --- src/python/cli_new/lib/cli/util.py Lines 162 (patched)

Review Request 62573: Added CLI utility function to get agent address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62573/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 61212: Added CLI utility function to verify addresses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61212/ --- (Updated Sept. 26, 2017, 1:53 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 60088: CLI: Added 'master' key as an acceptable key in config.toml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60088/#review186253 --- Ship it! Ship It! - Kevin Klues On Sept. 25, 2017, 2:03

Re: Review Request 60088: CLI: Added 'master' key as an acceptable key in config.toml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60088/#review186252 --- src/python/cli_new/lib/cli/config.py Lines 57 (patched)

Re: Review Request 62572: Added constants for the Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62572/#review186250 --- FAIL: Failed to apply the dependent review: 62544. Failed

Review Request 62572: Added constants for the Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62572/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 60088: CLI: Added 'master' key as an acceptable key in config.toml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60088/#review186245 --- src/python/cli_new/README.md Lines 82 (patched)

Re: Review Request 60088: CLI: Added 'master' key as an acceptable key in config.toml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60088/#review185986 --- src/python/cli_new/README.md Lines 82 (patched)