Re: Review Request 62645: Propagated new wait response fields from the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62645/#review186528 --- PASS: Mesos patch 62645 was successfully built and tested.

Re: Review Request 62648: Added a test for nested container resource limitations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62648/#review186524 --- FAIL: Some Mesos tests failed. Reviews applied: `['62640',

Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/#review186517 --- PASS: Mesos patch 62638 was successfully built and tested.

Review Request 62641: Removed multiple reasons from ContainerTermination.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62641/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-7963

Review Request 62640: Stopped keeping multiple limitations in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62640/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-7963

Review Request 62642: Propagated the termination info down the container tree.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62642/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-7963

Review Request 62648: Added a test for nested container resource limitations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62648/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-7963

Review Request 62644: Added resources to the TaskStatus message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62644/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-7963

Review Request 62647: Show resource limitations in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62647/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-7963

Review Request 62643: Propagated the container termination to the agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62643/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-7963

Review Request 62645: Propagated new wait response fields from the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62645/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-7963

Review Request 62646: Propagated new wait response fields from the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62646/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-7963

Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/#review186506 --- Ship it! Looks good to me, just waiting on the Windows

Re: Review Request 62632: Added a test using Docker, a file URI, and the DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62632/#review186505 --- FAIL: Failed to apply the dependent review: 62197. Failed

Re: Review Request 62616: Binary packaging for Centos 7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review186504 --- PASS: Mesos patch 62616 was successfully built and tested.

Re: Review Request 59746: Stopped accounting aborted container launches as failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59746/#review186459 --- src/slave/slave.cpp Lines 5230-5232 (patched)

Re: Review Request 62591: Modularized HTTP authenticatee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62591/#review186496 --- Ship it! Ship It! - Greg Mann On Sept. 26, 2017, 10:54

Review Request 62638: Removed support for platforms without O_CLOEXEC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/ --- Review request for mesos, Andrew Schwartzmeyer and Jie Yu. Bugs: MESOS-8027

Re: Review Request 62587: Added HTTP authenticatee interface definition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62587/#review186470 --- include/mesos/authentication/http/authenticatee.hpp Lines 41

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62595/#review186495 --- src/examples/test_http_authenticator_module.cpp Line 30

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62594/#review186483 --- src/scheduler/flags.hpp Lines 57-59 (patched)

Review Request 62632: Added a test using Docker, a file URI, and the DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62632/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-7916

Re: Review Request 62616: Binary packaging for Centos 7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/ --- (Updated Sept. 27, 2017, 5:50 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 62592: Added basic HTTP authenticatee implementation.

> On Sept. 27, 2017, 9:21 p.m., Greg Mann wrote: > > src/authentication/http/basic_authenticatee.cpp > > Lines 41-42 (patched) > > > > > > I think we usually put the `{}` on the same line as the initialization > >

Re: Review Request 62592: Added basic HTTP authenticatee implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62592/#review186476 --- src/authentication/http/basic_authenticatee.cpp Lines 41-42

Re: Review Request 52284: Implemented more quota validation tests and validate duplicate name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52284/#review186471 --- Fix it, then Ship it! Thanks for the patch, it looks like this

Re: Review Request 62168: Added a test using a file URI and the DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62168/#review186465 --- FAIL: Failed to apply the dependent review: 62197. Failed

Re: Review Request 62168: Added a test using a file URI and the DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62168/ --- (Updated Sept. 27, 2017, 7:07 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 62616: [WIP] Binary packaging for CentOS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review186415 --- PASS: Mesos patch 62616 was successfully built and tested.

Re: Review Request 62214: Added JavaScript linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review186407 --- src/webui/bootstrap Lines 71 (patched)

Re: Review Request 62616: [WIP] Binary packaging for CentOS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/ --- (Updated Sept. 27, 2017, 9:09 a.m.) Review request for mesos, Till Toenshoff

Review Request 62616: [WIP] Binary packaging for Centos 7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/ --- Review request for mesos, Till Toenshoff and Vinod Kone. Bugs: MESOS-7982

Re: Review Request 62065: Added 'mesos agent list' command to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62065/#review186405 --- Ship it! Ship It! - Kevin Klues On Sept. 27, 2017, 12:50

Re: Review Request 62065: Added 'mesos agent list' command to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62065/#review186403 --- FAIL: Failed to apply the dependent review: 61212. Failed

Re: Review Request 62067: Added 'mesos container list' command to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62067/#review186404 --- FAIL: Failed to apply the dependent review: 62573. Failed

Re: Review Request 62067: Added 'mesos container list' command to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62067/#review186401 --- I think we need to think a bit more about how we want to pass the

Re: Review Request 62065: Added 'mesos agent list' command to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62065/ --- (Updated Sept. 27, 2017, 12:50 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 62067: Added 'mesos container list' command to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62067/ --- (Updated Sept. 27, 2017, 12:39 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 62518: Fixed default executor handling of nested container status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62518/#review186388 --- Ship it! Ship It! - Qian Zhang On Sept. 25, 2017, 11:21

Re: Review Request 61682: Fixed usage of 'ATOMIC_FLAG_INIT'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61682/#review186387 --- Ship it! Ship It! - Jan Schlicht On Aug. 16, 2017, 10:35

Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62579/#review186386 --- PASS: Mesos patch 62579 was successfully built and tested.

Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62579/ --- (Updated Sept. 27, 2017, 2:24 p.m.) Review request for mesos and Gilbert Song.