Re: Review Request 63391: Fixed the flaky SlaveTest.HTTPSchedulerSlaveRestart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63391/#review189505 --- Patch looks great! Reviews applied: [63391] Passed command:

Re: Review Request 61810: Added a function to apply offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61810/#review189504 --- src/resource_provider/manager.cpp Lines 315 (patched)

Re: Review Request 62502: Added events to publish and unpublish resources.

> On Oct. 17, 2017, 8:48 p.m., Jie Yu wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 57-58 (patched) > > > > > > These two are not no needed for now. Let's remove it for now. Also,

Review Request 63391: Fixed the flaky SlaveTest.HTTPSchedulerSlaveRestart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63391/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-7972

Re: Review Request 63390: WIP: Add unit tests for storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63390/#review189501 --- Bad patch! Reviews applied: [63390, 63389, 63388, 63387, 63386,

Review Request 63390: WIP: Add unit tests for storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63390/ --- Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht. Repository:

Review Request 63389: Added a mock resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63389/ --- Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht. Bugs:

Review Request 63386: Added utility functions to print types in resource provider events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63386/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 63023: WIP: Added a test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63023/ --- (Updated Oct. 28, 2017, 12:08 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63022: Imported resources from CSI plugins in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/ --- (Updated Oct. 28, 2017, 12:07 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63021: Added functions to launch CSI plugin in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63021/ --- (Updated Oct. 28, 2017, 12:03 a.m.) Review request for mesos, James DeFelice,

Review Request 63385: Added utility functions for CSI responses and volume ID and metadata.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63385/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 63060: Added utility functions and structures for CSI version and capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63060/ --- (Updated Oct. 27, 2017, 11:58 p.m.) Review request for mesos, Benjamin Mahler

Review Request 63379: Set max-size for a book thumbnail on the site.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63379/ --- Review request for mesos and James Peach. Repository: mesos Description

Re: Review Request 63321: Added protobuf messages for V1 scheduler operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63321/ --- (Updated Oct. 27, 2017, 10:42 p.m.) Review request for mesos, Gaston Kleiman,

Review Request 63377: Added filesystem layout for storage resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63377/ --- Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht. Bugs:

Re: Review Request 63018: Added filesystem layout for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63018/ --- (Updated Oct. 27, 2017, 10:07 p.m.) Review request for mesos, Jie Yu, Joseph

Re: Review Request 62636: Generated authentication tokens for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62636/ --- (Updated Oct. 27, 2017, 9:58 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 62633: Added authentication tokens for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62633/ --- (Updated Oct. 27, 2017, 9:54 p.m.) Review request for mesos, Greg Mann, Jie

Review Request 63376: Started `LocalResourceProviderDaemon` after obtaining the slave ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63376/ --- Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht. Bugs:

Re: Review Request 63094: Added resource version uuid for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/#review189457 --- Fix it, then Ship it!

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review189460 --- Fix it, then Ship it!

Re: Review Request 63018: Added filesystem layout for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63018/#review189484 --- src/slave/paths.hpp Lines 55 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 27, 2017, 9:04 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 26, 2017, 10:49 p.m., Greg Mann wrote: > > include/mesos/resource_provider/resource_provider.proto > > Line 66 (original), 72 (patched) > > > > > > Do you want to use `OFFER_OPERATION` here instead? Or, do

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review189478 --- src/messages/messages.proto Lines 649 (patched)

Re: Review Request 62903: Added a call to update total resources and pending operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62903/ --- (Updated Oct. 27, 2017, 8:51 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63372: WIP: Added documentation for the built-in memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review189468 --- Bad patch! Reviews applied: [63372, 63371, 63370, 63369, 63368,

Review Request 63371: WIP: Added unit tests for new MemoryProfiler class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63371/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 63372: WIP: Added documentation for the built-in memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 63366: Added jemalloc release tarball and build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63366/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository:

Review Request 63367: Added an overload for strings::endsWith().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63367/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 63365: Re-ordered some configuration options alphabetically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63365/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 63369: Added new '/state' and '/statistics' endpoints to the MemoryProfiler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63369/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository:

Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository:

Re: Review Request 62502: Added events to publish and unpublish resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review189464 --- include/mesos/resource_provider/resource_provider.proto Lines 87

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62997/ --- (Updated Oct. 27, 2017, 6:03 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 59687: Added tests for recovering ContainerConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/ --- (Updated Oct. 27, 2017, 6:02 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- (Updated Oct. 27, 2017, 6:01 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/ --- (Updated Oct. 27, 2017, 6 p.m.) Review request for mesos, Gilbert Song, Jason

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/ --- (Updated Oct. 27, 2017, 5:57 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62938/#review189445 --- Ship it! Ship It! - Eric Chung On Oct. 26, 2017, 4:52 p.m.,

Re: Review Request 63094: Added resource version uuid for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/ --- (Updated Oct. 27, 2017, 5:06 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63094: Added resource version uuid for offer operations.

> On Oct. 26, 2017, 11:08 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 712 (patched) > > > > > > Do we need multiple ResourceVersionUUIDs here? Can the master just > > include the UUID for the

Re: Review Request 63358: Added the stub for OfferOperationStatusUpdate handler in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63358/#review189438 --- FAIL: Failed to apply the dependent review: 62903. Failed

Re: Review Request 63314: Add support for Ubuntu 16.04 in docker build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63314/#review189437 --- PASS: Mesos patch 63314 was successfully built and tested.

Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62938/#review189436 --- Patch looks great! Reviews applied: [62938] Passed command:

Re: Review Request 63358: Added the stub for OfferOperationStatusUpdate handler in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63358/#review189426 --- Bad patch! Reviews applied: [63358, 63356, 63312, 63105, 61946,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 27, 2017, 12:58 p.m.) Review request for mesos, Benjamin

Re: Review Request 63355: Added validation for disk related new operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63355/#review189421 --- Patch looks great! Reviews applied: [63001, 62903, 63094, 63104,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 6:33 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 637-638 (patched) > > > > > > I think that this list should include pending operations, but should > > _not_ include

Review Request 63358: Added the stub for OfferOperationStatusUpdate handler in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63358/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan

Re: Review Request 63356: Implemented handling of storage related offer operations in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63356/ --- (Updated Oct. 27, 2017, 10:28 a.m.) Review request for mesos, Benjamin

Review Request 63356: Implemented handling of storage related offer operations in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63356/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan

Re: Review Request 63312: Updated Resources::apply for new operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63312/ --- (Updated Oct. 27, 2017, 10:27 a.m.) Review request for mesos, Benjamin

Review Request 63355: Added validation for disk related new operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63355/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/#review189410 --- Patch looks great! Reviews applied: [63353] Passed command:

Re: Review Request 63094: Added resource version uuid for offer operations.

> On Oct. 20, 2017, 12:44 p.m., Benjamin Bannier wrote: > > src/messages/messages.proto > > Lines 663 (patched) > > > > > > Even though currently operation on agent resources cannot exhibit > > operation

Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/ --- Review request for mesos, Benjamin Mahler and Greg Mann. Bugs: MESOS-8135

Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62938/#review189402 --- Patch looks great! Reviews applied: [62938] Passed command: