Re: Review Request 63642: Added a test for ExecutorID validation in ReregisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63642/#review190429 --- Patch looks great! Reviews applied: [63642] Passed command:

Review Request 63652: Added d_type check in containerizer backend validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63652/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8121

Re: Review Request 63652: Added d_type check in containerizer backend validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63652/#review190420 --- FAIL: Mesos tests failed to build. Reviews applied: `['63652']`

Re: Review Request 63642: Added a test for ExecutorID validation in ReregisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63642/#review190404 --- PASS: Mesos patch 63642 was successfully built and tested.

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review190425 --- PASS: Mesos patch 63253 was successfully built and tested.

Re: Review Request 63655: Switched to `net::socketpair` in `ns::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63655/#review190422 --- PASS: Mesos patch 63655 was successfully built and tested.

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

> On Nov. 3, 2017, 6:29 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/os/windows/copyfile.hpp > > Lines 56-57 (patched) > > > > > > The general pattern is to just include the reason for an error, and

Re: Review Request 63642: Added a test for ExecutorID validation in ReregisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63642/#review190371 --- src/tests/master_validation_tests.cpp Lines 4215 (patched)

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/ --- (Updated Nov. 8, 2017, 12:37 a.m.) Review request for mesos, Andrew

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review190418 --- Patch looks great! Reviews applied: [60620, 60621, 60622, 60623,

Re: Review Request 60890: Defined API for launching standalone containers.

> On Nov. 2, 2017, 3:56 p.m., Joseph Wu wrote: > > include/mesos/agent/agent.proto > > Lines 253-255 (patched) > > > > > > Leaving this up for discussion: > > > > The existing call (`RemoveNestedContainer`)

Re: Review Request 62143: Added validation for Standalone Container APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62143/#review190396 --- src/slave/validation.cpp Lines 381 (patched)

Re: Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63175/#review190412 --- src/master/allocator/mesos/hierarchical.hpp Lines 319 (patched)

Review Request 63655: Switched to `net::socketpair` in `ns::clone`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63655/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8156

Review Request 63654: Added a `net::socketpair` helper to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63654/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8156

Re: Review Request 63642: Added a test for ExecutorID validation in ReregisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63642/#review190408 --- Fix it, then Ship it! src/tests/master_validation_tests.cpp

Re: Review Request 63642: Added a test for ExecutorID validation in ReregisterSlaveMessage.

> On Nov. 8, 2017, 12:42 a.m., Jiang Yan Xu wrote: > > src/tests/master_validation_tests.cpp > > Lines 4240-4241 (patched) > > > > > > I was suggesting `ASSERT_*` as strictly speaking the test code prepared > >

Re: Review Request 63642: Added a test for ExecutorID validation in ReregisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63642/#review190415 --- Ship it! Ship It! - James DeFelice On Nov. 7, 2017, 6:47

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Nov. 7, 2017, 11 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63540: Added flag protobuf message for agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63540/ --- (Updated Nov. 7, 2017, 11 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63519: Allowed toggling of agent capabilities via command line flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63519/ --- (Updated Nov. 7, 2017, 11 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63492: Synchronized agent resource versions via 'UpdateSlaveMessage'.

> On Nov. 7, 2017, 7:08 p.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 6648-6651 (patched) > > > > > > I am a little hesitate about this. Resource estimator can change quite > > frequently, and any change

Re: Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63175/#review190385 --- Fix it, then Ship it!

Re: Review Request 60888: Added recovery logic for standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60888/#review190388 --- Ship it! Ship It! - Jie Yu On Nov. 2, 2017, 3:43 p.m.,

Re: Review Request 63649: Introduced `.clang-tidy` configuration file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63649/#review190373 --- Fix it, then Ship it! support/mesos-tidy/entrypoint.sh Lines

Re: Review Request 63649: Introduced `.clang-tidy` configuration file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63649/ --- (Updated Nov. 7, 2017, 2:14 p.m.) Review request for mesos and Benjamin

Re: Review Request 63492: Synchronized agent resource versions via 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63492/#review190384 --- Ship it! Ship It! - Jie Yu On Nov. 7, 2017, 10 p.m.,

Re: Review Request 63519: Allowed toggling of agent capabilities via command line flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63519/ --- (Updated Nov. 8, 2017, 12:35 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 60888: Added recovery logic for standalone containers.

> On Oct. 17, 2017, 5:39 p.m., Jie Yu wrote: > > src/slave/paths.hpp > > Lines 53-54 (patched) > > > > > > Putting this path here is a bit wierd because this directory is kind of > > containerizer specific. > >

Re: Review Request 63519: Allowed toggling of agent capabilities via command line flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63519/#review190375 --- docs/configuration/agent.md Lines 101-103 (patched)

Review Request 63649: Introduced `.clang-tidy` configuration file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63649/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 63496: Added tests for agent resource version transmission.

> On Nov. 7, 2017, 6:40 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 8679-8681 (patched) > > > > > > Would be good if this test or another could verify that a new resource > > version is sent for

Re: Review Request 63496: Added tests for agent resource version transmission.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63496/ --- (Updated Nov. 7, 2017, 11:01 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63492: Synchronized agent resource versions via 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63492/ --- (Updated Nov. 7, 2017, 11 p.m.) Review request for mesos, Gaston Kleiman, Greg

Re: Review Request 63493: Transmitted agent resource versions in (re)registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63493/ --- (Updated Nov. 7, 2017, 11 p.m.) Review request for mesos, Gaston Kleiman, Greg

Re: Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/ --- (Updated Nov. 7, 2017, 11 p.m.) Review request for mesos, Chun-Hung Hsiao, Jie

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

> On Nov. 7, 2017, 2:22 p.m., Qian Zhang wrote: > > I think you need to do the similar changes to the `CheckInfo` message. `CheckInfo` is specific to the `default-executor` and hence UCR. We don't support IPv6 for CNI and hence UCR at this point, so hence not adding this to `CheckInfo` at

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

> On Nov. 2, 2017, 6:48 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto > > Lines 512-516 (patched) > > > > > > When I see this enum, I have several questions, for example, "how this > > fits into

Re: Review Request 63641: Used move for events consumption in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63641/#review190356 --- Patch looks great! Reviews applied: [63628, 63629, 63630, 63631,

Re: Review Request 63622: Provided handling for offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63622/#review190355 --- src/resource_provider/message.hpp Lines 48-52 (patched)

Re: Review Request 63642: Added a test for ExecutorID validation in ReregisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63642/#review190362 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62997/#review190353 --- src/slave/containerizer/mesos/provisioner/paths.hpp Line 55

Re: Review Request 63641: Used move for events consumption in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63641/#review190360 --- FAIL: mesos-java failed to build. Reviews applied: `['63628',

Re: Review Request 63625: Added a test for resource conversion using a resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63625/#review190354 --- FAIL: Failed to apply the dependent review: 63622. Failed

Re: Review Request 63615: Passed scheduler as a shared pointer into the callback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63615/#review190352 --- PASS: Mesos patch 63615 was successfully built and tested.

Review Request 63642: Added a test for ExecutorID validation in ReregisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63642/ --- Review request for mesos, James DeFelice and Jiang Yan Xu. Bugs: MESOS-8169

Re: Review Request 63620: Updated offer operation handling to set resource versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63620/#review190350 --- src/master/master.cpp Line 9905 (original), 9969 (patched)

Re: Review Request 63496: Added tests for agent resource version transmission.

> On Nov. 7, 2017, 5:40 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 8679-8681 (patched) > > > > > > Would be good if this test or another could verify that a new resource > > version is sent for

Re: Review Request 63496: Added tests for agent resource version transmission.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63496/#review190349 --- Ship it! Ship It! - Jie Yu On Nov. 7, 2017, 12:56 p.m.,

Re: Review Request 63496: Added tests for agent resource version transmission.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63496/#review190347 --- src/tests/slave_tests.cpp Lines 8679-8681 (patched)

Re: Review Request 63492: Synchronized agent clock with master via 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63492/#review190251 --- src/master/master.cpp Lines 6931-6932 (patched)

Re: Review Request 63606: Avoid an extra copy during ProtobufProcess::send.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63606/#review190344 --- PASS: Mesos patch 63606 was successfully built and tested.

Review Request 63641: Used move for events consumption in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63641/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Re: Review Request 63496: Added tests for agent resource version transmission.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63496/#review190338 --- src/tests/slave_tests.cpp Lines 8679-8681 (patched)

Re: Review Request 63625: Added a test for resource conversion using a resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63625/#review190342 --- Bad patch! Reviews applied: [63625, 63622, 63621, 63620, 63496,

Review Request 63639: Enabled rvalue reference parameters in protobuf handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63639/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Review Request 63638: Added callable once support in Future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63638/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Review Request 63637: Added callable once support in defer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63637/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Review Request 63631: Separated event visiting and consumption.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63631/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Review Request 63629: Added partial function application implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63629/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Review Request 63633: Added ability to protect nested bind expressions from composition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63633/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Review Request 63636: Added placeholder implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63636/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Review Request 63635: Prepared defer for use in callable once contexts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63635/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Review Request 63630: Added support for callable once functors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63630/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Review Request 63634: Changed dispatch to use callable once functors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63634/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Review Request 63632: Migrated to event consumer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63632/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Review Request 63628: Implemented index_sequence and related functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63628/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review190335 --- Ship it! Ship It! - Greg Mann On Nov. 7, 2017, 12:25 p.m.,

Re: Review Request 63625: Added a test for resource conversion using a resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63625/#review190330 --- src/tests/resource_provider_manager_tests.cpp Lines 730

Re: Review Request 63496: Added tests for agent resource version transmission.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63496/#review190333 --- PASS: Mesos patch 63496 was successfully built and tested.

Re: Review Request 63581: Created virtual environment for linters in /support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63581/#review190332 --- Ship it! support/mesos-style.py Line 383 (original), 331

Re: Review Request 63615: Passed scheduler as a shared pointer into the callback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63615/#review190331 --- Patch looks great! Reviews applied: [63611, 63612, 63613, 63614,

Re: Review Request 63581: Created virtual environment for linters in /support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63581/#review190329 --- support/mesos-style.py Line 372 (original), 370 (patched)

Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62938/#review190327 --- Ship it! Ship It! - Kevin Klues On Nov. 7, 2017, 3:50 p.m.,

Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62938/ --- (Updated Nov. 7, 2017, 3:50 p.m.) Review request for mesos, Eric Chung and

Re: Review Request 63622: Provided handling for offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63622/#review190323 --- src/resource_provider/manager.cpp Lines 430 (patched)

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review190324 --- PASS: Mesos patch 63253 was successfully built and tested.

Re: Review Request 62938: Added ZooKeeper leader resolution to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62938/#review190322 --- src/python/cli_new/lib/cli/util.py Lines 258 (patched)

Review Request 63625: Added a test for resource conversion using a resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63625/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 63606: Avoid an extra copy during ProtobufProcess::send.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63606/#review190319 --- Ship it! Ship It! - Benjamin Hindman On Nov. 7, 2017, 4:23

Re: Review Request 63605: Support moving in data during ProcessBase::send.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63605/#review190318 --- Ship it! Ship It! - Benjamin Hindman On Nov. 7, 2017, 3:40

Re: Review Request 62161: Update boost version.

> On Nov. 7, 2017, 4:26 p.m., Benjamin Bannier wrote: > > 3rdparty/versions.am > > Line 22 (original), 22 (patched) > > > > > > This patch in general seems to trigger the issue fixed in > >

Re: Review Request 62161: Update boost version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62161/#review190316 --- 3rdparty/versions.am Line 22 (original), 22 (patched)

Re: Review Request 63292: Added lamdba::zip.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63292/#review190310 --- 3rdparty/stout/include/stout/lambda.hpp Lines 168 (patched)

Re: Review Request 63604: Removed an unnecessary serialization in protobuf process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63604/#review190315 --- Ship it! Ship It! - Benjamin Hindman On Nov. 7, 2017, 3:40

Re: Review Request 62161: Update boost version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62161/#review190302 --- Fix it, then Ship it! 3rdparty/cmake/Versions.cmake Lines 1-2

Re: Review Request 63621: Added a devolve function for 'OfferOperationStatus'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63621/#review190311 --- Fix it, then Ship it! src/internal/devolve.hpp Lines 70

Re: Review Request 63620: Updated offer operation handling to set resource versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63620/#review190304 --- src/master/master.cpp Lines 5212 (patched)

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review190303 --- I think you need to do the similar changes to the `CheckInfo`

Review Request 63622: Provided handling for offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63622/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Review Request 63621: Added a devolve function for 'OfferOperationStatus'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63621/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Review Request 63620: Updated offer operation handling to set resource versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63620/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 63495: Added comparison operators for 'ResourceVersionUUID'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63495/ --- (Updated Nov. 7, 2017, 3:11 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63538: Removed expectation for scheduler connected events in some tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63538/#review190301 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 63538: Removed expectation for scheduler connected events in some tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63538/#review190300 --- Patch looks great! Reviews applied: [63538] Passed command:

Re: Review Request 63538: Removed expectation for scheduler connected events in some tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63538/#review190295 --- Fix it, then Ship it! I'll fix the issue and commit shortly.

Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER capable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62880/#review190299 --- I'd suggest to discard this patch in favor of the feature flag

Review Request 63615: Passed scheduler as a shared pointer into the callback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63615/ --- Review request for mesos, Michael Park and Vinod Kone. Bugs: MESOS-8096

Review Request 63614: Removed unnecessary check in v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63614/ --- Review request for mesos, Michael Park and Vinod Kone. Bugs: MESOS-8096

Review Request 63612: Modified formatting of v1 scheduler test driver for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63612/ --- Review request for mesos, Michael Park and Vinod Kone. Repository: mesos

  1   2   >