Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review197710 --- Patch looks great! Reviews applied: [65585, 64211] Passed

Re: Review Request 65683: Added discard handling to Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review197709 --- PASS: Mesos patch 65683 was successfully built and tested.

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review197708 --- PASS: Mesos patch 64211 was successfully built and tested.

Re: Review Request 65695: Made the default executor allow schedulers to retry task kills.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65695/#review197707 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65683: Added discard handling to Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/ --- (Updated Feb. 17, 2018, 2:37 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 65696: Allowed base64-decoding with whitespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65696/#review197705 --- PASS: Mesos patch 65696 was successfully built and tested.

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review197704 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 16, 2018,

Re: Review Request 65615: Added docker constants and common functions file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/#review197703 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 16, 2018,

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64604/#review197702 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 65694: Made the default executor's handling of kill escalations more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65694/ --- Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone. Bugs:

Review Request 65695: Made the default executor allow schedulers to retry task kills.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65695/ --- Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone. Bugs:

Review Request 65696: Allowed base64-decoding with whitespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65696/ --- Review request for mesos, Michael Park and Till Toenshoff. Bugs: MESOS-8569

Review Request 65693: Made the default executor fail kills if the response isn't "200 OK".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65693/ --- Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone. Bugs:

Review Request 65692: Changed the signature of a DefaultExecutor kill method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65692/ --- Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone. Bugs:

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Feb. 16, 2018, 11:49 p.m.) Review request for mesos, Alexander

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64604/ --- (Updated Feb. 16, 2018, 11:47 p.m.) Review request for mesos, Alexander

Re: Review Request 65615: Added docker constants and common functions file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/ --- (Updated Feb. 16, 2018, 11:30 p.m.) Review request for mesos, Alexander

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/ --- (Updated Feb. 16, 2018, 11:29 p.m.) Review request for mesos, Alexander

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/ --- (Updated Feb. 16, 2018, 11:25 p.m.) Review request for mesos, Alexander

Re: Review Request 65393: Fixed docker command health check to use the right docker socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65393/ --- (Updated Feb. 16, 2018, 11:25 p.m.) Review request for mesos, Alexander

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/ --- (Updated Feb. 16, 2018, 10:54 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65585: Improved documentation regarding the new CLI setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65585/ --- (Updated Feb. 16, 2018, 10:45 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65689: Fixed the task update issue on framework due to docker daemon hangs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65689/#review197686 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65202: Adopted `TEST_AWAIT_TIMEOUT` in Mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/#review197683 --- PASS: Mesos patch 65202 was successfully built and tested.

Review Request 65689: Fixed the task update issue on framework due to docker daemon hangs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65689/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-8573

Re: Review Request 65298: Split test flags into header and source files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65298/ --- (Updated Feb. 16, 2018, 6:07 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65202: Adopted `TEST_AWAIT_TIMEOUT` in Mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/ --- (Updated Feb. 16, 2018, 6:07 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65201: Added a global `TEST_AWAIT_TIMEOUT` variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65201/ --- (Updated Feb. 16, 2018, 6:05 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65343: Adopted `TEST_AWAIT_TIMEOUT` in libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65343/ --- (Updated Feb. 16, 2018, 6:06 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review197680 --- Patch looks great! Reviews applied: [65671, 65672, 65044, 65045]

Re: Review Request 65671: Added comparison operators for operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65671/ --- (Updated Feb. 16, 2018, 4:35 p.m.) Review request for mesos and Benjamin

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review197674 --- Fix it, then Ship it! src/tests/master_tests.cpp Lines 8803

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review197672 --- Fix it, then Ship it! src/slave/http.cpp Lines 1695 (patched)

Re: Review Request 65655: Updated Mesos CLI test base to use shell to start masters and agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65655/#review197671 --- Ship it! Ship It! - Kevin Klues On Feb. 14, 2018, 4:17

Re: Review Request 65672: Added comparison operators for 'v1::UUID'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65672/#review197670 --- Ship it! Ship It! - Benjamin Bannier On Feb. 15, 2018,

Re: Review Request 65671: Added comparison operators for operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65671/#review197669 --- Fix it, then Ship it! include/mesos/type_utils.hpp Lines 65

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

> On Feb. 3, 2018, 12:06 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7594-7597 (original), 7609-7612 (patched) > > > > > > Is this function now only called with resources from already-existing > >

Re: Review Request 65591: Explicitly tracked resource providers in master.

> On Feb. 16, 2018, 2:13 a.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Line 7307 (original), 7351 (patched) > > > > > > Do we plan to support resource providers with info (so not the > > agent-default

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

> On Feb. 16, 2018, 1:13 a.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Lines 7652 (patched) > > > > > > s/ "operation/<< "operation/ I don't think we need or want an extra function call here. I ended

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

> On Feb. 16, 2018, 12:55 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7645 (patched) > > > > > > s/`RunTaskMessage`, see/`RunTaskMessage`. See/ Hmm ... I am not a native speaker, but wouldn't

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/ --- (Updated Feb. 16, 2018, 3:12 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/ --- (Updated Feb. 16, 2018, 3:12 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 65683: Added discard handling to Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review197667 --- PASS: Mesos patch 65683 was successfully built and tested.

Re: Review Request 65683: Added discard handling to Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review197662 --- Patch looks great! Reviews applied: [65683] Passed command: