Re: Review Request 65825: Added a test that Docker tasks can be killed when 'inspect' is hung.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65825/#review198374 --- Patch looks great! Reviews applied: [65786, 65787, 65751, 65750,

Re: Review Request 65823: Avoid copies of task reconciliation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65823/#review198370 --- Patch looks great! Reviews applied: [65823] Passed command:

Re: Review Request 65825: Added a test that Docker tasks can be killed when 'inspect' is hung.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65825/#review198369 --- PASS: Mesos patch 65825 was successfully built and tested.

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

> On Feb. 27, 2018, 11:06 p.m., Benjamin Mahler wrote: > > src/webui/master/static/js/controllers.js > > Lines 562 (patched) > > > > > > Why did you need the additional query into the /flags here but not in > >

Re: Review Request 65683: Updated discard handling in 'Docker::inspect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review198367 --- Ship it! Ship It! - Gilbert Song On Feb. 27, 2018, 2:35

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/ --- (Updated Feb. 28, 2018, 1:37 a.m.) Review request for mesos, Alexander

Re: Review Request 65743: Ensured that Docker containerizer returns a failed Future in one case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65743/ --- (Updated Feb. 28, 2018, 1:36 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65743: Ensured that Docker containerizer returns a failed Future in one case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65743/ --- (Updated Feb. 28, 2018, 1:04 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65246/#review198363 --- PASS: Mesos patch 65246 was successfully built and tested.

Re: Review Request 65825: Added a test that Docker tasks can be killed when 'inspect' is hung.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65825/#review198362 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines

Re: Review Request 65825: Added a test that Docker tasks can be killed when 'inspect' is hung.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65825/ --- (Updated Feb. 28, 2018, 12:39 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65823: Avoid copies of task reconciliation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65823/#review198360 --- Ship it! Ship It! - Michael Park On Feb. 27, 2018, 3:32

Review Request 65825: Added a test that Docker tasks can be killed when 'inspect' is hung.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65825/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. Bugs:

Re: Review Request 65823: Avoid copies of task reconciliation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65823/#review198358 --- PASS: Mesos patch 65823 was successfully built and tested.

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review198357 --- Patch looks great! Reviews applied: [63859, 63860, 63861, 63862]

Re: Review Request 65817: Fixed argument quoting in the test script in `HungDockerTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65817/#review198356 --- Ship it! Ship It! - Greg Mann On Feb. 27, 2018, 5:49 p.m.,

Re: Review Request 65683: Updated discard handling in 'Docker::inspect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review198355 --- Ship it! Ship It! - Michael Park On Feb. 27, 2018, 2:35

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

> On Feb. 27, 2018, 11:06 p.m., Benjamin Mahler wrote: > > src/webui/master/static/js/controllers.js > > Lines 562 (patched) > > > > > > Why did you need the additional query into the /flags here but not in > >

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65246/ --- (Updated Feb. 27, 2018, 11:40 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 65823: Avoid copies of task reconciliation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65823/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review198351 --- PASS: Mesos patch 63862 was successfully built and tested.

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65246/#review198345 --- Fix it, then Ship it! Thanks Armand! Looks pretty good now,

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/ --- (Updated Feb. 27, 2018, 10:34 p.m.) Review request for mesos, Alexander

Re: Review Request 65817: Fixed argument quoting in the test script in `HungDockerTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65817/#review198344 --- Patch looks great! Reviews applied: [65817] Passed command:

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review198342 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- (Updated Feb. 27, 2018, 7:05 p.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout for evaluating real path within a scoped root directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- (Updated Feb. 27, 2018, 7:04 p.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

> On Feb. 27, 2018, 5:42 p.m., Zhitao Li wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 61 (patched) > > > > > > Can you clarify whether the rules also apply to windows properly with > > correct

Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated Feb. 27, 2018, 6:52 p.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65817: Fixed argument quoting in the test script in `HungDockerTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65817/#review198339 --- PASS: Mesos patch 65817 was successfully built and tested.

Review Request 65817: Fixed argument quoting in the test script in `HungDockerTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65817/ --- Review request for mesos, Benjamin Bannier, Gilbert Song, and Greg Mann.

Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review198334 --- 3rdparty/stout/include/stout/path.hpp Lines 61 (patched)

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65246/#review198332 --- PASS: Mesos patch 65246 was successfully built and tested.

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198328 --- PASS: Mesos patch 65759 was successfully built and tested.

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

> On Feb. 15, 2018, 7:23 p.m., Benjamin Mahler wrote: > > src/webui/master/static/js/controllers.js > > Lines 578-585 (patched) > > > > > > I'm puzzled about what's going on here, why do we need to stream the > >

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65246/ --- (Updated Feb. 27, 2018, 3:31 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 65683: Updated discard handling in 'Docker::inspect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review198325 --- src/docker/docker.cpp Lines 1287-1288 (patched)

Re: Review Request 65314: Removed code which is not used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65314/#review198324 --- Patch looks great! Reviews applied: [65310, 65311, 65312, 65313,

Re: Review Request 65683: Updated discard handling in 'Docker::inspect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/ --- (Updated Feb. 27, 2018, 10:35 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65314: Removed code which is not used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65314/#review198322 --- PASS: Mesos patch 65314 was successfully built and tested.

Re: Review Request 65314: Removed code which is not used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65314/ --- (Updated Feb. 27, 2018, 9:31 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 65313: Refactored authorization logic in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65313/ --- (Updated Feb. 27, 2018, 9:30 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 65312: Refactored authorization logic in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65312/ --- (Updated Feb. 27, 2018, 9:29 a.m.) Review request for mesos, Benjamin Hindman