Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66104/#review199308 --- Patch looks great! Reviews applied: [66104] Passed command:

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 16, 2018, 1:55 a.m.) Review request for mesos, Benjamin

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

> On March 16, 2018, 12:23 a.m., Gaston Kleiman wrote: > > src/tests/scheduler_tests.cpp > > Lines 1239-1240 (patched) > > > > > > Do we need this? My understanding is that frameworks will get offers as > > soon

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 16, 2018, 1:54 a.m.) Review request for mesos, Benjamin

Re: Review Request 63991: Added helpers to create and forward offer operation updates.

> On March 14, 2018, 3:56 p.m., Benjamin Bannier wrote: > > src/common/protobuf_utils.hpp > > Lines 165-170 (patched) > > > > > > This looks unusual when compared to other helpers in this file which > > usually

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199305 --- src/tests/scheduler_tests.cpp Lines 1239-1240 (patched)

Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

> On March 15, 2018, 4:33 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp > > Lines 404 (patched) > > > > > > Instead of the check failure. We probably should return a

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/#review199303 --- src/master/master.cpp Lines 4092-4098 (patched)

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review199302 --- Patch looks great! Reviews applied: [65571] Passed command:

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 16, 2018, 12:06 a.m.) Review request for mesos, Benjamin

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 16, 2018, 12:02 a.m.) Review request for mesos, Benjamin

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63992/ --- (Updated March 16, 2018, 12:01 a.m.) Review request for mesos, Benjamin

Re: Review Request 66034: Remount several proc filesystem entries as read-only.

> On March 15, 2018, 6:30 p.m., Zhitao Li wrote: > > I feel that the complexity of this code justifies better user doc, possibly > > when we create a new isolator for this? > > > > Also, how much of each mount should be allow to reconfigure? Should this > > behavior be dictated for every user

Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66104/#review199301 --- PASS: Mesos patch 66104 was successfully built and tested.

Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66104/#review199300 --- src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp

Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66104/#review199298 --- Ship it! Ship It! - Gilbert Song On March 15, 2018, 3:31

Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66104/ --- Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, and Zhitao Li.

Re: Review Request 66101: Added a helper to parse ContainerID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66101/#review199297 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199295 --- PASS: Mesos patch 66001 was successfully built and tested.

Re: Review Request 66097: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66097/#review199296 --- Bad patch! Reviews applied: [66097, 66096, 66095, 66094] Failed

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review199294 --- PASS: Mesos patch 65571 was successfully built and tested.

Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65987/#review199293 --- src/master/validation.cpp Lines 1490-1491 (patched)

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199292 --- Patch looks great! Reviews applied: [66001] Passed command:

Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65987/#review199291 --- src/master/validation.cpp Lines 1491 (patched)

Review Request 66101: Added a helper to parse ContainerID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66101/ --- Review request for mesos and Sagar Patwardhan. Bugs: MESOS-8534

Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65987/#review199274 --- Fix it, then Ship it!

Re: Review Request 66097: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66097/#review199287 --- FAIL: Failed to apply the dependent review: 66094. Failed

Re: Review Request 66096: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66096/#review199286 --- FAIL: Failed to apply the dependent review: 66094. Failed

Review Request 66097: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66097/ --- Review request for mesos and Jie Yu. Bugs: MESOS-8678

Review Request 66096: Adapted the new `grpcpp` C++ headers for gRPC v1.10 in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66096/ --- Review request for mesos and Jie Yu. Bugs: MESOS-8678

Review Request 66095: Fixed gRPC compilation in standalone libprocess build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66095/ --- Review request for mesos and Jie Yu. Bugs: MESOS-8678

Review Request 66094: Bumped bundled gRPC to 1.10.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66094/ --- Review request for mesos and Jie Yu. Bugs: MESOS-8678

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review199283 --- include/mesos/mesos.proto Lines 1920-1921 (patched)

Re: Review Request 66076: Used raw string literal in protobuf tests to avoid escaping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66076/#review199285 --- Patch looks great! Reviews applied: [66076] Passed command:

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review199282 --- src/master/master.cpp Line 2138 (original), 2136 (patched)

Re: Review Request 66034: Remount several proc filesystem entries as read-only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66034/#review199281 --- I feel that the complexity of this code justifies better user

Re: Review Request 66034: Remount several proc filesystem entries as read-only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66034/ --- (Updated March 15, 2018, 6:24 p.m.) Review request for mesos, Eric Chung,

Re: Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65899/#review199276 --- Ship it! Ship It! - Eric Chung On March 15, 2018, 8:18

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199270 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 15, 2018, 4:14 p.m.) Review request for mesos and James Peach.

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review199267 --- src/tests/slave_tests.cpp Lines 5179 (patched)

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review199265 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66088: Fixed crash on macOS during certain authorization calls.

> On March 15, 2018, 3:36 p.m., Jan Schlicht wrote: > > src/common/http.cpp > > Lines 885-886 (original), 885-886 (patched) > > > > > > If it's the ordering of `ObjectApprovers` that's important, then we > >

Re: Review Request 66088: Fixed crash on macOS during certain authorization calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66088/#review199259 --- src/common/http.cpp Lines 885-886 (original), 885-886 (patched)

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199261 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66088: Fixed crash on macOS during certain authorization calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66088/ --- (Updated March 15, 2018, 3:27 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 66088: Fixed crash on macOS during certain authorization calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66088/#review199258 --- Ship it! src/common/http.cpp Line 871 (original), 871

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/ --- (Updated March 15, 2018, 2:19 p.m.) Review request for mesos, Andrei Budnik

Review Request 66088: Fixed crash on macOS during certain authorization calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66088/ --- Review request for mesos, Benno Evers and Jan Schlicht. Bugs: MESOS-8677

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 15, 2018, 1:48 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199257 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 15, 2018, 1:33 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199256 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 15, 2018, 1:27 p.m.) Review request for mesos and James Peach.

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review199255 --- Patch looks great! Reviews applied: [64970] Passed command:

Re: Review Request 66076: Used raw string literal in protobuf tests to avoid escaping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66076/#review199252 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66076: Used raw string literal in protobuf tests to avoid escaping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66076/ --- (Updated March 15, 2018, 5:29 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65899/ --- (Updated March 15, 2018, 8:18 a.m.) Review request for mesos, Anish Gupta,

Re: Review Request 65898: Add `MesosContainerizerLaunchHelper` and subclasses for different OSes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65898/ --- (Updated March 15, 2018, 8:17 a.m.) Review request for mesos, Anish Gupta,

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199250 --- Patch looks great! Reviews applied: [66037] Passed command: