Re: Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66615/#review201156 --- Patch looks great! Reviews applied: [66615] Passed command:

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On April 14, 2018, 1:52 a.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 4976 (patched) > > > > > > As we discussed, we should validate that there is only one operation. > > Shouldn't we add the

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review201150 --- src/master/master.cpp Lines 4969 (patched)

Re: Review Request 66616: Marked volume/block creation and destroy operations as experimental.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66616/#review201152 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66616: Marked volume/block creation and destroy operations as experimental.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66616/ --- Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Bugs:

Re: Review Request 66464: Implemented operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/ --- (Updated April 13, 2018, 5:51 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66615/#review201148 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66615/#review201146 --- Thanks for the cleanup! I think we could get rid of quite some

Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66615/ --- Review request for mesos, Andrei Budnik, Gaston Kleiman, Greg Mann, and Zhitao

Re: Review Request 66284: Tested `max_completion_time` support in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66284/#review201132 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines 646

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review201143 --- Ship it! Ship It! - Jie Yu On April 12, 2018, 3:35 a.m.,

Re: Review Request 64923: Added replicated log reader catch-up section to the upgrades doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64923/#review201138 --- Ship it! Ship It! - Jie Yu On Jan. 3, 2018, 7:19 p.m., Ilya

Re: Review Request 64922: Added VOTING replica catch-up section to replicated log docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64922/#review201137 --- Ship it! Ship It! - Jie Yu On Jan. 3, 2018, 7:18 p.m., Ilya

Re: Review Request 64921: Fixed a typo and formatting in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64921/#review201136 --- Ship it! Ship It! - Jie Yu On Jan. 3, 2018, 7:18 p.m., Ilya

Re: Review Request 66283: Added support of `max_completion_time` in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66283/#review201126 --- src/docker/executor.cpp Lines 405 (patched)

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/ --- (Updated April 13, 2018, 6:49 p.m.) Review request for mesos and Alexander

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/ --- (Updated April 13, 2018, 6:48 p.m.) Review request for mesos and Alexander

Re: Review Request 66260: Tested `max_completion_time` support in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66260/#review201124 --- Fix it, then Ship it! src/tests/command_executor_tests.cpp

Re: Review Request 66258: Added `max_completion_time` to `TaskInfo` and new reason.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66258/#review201120 --- Fix it, then Ship it! include/mesos/mesos.proto Lines 2109

Re: Review Request 66591: Added a validation that `max_completion_time` must be non-negative.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66591/#review201114 --- Fix it, then Ship it! src/master/validation.cpp Lines 1320

Re: Review Request 66259: Added `max_completion_time` support to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66259/#review201112 --- src/launcher/executor.cpp Lines 590 (patched)

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On April 12, 2018, 5:27 p.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 1975 (patched) > > > > > > Hmm I wonder if we should just use a `double` here? Does the > > `Value.Scalar` type provide some

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated April 13, 2018, 10:20 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated April 13, 2018, 10:15 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201109 --- src/tests/persistent_volume_tests.cpp Lines 455-459 (patched)

Re: Review Request 66608: Improved support for move-only types in `hashmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66608/#review201108 --- Patch looks great! Reviews applied: [66608] Passed command:

Re: Review Request 66568: Dropped GROW and SHRINK volume if combined with other operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/#review201106 --- Fix it, then Ship it! src/master/master.cpp Lines 4965-4966

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

> On April 13, 2018, 12:27 a.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 1975 (patched) > > > > > > Hmm I wonder if we should just use a `double` here? Does the > > `Value.Scalar` type provide

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review201099 --- 3rdparty/libprocess/src/memory_profiler.cpp Lines 691-692

Re: Review Request 66608: Improved support for move-only types in `hashmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66608/#review201100 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66608: Improved support for move-only types in `hashmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66608/ --- Review request for mesos, Alexander Rukletsov and Michael Park. Repository:

Re: Review Request 63366: Added jemalloc release tarball and build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63366/ --- (Updated April 13, 2018, 12:03 p.m.) Review request for mesos, Alexander

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On April 6, 2018, 2:02 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/memory_profiler.hpp > > Lines 104-113 (patched) > > > > > > Does this class have to be nested? How about making it >

Re: Review Request 65462: Used the new 'route()' overload from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65462/ --- (Updated April 13, 2018, 11:14 a.m.) Review request for mesos, Alexander

Re: Review Request 65462: Used the new 'route()' overload from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65462/#review201097 --- Ship it! Ship It! - Alexander Rukletsov On April 5, 2018,

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review201096 --- Ship it! Ship It! - Alexander Rukletsov On Feb. 28, 2018,