> On April 6, 2018, 2:02 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/memory_profiler.hpp > > Lines 104-113 (patched) > > <https://reviews.apache.org/r/63368/diff/8/?file=1991764#file1991764line104> > > > > Does this class have to be nested? How about making it > > `jemalloc::State` in the same file? > > Benno Evers wrote: > None of them technically *need* to be nested, but it feels a bit cleaner > to not litter the `process`-namespace unnecessarily. It also seems more > consistent to me to treat all three classes as similar as possible.
Hence the suggestion to put it into the `jemalloc` namespace. > On April 6, 2018, 2:02 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/CMakeLists.txt > > Lines 47 (patched) > > <https://reviews.apache.org/r/63368/diff/8/?file=1991766#file1991766line47> > > > > Please add *.hpp as well. > > Benno Evers wrote: > I think if we do this, it should be part of a separate patch series - > right now, none of the public headers are included in the `CMakeLists.txt`. I'm not sure it has to be public, but okay. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review200633 ----------------------------------------------------------- On April 10, 2018, 2:39 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63368/ > ----------------------------------------------------------- > > (Updated April 10, 2018, 2:39 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This class exposes profiling functionality of jemalloc memory allocator > when it is detected to be the memory allocator of the current process. > > In particular, it gives developers an easy method to collect and > access heap profiles which report which pieces of code were > responsible for allocating memory. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c895d3ac7b9cc5ffd6c8b57ff24def866eb0213d > 3rdparty/libprocess/include/Makefile.am > cd2c3bc62df8de5b50ec2fa830b3e2634ba11e28 > 3rdparty/libprocess/include/process/memory_profiler.hpp PRE-CREATION > 3rdparty/libprocess/include/process/process.hpp > c36df991b6a2c120ab0562e8ff907f9fbf8630d1 > 3rdparty/libprocess/src/CMakeLists.txt > 0ce7dac5deea94623530820d173ce3ffe5b42ea4 > 3rdparty/libprocess/src/memory_profiler.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 9eb37465cd86f408d69f5f98fb76c4f4b93b9acd > > > Diff: https://reviews.apache.org/r/63368/diff/9/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
