Re: Review Request 67395: Fixed socket creation bug in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67395/#review204105 --- PASS: Mesos patch 67395 was successfully built and tested.

Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67365/#review204104 --- Ship it! Ship It! - Jiang Yan Xu On May 30, 2018, 11:57

Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.

> On May 30, 2018, 10:56 a.m., Jiang Yan Xu wrote: > > docs/upgrades.md > > Lines 445 (patched) > > > > > > Is it TCP specific? > > James Peach wrote: > Yes. I see and I found the word TCP in code comments. So

Re: Review Request 67395: Fixed socket creation bug in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67395/#review204102 --- Ship it! I really wish we'd been able to get rid of make

Review Request 67395: Fixed socket creation bug in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67395/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository:

Re: Review Request 67312: Updated mesos to use vector instead of list where possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67312/#review204099 --- Ship it! Ship It! - Chun-Hung Hsiao On May 31, 2018, 2:44

Re: Review Request 67312: Updated mesos to use vector instead of list where possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67312/ --- (Updated May 31, 2018, 2:44 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 67311: Updated await/collect to use vector instead of list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67311/ --- (Updated May 31, 2018, 2:44 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 67311: Updated await/collect to use vector instead of list.

> On May 30, 2018, 11:42 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp > > Lines 152-157 (original), 151-159 (patched) > > > > > > I'd prefer the following so we don't need to maintain

Re: Review Request 67312: Updated mesos to use vector instead of list where possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67312/#review204096 --- PASS: Mesos patch 67312 was successfully built and tested.

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67343/#review204093 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67365/#review204095 --- Patch looks great! Reviews applied: [67365] Passed command:

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67274/#review204094 --- Ship it! Ship It! - Jie Yu On May 30, 2018, 9:50 p.m.,

Re: Review Request 67312: Updated mesos to use vector instead of list where possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67312/#review204087 --- I did a quick look over all changed header files and left some

Re: Review Request 67342: Added `cgroups/all` into the agent flag `--isolation`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67342/#review204092 --- Could we also update the mesos-containerizer.md and have a new

Re: Review Request 67311: Updated await/collect to use vector instead of list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67311/#review204081 --- Fix it, then Ship it!

Re: Review Request 67310: Updated hashmap and LinkedHashMap to return vectors from values().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67310/#review204089 --- Ship it! Ship It! - Chun-Hung Hsiao On May 25, 2018, 3:04

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67274/#review204088 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204085 --- Ship it! - Eric Mumau On May 30, 2018, 8:30 p.m., John

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204084 --- src/tests/fetcher_tests.cpp Line 1015 (original)

Re: Review Request 67312: Updated mesos to use vector instead of list where possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67312/#review204061 --- Haven't made a complete review yet, but there're some compilation

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204083 --- PASS: Mesos patch 67066 was successfully built and tested.

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204082 --- Patch looks great! Reviews applied: [67286, 67287, 67394]

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

> On May 30, 2018, 8:17 p.m., Benjamin Mahler wrote: > > src/common/resources.cpp > > Lines 866-868 (original), 875-883 (patched) > > > > > > Can we reject 0? We were previously allowing it? > > Jie Yu wrote: >

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67274/ --- (Updated May 30, 2018, 11:50 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204078 --- PASS: Mesos patch 67394 was successfully built and tested.

Re: Review Request 67393: Windows: Ported io_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67393/#review204077 --- PASS: Mesos patch 67393 was successfully built and tested.

Re: Review Request 67310: Updated hashmap and LinkedHashMap to return vectors from values().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67310/#review204074 --- The description is not very clear to me. How about the following:

Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67365/#review204076 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67309: Updated Future::select to take any iterable type.

> On May 30, 2018, 7:48 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/libprocess/include/process/future.hpp > > Line 994 (original), 994 (patched) > > > > > > This patch seems to affect `process::discard` instead of >

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 30, 2018, 8:30 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67065/ --- (Updated May 30, 2018, 8:29 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67389: Windows: Implemented Windows IOCP async backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67389/#review204073 --- 3rdparty/libprocess/src/libwinio_impl.cpp Lines 38 (patched)

Re: Review Request 67389: Windows: Implemented Windows IOCP async backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67389/#review204071 --- 3rdparty/libprocess/src/libwinio_impl.cpp Lines 389 (patched)

Re: Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67384/#review204068 --- PASS: Mesos patch 67384 was successfully built and tested.

Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67365/#review204067 --- Ship it! Ship It! - Xudong Ni On May 30, 2018, 6:57 p.m.,

Re: Review Request 67309: Updated Future::select to take any iterable type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67309/#review204066 --- Fix it, then Ship it!

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

> On May 30, 2018, 6:17 p.m., Benjamin Mahler wrote: > > src/common/resources.cpp > > Lines 866-868 (original), 875-883 (patched) > > > > > > Can we reject 0? We were previously allowing it? > > Jie Yu wrote: >

Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li Li.

Review Request 67385: Windows: Added IOCP `HANDLE` to `WindowsFD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67385/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.

> On May 30, 2018, 5:56 p.m., Jiang Yan Xu wrote: > > docs/upgrades.md > > Lines 445 (patched) > > > > > > Is it TCP specific? Yes. - James --- This is an

Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67365/ --- (Updated May 30, 2018, 6:57 p.m.) Review request for mesos, Xudong Ni and

Review Request 67386: Added `io::prepare_async` and `io::is_async` functions for libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67386/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 67387: Updated Mesos code to use `io::prepare_async`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67387/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 67388: Moved: `io::internal::read/write` to separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67388/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 67389: Windows: Implemented Windows IOCP async backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67389/ --- Review request for mesos. Bugs: MESOS-8668, MESOS-8671 and MESOS-8672

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

> On May 30, 2018, 6:17 p.m., Benjamin Mahler wrote: > > src/common/resources.cpp > > Lines 866-868 (original), 875-883 (patched) > > > > > > Can we reject 0? We were previously allowing it? Yes, we debated that. I

Re: Review Request 67009: Added tests of resource provider registrar recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67009/#review204062 --- Ship it! Ship It! - Chun-Hung Hsiao On May 29, 2018, 8:54

Review Request 67390: Windows: Integrated libwinio with libprocess code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67390/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 67391: Windows: Added CMake `ENABLE_LIBWINIO` flag for Windows IOCP backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67391/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 67392: Windows: Made PipeLargeOutput test work with IOCP backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67392/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 67393: Windows: Ported io_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67393/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67384/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau,

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67274/#review204060 --- src/common/resources.cpp Lines 866-868 (original), 875-883

Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67365/#review204027 --- CHANGELOG Lines 8 (patched)

Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67365/#review204058 --- docs/upgrades.md Lines 445 (patched)

Re: Review Request 64384: Added new 'any' setting for reconfiguration_policy flag.

> On May 8, 2018, 11:36 p.m., Zhitao Li wrote: > > src/slave/slave.cpp > > Lines 6373-6375 (original), 6377-6379 (patched) > > > > > > I noticed that we do not refresh the checkpointed information of agent, > >

Re: Review Request 67322: Added Python 2 check for Python bindings when using `configure`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67322/#review204050 --- PASS: Mesos patch 67322 was successfully built and tested.

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67381/#review204049 --- Bad patch! Reviews applied: [67381, 67358, 67343, 67342, 67335]

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67381/#review204047 --- FAIL: Failed to apply the dependent review: 67335. Failed

Re: Review Request 67322: Added Python 2 check for Python bindings when using `configure`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67322/#review204045 --- configure.ac Line 2247 (original), 2247 (patched)

Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67381/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-7691

Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67358/ --- (Updated May 30, 2018, 9:10 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67358/ --- (Updated May 30, 2018, 9:06 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67342: Added `cgroups/all` into the agent flag `--isolation`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67342/ --- (Updated May 30, 2018, 9:04 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67343/ --- (Updated May 30, 2018, 9:05 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67318: Updated python.m4 to be compatible with Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67318/#review204046 --- PASS: Mesos patch 67318 was successfully built and tested. All

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67274/#review204043 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67318: Updated python.m4 to be compatible with Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67318/#review204042 --- Ship it! I'll tweak the description when committing (we still

Re: Review Request 67380: Replaced raw string literals with escaped C-style string literals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67380/#review204041 --- PASS: Mesos patch 67380 was successfully built and tested.

Re: Review Request 67288: White list fds that child processes can inherit in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67288/#review204039 --- Bad patch! Reviews applied: [67288, 67287, 67286] Failed

Review Request 67380: Replaced raw string literals with escaped C-style string literals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67380/ --- Review request for mesos, Alexander Rukletsov and James Peach. Repository:

Re: Review Request 67288: White list fds that child processes can inherit in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67288/#review204036 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 67377: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67377/#review204035 --- PASS: Mesos patch 67377 was successfully built and tested.

Re: Review Request 67288: White list fds that child processes can inherit in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67288/ --- (Updated May 30, 2018, 7:04 a.m.) Review request for mesos, Akash Gupta,

Review Request 67377: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67377/ --- Review request for mesos. Repository: mesos Description --- White list