Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review205604 --- Patch looks great! Reviews applied: [67773, 67444, 6]

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review205603 --- PASS: Mesos patch 6 was successfully built and tested.

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review205602 --- PASS: Mesos patch 67762 was successfully built and tested.

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review205601 --- Patch looks great! Reviews applied: [67761, 67762] Passed

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67791/#review205600 --- PASS: Mesos patch 67791 was successfully built and tested.

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67791/#review205599 --- Patch looks great! Reviews applied: [67791] Passed command:

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205597 --- Fix it, then Ship it! Thanks! Will get this committed shortly.

Re: Review Request 67788: Added regression test for archiver utility symlink extraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67788/#review205598 --- Ship it! Ship It! - Andrew Schwartzmeyer On June 29, 2018,

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/ --- (Updated June 29, 2018, 4:37 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 67762: Added minimum capability check during master recovery.

> On June 29, 2018, 2:33 p.m., Joseph Wu wrote: > > src/master/master.cpp > > Lines 406-418 (patched) > > > > > > Consider defining a `hash` and performing > > a hashset subtraction instead of these loops. Done.

Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67791/ --- Review request for mesos, Greg Mann and Jiang Yan Xu. Bugs: MESOS-8987

Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

> On June 29, 2018, 12:28 p.m., Joseph Wu wrote: > > src/master/registry_operations.hpp > > Lines 140-163 (patched) > > > > > > Instead of Add/Remove, how about an `UpdateMinimumCapability` operation > > instead? >

Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67761/ --- (Updated June 29, 2018, 3:48 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review205583 --- src/master/master.hpp Lines 443-444 (patched)

Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

> On June 29, 2018, 12:28 p.m., Joseph Wu wrote: > > src/master/registry_operations.hpp > > Lines 140-163 (patched) > > > > > > Instead of Add/Remove, how about an `UpdateMinimumCapability` operation > > instead? >

Re: Review Request 67788: Added regression test for archiver utility symlink extraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67788/#review205586 --- Patch looks great! Reviews applied: [67788] Passed command:

Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

> On June 29, 2018, 12:28 p.m., Joseph Wu wrote: > > src/master/registry.proto > > Lines 88 (patched) > > > > > > Could use a comment along the lines of: > > ``` > > The minimum set of

Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67761/ --- (Updated June 29, 2018, 1:25 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 67788: Added regression test for archiver utility symlink extraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67788/#review205582 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67761/#review205579 --- src/master/registry.proto Lines 88 (patched)

Review Request 67788: Added regression test for archiver utility symlink extraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67788/ --- Review request for mesos, Andrew Schwartzmeyer and Kapil Arya. Bugs:

Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67769/#review205578 --- Patch looks great! Reviews applied: [67769] Passed command:

Re: Review Request 67783: Removed unused variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67783/#review205577 --- Ship it! Thanks Ben! - Andrew Schwartzmeyer On June 29,

Re: Review Request 66823: Added per framework metrics for framework events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/#review205576 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67769/#review205575 --- PASS: Mesos patch 67769 was successfully built and tested.

Re: Review Request 66823: Added per framework metrics for framework events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/#review205574 --- Bad patch! Reviews applied: [66823, 67776, 66820, 66819, 66882]

Re: Review Request 66845: Made per-framework metrics count heartbeat events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66845/ --- (Updated June 29, 2018, 3:01 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 67786: Added per framework metrics for framework events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67786/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.

Re: Review Request 67783: Removed unused variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67783/#review205571 --- Ship it! Ship It! - Jan Schlicht On June 29, 2018, 2:02

Re: Review Request 67783: Removed unused variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67783/#review205570 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67769/ --- (Updated June 29, 2018, 10:40 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 65875: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65875/#review205569 --- Patch looks great! Reviews applied: [65875] Passed command:

Re: Review Request 67664: Fixed a race between `UPDATE_STATE` and `UPDATE_OPERATION_STATUS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67664/#review205568 --- Fix it, then Ship it! src/slave/slave.cpp Lines 8047-8048

Review Request 67783: Removed unused variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67783/ --- Review request for mesos, Andrew Schwartzmeyer and Jan Schlicht. Repository:

Re: Review Request 67501: Added authorization for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/#review205566 --- Ship it! Ship It! - Benjamin Bannier On June 28, 2018,

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205565 --- Patch looks great! Reviews applied: [67590] Passed command:

Re: Review Request 66822: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66822/#review205560 --- PASS: Mesos patch 66822 was successfully built and tested.