Re: Review Request 68127: Add `ROOT_INTERNET_CURL_UNPRIVILEGED_USER_CommandTaskRootfsWithVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68127/#review206719 --- Bad patch! Reviews applied: [68127, 68126, 68125, 68044, 68043,

Re: Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68123/#review206718 --- PASS: Mesos patch 68123 was successfully built and tested.

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review206714 --- Overall the approach looks good, didn't see any bugs, so just

Re: Review Request 68094: Add port mapping and network ports isolators sources to CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68094/#review206715 --- Patch looks great! Reviews applied: [67751, 68093, 68094]

Re: Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68134/#review206713 --- PASS: Mesos patch 68134 was successfully built and tested.

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review206711 --- A couple of comments on the benchmark information before looking

Re: Review Request 68122: Fixed couple of typos in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68122/ --- (Updated July 31, 2018, 5:08 p.m.) Review request for mesos and Benjamin

Review Request 68138: Added tests to ensure correct quota accounting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68138/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9099

Re: Review Request 67444: Made quota consumption tracking event-driven in the allocator.

> On July 5, 2018, 2:22 p.m., Benjamin Mahler wrote: > > Looks like a great cleanup! > > > > Persist tends to carry the connotation of writing something to durable > > storage. How about: > > > > ``` > > Made quota consumption tracking event-driven in the allocator. > > > > The

Re: Review Request 67444: Made quota consumption tracking event-driven in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67444/ --- (Updated July 31, 2018, 4:56 p.m.) Review request for mesos and Benjamin

Re: Review Request 67187: Tested per-framework task state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 31, 2018, 11:25 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206706 --- FAIL: Failed to apply the dependent review: 67931. Failed

Re: Review Request 68085: Extended a v1 test helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68085/#review206703 --- Ship it! Ship It! - Gastón Kleiman On July 27, 2018, 9:23

Re: Review Request 67187: Tested per-framework task state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/#review206701 --- Fix it, then Ship it! src/tests/master_tests.cpp Lines 9117

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review206696 --- Ship it! I'll clean up for Mesos

Re: Review Request 67930: Get tests ready for Windows UCR development.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67930/#review206695 --- Ship it! I'll clean up for Mesos

Re: Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67984/#review206694 --- Ship it! I'll make sure this gets committed with original

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206693 --- Ship it! I'll clean up for Mesos

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/#review206690 --- Ship it! Ship It! - Joerg Schad On July 31, 2018, 4:34

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/#review206689 --- Ship it! Tested sponsor email, it works! - Andrew

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206688 --- src/common/command_utils.cpp Line 186 (original), 186 (patched)

Re: Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67984/ --- (Updated July 31, 2018, 9:42 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67930: Get tests ready for Windows UCR development.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67930/ --- (Updated July 31, 2018, 9:42 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/ --- (Updated July 31, 2018, 9:41 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/ --- (Updated July 31, 2018, 9:41 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 68120: UI: Pull up the leader URL generation to a top-level function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68120/#review206685 --- PASS: Mesos patch 68120 was successfully built and tested.

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/#review206684 --- Ship it! src/slave/http.cpp Lines 1831-1833 (patched)

Re: Review Request 68114: Fixed a gRPC compilation issue for Clang.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68114/#review206681 --- Patch looks great! Reviews applied: [68091, 68074, 68092, 68114]

Re: Review Request 68103: Added an authorizer action for viewing of resource provider information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68103/#review206677 --- Ship it! Ship It! - Chun-Hung Hsiao On July 31, 2018, 10:19

Re: Review Request 68120: UI: Pull up the leader URL generation to a top-level function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68120/ --- (Updated July 31, 2018, 7:26 p.m.) Review request for mesos, Armand Grillet

Re: Review Request 67813: Added per-framework metrics for task states.

> On July 11, 2018, 11:48 p.m., Greg Mann wrote: > > src/master/master.hpp > > Line 2415 (original), 2415 (patched) > > > > > > NOTE: should review this patch to ensure that we don't have a > > double-counting bug

Re: Review Request 66870: Added per-framework metrics for suppressed roles.

> On July 25, 2018, 11:58 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 734-758 (original), 747-772 (patched) > > > > > > I'm not familiar with this, but it reads as wrong.

Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68134/ --- Review request for mesos, Benno Evers and Benjamin Mahler. Bugs: MESOS-9124

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

> On July 30, 2018, 4:39 p.m., Andrew Schwartzmeyer wrote: > > include/mesos/uri/fetcher.hpp > > Lines 101 (patched) > > > > > > I am not convinced we need to be passing this as a shared_ptr, wouldn't > > const-ref

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

> On July 30, 2018, 5:30 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > > Line 381 (original), 388 (patched) > > > > > > Did we change behavior here?

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/#review206670 --- PASS: Mesos patch 68111 was successfully built and tested.

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

> On July 31, 2018, 12:30 a.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > > Line 381 (original), 388 (patched) > > > > > > Did we change behavior here?

Re: Review Request 67916: Patched Google Test with upstream bugfix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67916/ --- (Updated July 31, 2018, 11:02 a.m.) Review request for mesos, Benjamin

Re: Review Request 68053: Call any function in a specified namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68053/ --- (Updated July 31, 2018, 5:30 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated July 31, 2018, 5:24 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated July 31, 2018, 5:22 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 67823: Added a master benchmark test for metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67823/ --- (Updated July 31, 2018, 5:22 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67916: Patched Google Test with upstream bugfix.

> On July 31, 2018, 10:27 a.m., Benjamin Bannier wrote: > > LGTM. I reopened https://reviews.apache.org/r/67916/#comment289263, using > > the original upstream patch would be great if possible. > > Andrew Schwartzmeyer wrote: > Ben, this did use the oiginal upsteam patch. I cloned the

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/#review20 --- Ship it! Ship It! - Greg Mann On July 31, 2018, 4:34 p.m.,

Re: Review Request 67916: Patched Google Test with upstream bugfix.

> On July 31, 2018, 1:27 a.m., Benjamin Bannier wrote: > > LGTM. I reopened https://reviews.apache.org/r/67916/#comment289263, using > > the original upstream patch would be great if possible. Ben, this did use the oiginal upsteam patch. I cloned the repo, checked out the tag we bundle, and

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/ --- (Updated July 31, 2018, 9:34 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review206662 --- PASS: Mesos patch 68132 was successfully built and tested.

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated July 31, 2018, 3:05 p.m.) Review request for mesos, Benno Evers and

Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- Review request for mesos, Benno Evers and Benjamin Mahler. Bugs: MESOS-9122

Review Request 68131: Added MasterPooledStateQuery_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/ --- Review request for mesos, Benno Evers and Benjamin Mahler. Bugs: MESOS-8975

Re: Review Request 68120: UI: Pull up the leader URL generation to a top-level function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68120/#review206653 --- Ship it! Ship It! - Armand Grillet On July 31, 2018, 2:40

Re: Review Request 68120: UI: Pull up the leader URL generation to a top-level function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68120/#review206652 --- src/webui/app/controllers.js Lines 515 (patched)

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/#review206651 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/ --- (Updated July 31, 2018, 12:19 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

> On July 31, 2018, 5:38 a.m., Chun-Hung Hsiao wrote: > > src/slave/http.cpp > > Lines 1818 (patched) > > > > > > Conventionally we only indent this by 4 extra spaces aligning with > > "return". Good catch, I

Re: Review Request 68103: Added an authorizer action for viewing of resource provider information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68103/ --- (Updated July 31, 2018, 12:19 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68127: Add `ROOT_INTERNET_CURL_UNPRIVILEGED_USER_CommandTaskRootfsWithVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68127/#review206649 --- FAIL: Failed to apply the dependent review: 66811. Failed

Review Request 68127: Add `ROOT_INTERNET_CURL_UNPRIVILEGED_USER_CommandTaskRootfsWithVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68127/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 68126: Added a test `ROOT_UNPRIVILEGED_USER_CommandTaskNoRootfsWithVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68126/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 68125: Granted container user permissions for DOCKER_VOLUME volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68125/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Re: Review Request 67916: Patched Google Test with upstream bugfix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67916/#review206647 --- Ship it! LGTM. I reopened

Re: Review Request 68094: Add port mapping and network ports isolators sources to CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68094/#review206645 --- Ship it! Ship It! - Benjamin Bannier On July 27, 2018, 9:11

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/#review206644 --- Fix it, then Ship it!

Re: Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68123/#review206643 --- PASS: Mesos patch 68123 was successfully built and tested.

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

> On July 30, 2018, 11:39 p.m., Andrew Schwartzmeyer wrote: > > src/uri/fetchers/docker.cpp > > Lines 1016-1017 (patched) > > > > > > Are we just skipping a failed blob here and trying to process the rest? > >