Re: Review Request 69224: Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`.

2018-10-31 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69224/#review210248 --- PASS: Mesos patch 69224 was successfully built and tested.

Review Request 69224: Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`.

2018-10-31 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69224/ --- Review request for mesos, Alexander Rukletsov and Benno Evers. Bugs:

Re: Review Request 69116: Added 'popen_tty' to test util functions for the new CLI.

2018-10-31 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review210246 --- Patch looks great! Reviews applied: [69116] Passed command:

Re: Review Request 69116: Added 'popen_tty' to test util functions for the new CLI.

2018-10-31 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review210245 --- PASS: Mesos patch 69116 was successfully built and tested.

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

2018-10-31 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review210238 --- PASS: Mesos patch 69010 was successfully built and tested. All

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

2018-10-31 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/#review210237 --- > This patch sets agent and/or resource provider ID operation

Re: Review Request 69035: Added a comment for `Resource.provider_id`.

2018-10-31 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69035/#review210236 --- Ship it! Ship It! - Meng Zhu On Oct. 15, 2018, 9:07 p.m.,

Re: Review Request 68806: Fixed outdated comments for mocking the secret generator.

2018-10-31 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68806/#review210235 --- Ship it! Ship It! - Meng Zhu On Sept. 21, 2018, 4:17 p.m.,

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

2018-10-31 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/ --- (Updated Oct. 31, 2018, 6:21 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

2018-10-31 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/#review210234 --- Patch looks great! Reviews applied: [69159, 69160, 68147, 69157,

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

2018-10-31 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/#review210227 --- PASS: Mesos patch 69163 was successfully built and tested.

Re: Review Request 68147: Added agent support to remove local resource providers.

2018-10-31 Thread Benjamin Bannier
> On Aug. 18, 2018, 12:29 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 7934 (patched) > > > > > > `OPERATION_GONE_BY_OPERATOR` is not a terminal state: > > > >

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

2018-10-31 Thread Benjamin Bannier
> On Oct. 25, 2018, 2:13 p.m., James DeFelice wrote: > > include/mesos/v1/scheduler/scheduler.proto > > Lines 147 (patched) > > > > > > For these "certain cases" does Mesos still expect an ACK? If so, that's > > a

Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

2018-10-31 Thread James DeFelice
> On Oct. 23, 2018, 2:51 p.m., James DeFelice wrote: > > include/mesos/mesos.proto > > Lines 2030 (patched) > > > > > > Referring to an implementation artifact like the "disk profile adaptor" > > seems strange in

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

2018-10-31 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review210216 --- Patch looks great! Reviews applied: [69009, 69085, 69010]