Re: Review Request 68785: Added jsonschema.py for managing json-based configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68785/#review211087 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/#review211085 --- PASS: Mesos patch 66649 was successfully built and tested.

Re: Review Request 68785: Added jsonschema.py for managing json-based configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68785/ --- (Updated Dec. 6, 2018, 5:56 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211084 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69474: Added tests for agent/executor heartbeating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69474/#review211083 --- PASS: Mesos patch 69474 was successfully built and tested.

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/ --- (Updated Dec. 6, 2018, 4:26 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 68654: Enabled isort for src/python/lib.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68654/#review211082 --- PASS: Mesos patch 68654 was successfully built and tested.

Re: Review Request 67185: Added request_protobuf to mesos.http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/#review211081 --- PASS: Mesos patch 67185 was successfully built and tested.

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/ --- (Updated Dec. 5, 2018, 6:21 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211080 --- src/master/metrics.hpp Lines 63 (patched)

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review211079 --- Ship it! Ship It! - Greg Mann On Dec. 5, 2018, 10:01 p.m.,

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/#review211078 --- Ship it! Ship It! - Greg Mann On Dec. 6, 2018, 1:24 a.m.,

Re: Review Request 69472: Refactored master and agent streaming connections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69472/#review211076 --- Fix it, then Ship it! Looks great, thanks Joseph!

Re: Review Request 67185: Added request_protobuf to mesos.http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/ --- (Updated Dec. 6, 2018, 1:28 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 69474: Added tests for agent/executor heartbeating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69474/ --- (Updated Dec. 5, 2018, 5:26 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 68654: Enabled isort for src/python/lib.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68654/ --- (Updated Dec. 6, 2018, 1:26 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

> On Dec. 5, 2018, 4:49 p.m., Greg Mann wrote: > > src/executor/executor.cpp > > Lines 797 (patched) > > > > > > Can we break `Minutes(30)` out into a common header somewhere so we can > > use it in the test as

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/ --- (Updated Dec. 5, 2018, 5:24 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69472: Refactored master and agent streaming connections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69472/ --- (Updated Dec. 5, 2018, 5:23 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69098/#review211073 --- PASS: Mesos patch 69098 was successfully built and tested.

Re: Review Request 69097: Added an allocator benchmark for quota performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69097/ --- (Updated Dec. 5, 2018, 5:16 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69097: Added an allocator benchmark for quota performance.

> On Nov. 2, 2018, 3:22 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 498-499 (patched) > > > > > > Why not make it even smaller (e.g. 1/4 or 1/10th) to be more > >

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211071 --- PASS: Mesos patch 69514 was successfully built and tested.

Re: Review Request 69474: Added tests for agent/executor heartbeating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69474/#review211056 --- Fix it, then Ship it! src/tests/executor_http_api_tests.cpp

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/#review211070 --- src/executor/executor.cpp Lines 797 (patched)

Re: Review Request 69505: Added an operation status update manager to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69505/#review211067 --- Fix it, then Ship it! src/master/master.cpp Lines 8539-8541

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/ --- (Updated Dec. 5, 2018, 4:24 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69472: Refactored master and agent streaming connections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69472/ --- (Updated Dec. 5, 2018, 4:23 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69463: Added HEARTBEAT events and calls for the executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69463/ --- (Updated Dec. 5, 2018, 4:15 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69098/#review211065 --- Fix it, then Ship it! Thanks for updating the test comment and

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211063 --- There is an effort to migrate all pull gauges in the master and

Re: Review Request 68984: Changed a benign warning log message in slave.cpp to info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68984/#review211062 --- Ship it! Ship It! - Chun-Hung Hsiao On Oct. 11, 2018, 6:12

Review Request 69514: Added gauge metric for operator event stream subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/ --- Review request for mesos, Benno Evers, Benjamin Mahler, Gastón Kleiman, and

Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance.

> On Nov. 2, 2018, 3:23 p.m., Benjamin Mahler wrote: > > Hm.. why is this one not just extending the one you added in the previous > > review? > > Meng Zhu wrote: > This benchmark compares quota vs. non-quota. For non-quota setting, there > will be no chopping. So for fair comparison,

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/ --- (Updated Dec. 5, 2018, 2:01 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69094: Renamed one allocator benchmark to be more descriptive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69094/ --- (Updated Dec. 5, 2018, 1:55 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/#review211060 --- src/resource_provider/storage/provider.cpp Lines 3093 (patched)

Re: Review Request 69513: Manually copy test reports to host fs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69513/#review211059 --- PASS: Mesos patch 69513 was successfully built and tested.

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

> On Dec. 4, 2018, 3:52 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 12109 (patched) > > > > > > This seems worthy of LOG(INFO) to me, WDYT? Sure, I can promote it. I don't have much of a

Re: Review Request 69513: Manually copy test reports to host fs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69513/#review211054 --- Ship it! Ship It! - James Peach On Dec. 5, 2018, 7:52 p.m.,

Review Request 69513: Manually copy test reports to host fs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69513/ --- Review request for mesos and James Peach. Repository: mesos Description

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

> On Dec. 4, 2018, 11:20 p.m., James DeFelice wrote: > > include/mesos/v1/mesos.proto > > Lines 2434 (patched) > > > > > > I'd like this part to be a bit more fleshed out: > > > > When `uuid` is set then

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

> On Dec. 4, 2018, 11:20 p.m., James DeFelice wrote: > > include/mesos/v1/mesos.proto > > Lines 2434 (patched) > > > > > > I'd like this part to be a bit more fleshed out: > > > > When `uuid` is set then

Re: Review Request 69344: Added volume gid manager to Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69344/#review211051 --- src/slave/volume_gid_manager/volume_gid_manager.cpp Lines 58

Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance.

> On Nov. 2, 2018, 10:23 p.m., Benjamin Mahler wrote: > > Hm.. why is this one not just extending the one you added in the previous > > review? > > Meng Zhu wrote: > This benchmark compares quota vs. non-quota. For non-quota setting, there > will be no chopping. So for fair comparison,

Re: Review Request 69493: Documented the `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69493/#review211048 --- Bad patch! Reviews applied: [69493, 69420, 69409, 68022, 68021,

Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance.

> On Nov. 2, 2018, 3:23 p.m., Benjamin Mahler wrote: > > Hm.. why is this one not just extending the one you added in the previous > > review? This benchmark compares quota vs. non-quota. For non-quota setting, there will be no chopping. So for fair comparison, quota setting should have no

Re: Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`.

> On Oct. 24, 2018, 5:22 p.m., Benjamin Mahler wrote: > > src/tests/allocator.hpp > > Lines 40-45 (patched) > > > > > > I think we some other create helpers lying around, e.g. createTask. Is > > this where these

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

> On Dec. 4, 2018, 11:20 p.m., James DeFelice wrote: > > include/mesos/v1/mesos.proto > > Lines 2434 (patched) > > > > > > I'd like this part to be a bit more fleshed out: > > > > When `uuid` is set then

Re: Review Request 68138: Added tests to ensure correct quota accounting.

> On Dec. 4, 2018, 12:51 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 1702 (patched) > > > > > > Maybe: QuotaAccountingReserveAllocatedResources? Sounds good. > On Dec.

Re: Review Request 68138: Added tests to ensure correct quota accounting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68138/ --- (Updated Dec. 5, 2018, 9:03 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

> On Dec. 4, 2018, 11:20 p.m., James DeFelice wrote: > > include/mesos/v1/mesos.proto > > Lines 2434 (patched) > > > > > > I'd like this part to be a bit more fleshed out: > > > > When `uuid` is set then

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

> On Dec. 4, 2018, 11:20 p.m., James DeFelice wrote: > > include/mesos/v1/mesos.proto > > Lines 2434 (patched) > > > > > > I'd like this part to be a bit more fleshed out: > > > > When `uuid` is set then

Re: Review Request 69493: Documented the `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69493/#review211040 --- FAIL: Failed to apply the dependent review: 67844. Failed

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

> On Dec. 5, 2018, 12:20 a.m., James DeFelice wrote: > > include/mesos/v1/mesos.proto > > Lines 2434 (patched) > > > > > > I'd like this part to be a bit more fleshed out: > > > > When `uuid` is set then

Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69162/ --- (Updated Dec. 5, 2018, 1 p.m.) Review request for mesos, Chun-Hung Hsiao,