Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review211258 --- configure.ac Lines 352 (patched)

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211263 --- LGTM. Have you tested this script by running locally?

Re: Review Request 69445: WIP: Moved `ReadOnlyHandler` into separate header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69445/#review211259 --- PASS: Mesos patch 69445 was successfully built and tested.

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

> On Dec. 1, 2018, 1:06 a.m., Joseph Wu wrote: > > src/tests/master_load_tests.cpp > > Lines 73-101 (patched) > > > > > > In terms of helpers, I added a replacement Authorizer: > > ``` > > // This authorizer

Re: Review Request 69445: WIP: Moved `ReadOnlyHandler` into separate header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69445/ --- (Updated Dec. 12, 2018, 8:54 p.m.) Review request for mesos. Changes ---

Re: Review Request 69422: WIP: Add new metric for cache hits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69422/ --- (Updated Dec. 12, 2018, 8:54 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/ --- (Updated Dec. 12, 2018, 8:53 p.m.) Review request for mesos, Alexander

Re: Review Request 69421: Exposed private data members for testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69421/ --- (Updated Dec. 12, 2018, 8:52 p.m.) Review request for mesos, Alexander

Re: Review Request 68795: Added deduplication for read-only master requests.

> On Nov. 30, 2018, 2:03 a.m., Joseph Wu wrote: > > src/master/http.cpp > > Lines 2392 (patched) > > > > > > Micro nit: s/Note that this is/NOTE: This is/ Counter-nit: Would be cool to have these as issues, just

Re: Review Request 68795: Added deduplication for read-only master requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68795/ --- (Updated Dec. 12, 2018, 8:48 p.m.) Review request for mesos, Alexander

Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler` members.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69071/ --- (Updated Dec. 12, 2018, 8:47 p.m.) Review request for mesos, Alexander

[GitHub] abudnik opened a new pull request #321: Fixed SIGINT handling in parallel test runner.

abudnik opened a new pull request #321: Fixed SIGINT handling in parallel test runner. URL: https://github.com/apache/mesos/pull/321 Previously, we were changing SIGINT signal handling by setting the `SIG_IGN` flag in every worker from the worker pool. Hence, sending SIGINT to

Re: Review Request 69557: Removed redundant handling of empty framework IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69557/#review211249 --- Can you clarify when the transition from "previously" to "now"

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211243 --- PASS: Mesos patch 69559 was successfully built and tested.

Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/#review211242 --- Ship it! Ship It! - Andrei Budnik On Dec. 11, 2018, 12:17

Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68163/#review211241 --- Fix it, then Ship it! Ship It!

Re: Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67997/#review211238 --- Ship it! Ship It! - Andrei Budnik On Dec. 11, 2018, 6:45

Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68162/#review211239 --- Ship it! Ship It! - Andrei Budnik On Dec. 11, 2018, 6:49

Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66815/#review211235 --- PASS: Mesos patch 66815 was successfully built and tested.

Re: Review Request 69479: Added the flag `--task_supplementary_groups` to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69479/#review211234 --- Ship it! Ship It! - Andrei Budnik On Dec. 11, 2018, 3:06

Re: Review Request 69478: Added `task_supplementary_groups` into `ContainerLaunchInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69478/#review211233 --- Ship it! Ship It! - Andrei Budnik On Dec. 10, 2018, 5:09

Re: Review Request 69342: Added an agent flag `--volume_gid_range`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69342/#review211232 --- Ship it! Ship It! - Andrei Budnik On Dec. 4, 2018, 2:43

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69544/#review211231 --- Ship it! Ship It! - Andrei Budnik On Dec. 11, 2018, 1:17

Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/ --- Review request for mesos, Andrew Schwartzmeyer, Dragos Schebesch, and Vinod

Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66815/ --- (Updated Dec. 12, 2018, 1:33 p.m.) Review request for mesos and Alexander

Re: Review Request 69557: Removed redundant handling of empty framework IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69557/#review211228 --- PASS: Mesos patch 69557 was successfully built and tested.

Re: Review Request 69398: Added validation for framework IDs.

> On Dec. 11, 2018, 11:10 p.m., Benjamin Mahler wrote: > > src/master/validation.cpp > > Line 510 (original), 510 (patched) > > > > > > add an extra newline? ? > On Dec. 11, 2018, 11:10 p.m., Benjamin Mahler

Review Request 69557: Removed redundant handling of empty framework IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69557/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9469

Re: Review Request 69398: Added validation for framework IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69398/ --- (Updated Dec. 12, 2018, 12:29 p.m.) Review request for mesos, Benjamin Mahler