----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69557/#review211228 -----------------------------------------------------------
PASS: Mesos patch 69557 was successfully built and tested. Reviews applied: `['69397', '69398', '69557']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2698/mesos-review-69557 - Mesos Reviewbot Windows On Dec. 12, 2018, 11:29 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69557/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2018, 11:29 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9469 > https://issues.apache.org/jira/browse/MESOS-9469 > > > Repository: mesos > > > Description > ------- > > We were previously treating empty framework IDs like unset framework > IDs and were maintaining dedicated handling for this case. > > Since we now reject empty framework IDs this handling is not required > anymore and removed in this patch. > > > Diffs > ----- > > src/master/master.cpp 3de0fd35cc815f4b5787ee2cb5e81f5059d7a47c > src/sched/sched.cpp e77a02951831a7e0c5d9a9068f8d014cb1478382 > > > Diff: https://reviews.apache.org/r/69557/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
