Re: Review Request 70363: Extended `CSIClientTest` to test the CSI v1 client wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70363/#review214356 --- PASS: Mesos patch 70363 was successfully built and tested.

Re: Review Request 70369: Fixed compile error with a built-in logrotate module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70369/#review214354 --- Ship it! - Joseph Wu On April 2, 2019, 4:56 a.m., Andrei

Re: Review Request 70325: Updated the master to allocate recovered orphan operation resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70325/#review214353 --- Patch looks great! Reviews applied: [70325] Passed command:

Re: Review Request 70374: Added tests for Sorter::allocationScalarQuantities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70374/#review214351 --- Patch looks great! Reviews applied: [70352, 70353, 70370, 70373,

Re: Review Request 70325: Updated the master to allocate recovered orphan operation resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70325/#review214350 --- Fix it, then Ship it! Looks good. The description needs to be

Re: Review Request 70374: Added tests for Sorter::allocationScalarQuantities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70374/#review214349 --- PASS: Mesos patch 70374 was successfully built and tested.

Re: Review Request 70325: Updated the master to allocate recovered orphan operation resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70325/ --- (Updated April 4, 2019, 12:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 70366: Added a unit test for Mesos containerizer image force pulling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70366/#review214348 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70325: Updated the master to allocate recovered orphan operation resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70325/ --- (Updated April 3, 2019, 11:16 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 70363: Extended `CSIClientTest` to test the CSI v1 client wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70363/#review214347 --- Patch looks great! Reviews applied: [70313, 70314, 70315, 70316,

Re: Review Request 70335: Sent FrameworkInfo to agents when applying operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70335/#review214345 --- src/slave/slave.cpp Lines 4516 (patched)

Re: Review Request 70302: Adjusted CSI v0 bundling and proto compilation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70302/#review214344 --- Ship it! Ship It! - Benjamin Bannier On April 3, 2019,

Re: Review Request 70360: Bundled CSI spec 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70360/ --- (Updated April 3, 2019, 9:17 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70302: Adjusted CSI v0 bundling and proto compilation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70302/ --- (Updated April 3, 2019, 9:12 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70381: Fixed MasterQuotaTest.AvailableResourcesSingleDisconnectedAgent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70381/#review214342 --- Patch looks great! Reviews applied: [70381] Passed command:

Re: Review Request 70381: Fixed MasterQuotaTest.AvailableResourcesSingleDisconnectedAgent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70381/#review214341 --- Ship it! Ship It! - Meng Zhu On April 3, 2019, 11:19 a.m.,

Re: Review Request 70353: Fixed quota enforcement in the presence of subrole reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70353/#review214340 --- Ship it! We probably want to benchmark this before landing? -

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70379/#review214339 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 70381: Fixed MasterQuotaTest.AvailableResourcesSingleDisconnectedAgent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70381/ --- Review request for mesos, Benjamin Bannier and Meng Zhu. Bugs: MESOS-9696

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70379/#review214338 --- Patch looks great! Reviews applied: [70377, 70378, 70379]

Review Request 70379: Added validation that the principal stays the same on resubscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70379/ --- Review request for mesos and Gastón Kleiman. Bugs: MESOS-2842

Re: Review Request 70378: Wrapped access to hashmaps in `frameworks.principals` and `authorized`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70378/ --- (Updated April 3, 2019, 4:01 p.m.) Review request for mesos and Gastón

Review Request 70378: Wrapped access to hashmaps in `frameworks.principals` and `authorized`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70378/ --- Review request for mesos and Gastón Kleiman. Bugs: MESOS-2842

Review Request 70377: Added tests to check that the framework cannot change its principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70377/ --- Review request for mesos and Gastón Kleiman. Bugs: MESOS-2842

Re: Review Request 70356: Mounted /proc properly a container shares pid namespace with its parent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70356/#review214335 --- Ship it! Ship It! - Andrei Budnik On April 2, 2019, 1:27

Re: Review Request 70288: Supported docker manifest v2 schema2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70288/#review214334 ---

Re: Review Request 70355: Switched to used `/proc/1/ns/pid` to test pid namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70355/#review214333 --- Ship it! Ship It! - Andrei Budnik On April 2, 2019, 1:26

Re: Review Request 70213: Added the `VolumeManager` interface to manage CSI volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70213/#review214332 --- Ship it! Ship It! - Benjamin Bannier On March 27, 2019,

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review214331 --- Ship it! Ship It! - Benjamin Bannier On March 28, 2019,

Re: Review Request 70288: Supported docker manifest v2 schema2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70288/#review214329 --- src/slave/containerizer/mesos/provisioner/docker/store.cpp Lines

Re: Review Request 70366: Added a unit test for Mesos containerizer image force pulling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70366/#review214326 --- Patch looks great! Reviews applied: [70287, 70354, 70365, 70288,

Re: Review Request 70363: Extended `CSIClientTest` to test the CSI v1 client wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70363/#review214325 --- PASS: Mesos patch 70363 was successfully built and tested.

Re: Review Request 70288: Supported docker manifest v2 schema2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70288/#review214324 --- src/slave/containerizer/mesos/provisioner/docker/store.cpp Lines

Re: Review Request 70288: Supported docker manifest v2 schema2.

> On April 2, 2019, 9:18 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > > Lines 548 (patched) > > > > > > Can we use `layerIds` in this for loop instead of

Re: Review Request 70288: Supported docker manifest v2 schema2.

> On April 2, 2019, 9:18 p.m., Qian Zhang wrote: > > src/uri/fetchers/docker.cpp > > Line 842 (original), 742 (patched) > > > > > > Is it possible that there is no `Content-Type`? Should we treat no > >

Re: Review Request 70288: Supported docker manifest v2 schema2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70288/ --- (Updated April 3, 2019, 1:01 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 70365: Added protobuf for docker v2 schema2 config path in 'Image'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70365/#review214321 --- Ship it! Ship It! - Qian Zhang On April 3, 2019, 3:17 p.m.,

Re: Review Request 70366: Added a unit test for Mesos containerizer image force pulling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70366/ --- (Updated April 3, 2019, 12:25 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 70291: Added gcr registry test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70291/ --- (Updated April 3, 2019, 12:18 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 70290: Fixed docker fetcher plugin unit test for v2s2 change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70290/ --- (Updated April 3, 2019, 12:18 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 70365: Added protobuf for docker v2 schema2 config path in 'Image'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70365/ --- (Updated April 3, 2019, 12:17 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 70288: Supported docker manifest v2 schema2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70288/ --- (Updated April 3, 2019, 12:17 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 70354: Refactored the UCR docker store to construct 'Image' proto at pullers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70354/ --- (Updated April 3, 2019, 12:17 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 70287: Added 'prettyjws' option to docker manifest V2 Schema1 accept header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70287/ --- (Updated April 3, 2019, 12:16 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 70289: Added a TODO for additional URLs support.

> On March 25, 2019, 1:09 a.m., Qian Zhang wrote: > > src/uri/fetchers/docker.cpp > > Lines 961-962 (patched) > > > > > > I think we can support for foreign(additional) urls for all platforms > > now. Actually in

Re: Review Request 70290: Fixed docker fetcher plugin unit test for v2s2 change.

> On March 25, 2019, 1:23 a.m., Qian Zhang wrote: > > src/tests/uri_fetcher_tests.cpp > > Lines 380 (patched) > > > > > > Can we add a comment to describe why the image used in this test is a > > v2 s2 image? new

Re: Review Request 70288: Supported docker manifest v2 schema2.

> On April 2, 2019, 6:18 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > > Lines 548 (patched) > > > > > > Can we use `layerIds` in this for loop instead of