Re: Review Request 70184: Fixed flakiness in 'RetryRpcWithExponentialBackoff'.

2019-05-07 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70184/#review215120 --- Ship it! Ship It! - Chun-Hung Hsiao On May 6, 2019, 9:48

Re: Review Request 70598: Added blogpost for 1.8.0 release.

2019-05-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70598/#review215098 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 70598: Added blogpost for 1.8.0 release.

2019-05-07 Thread Benno Evers
> On May 6, 2019, 5:45 p.m., Benjamin Mahler wrote: > > site/source/blog/2019-05-02-mesos-1-8-0-released.md > > Lines 16-49 (patched) > > > > > > These snippets should probably be in triple backtick sections to

Re: Review Request 70598: Added blogpost for 1.8.0 release.

2019-05-07 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70598/ --- (Updated May 7, 2019, 6:23 p.m.) Review request for mesos. Repository: mesos

Re: Review Request 70591: Added `struct RoleInfo` to track role reservations and framework IDs.

2019-05-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70591/#review215091 --- Patch looks great! Reviews applied: [70591] Passed command:

Review Request 70603: Removed empty string argument to sed.

2019-05-07 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70603/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 70591: Added `struct RoleInfo` to track role reservations and framework IDs.

2019-05-07 Thread Andrei Sekretenko
> On May 6, 2019, 7:38 p.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Line 543 (original), 556 (patched) > > > > > > Calling it `roles`? Agreed. Reverted the name 'roles', there is no

Re: Review Request 70534: Added tests for the UPDATE_FRAMEWORK call.

2019-05-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/#review215089 --- Patch looks great! Reviews applied: [70583, 70531, 70530, 70532,

Re: Review Request 70591: Added `struct RoleInfo` to track role reservations and framework IDs.

2019-05-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70591/ --- (Updated May 7, 2019, 1:58 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call.

2019-05-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated May 7, 2019, 1:09 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.

2019-05-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/ --- (Updated May 7, 2019, 1:06 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70534: Added tests for the UPDATE_FRAMEWORK call.

2019-05-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/ --- (Updated May 7, 2019, 12:13 p.m.) Review request for mesos and Benjamin

Re: Review Request 70530: Refactored FrameworkInfo updates for the UPDATE_FRAMEWORK call + race fix.

2019-05-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70530/ --- (Updated May 7, 2019, 11:49 a.m.) Review request for mesos and Benjamin

Re: Review Request 70531: Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.

2019-05-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70531/ --- (Updated May 7, 2019, 11:15 a.m.) Review request for mesos and Benjamin

Re: Review Request 70583: Eliminated copying 'suppressedRoles' and changed its type.

2019-05-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70583/ --- (Updated May 7, 2019, 11:09 a.m.) Review request for mesos and Benjamin

Re: Review Request 70583: Eliminated copying 'suppressedRoles' and changed its type.

2019-05-07 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70583/ --- (Updated May 7, 2019, 10:15 a.m.) Review request for mesos and Benjamin