Re: Review Request 71053: Added reserved, offered, allocated resources to the /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71053/#review216518 --- Patch looks great! Reviews applied: [71050, 71051, 71052, 71053]

Re: Review Request 71053: Added reserved, offered, allocated resources to the /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71053/#review216514 --- Ship it! See my comment in https://reviews.apache.org/r/71050/

Re: Review Request 70528: Updated release guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70528/#review216515 --- Fix it, then Ship it! docs/release-guide.md Lines 69

Re: Review Request 71050: Added Role::reserved, Role::allocated, Role::offered to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71050/#review216513 --- src/master/master.hpp Lines 2800-2801 (patched)

Re: Review Request 71052: Added a TODO to add resources breakdowns to v1 GET_ROLES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71052/#review216512 --- Ship it! Ship It! - Meng Zhu On July 10, 2019, 5:17 p.m.,

Re: Review Request 71051: Updated /role 'resources' field to strip 0 values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71051/#review216511 --- Ship it! Ship It! - Meng Zhu On July 10, 2019, 5:17 p.m.,

Re: Review Request 71050: Added Role::reserved, Role::allocated, Role::offered to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71050/#review216510 --- Ship it! Ship It! - Meng Zhu On July 10, 2019, 5:17 p.m.,

Review Request 71052: Added a TODO to add resources breakdowns to v1 GET_ROLES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71052/ --- Review request for mesos, Andrei Sekretenko and Meng Zhu. Repository: mesos

Review Request 71051: Updated /role 'resources' field to strip 0 values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71051/ --- Review request for mesos, Andrei Sekretenko and Meng Zhu. Repository: mesos

Review Request 71053: Added reserved, offered, allocated resources to the /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71053/ --- Review request for mesos, Andrei Sekretenko and Meng Zhu. Bugs: MESOS-8789

Review Request 71050: Added Role::reserved, Role::allocated, Role::offered to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71050/ --- Review request for mesos, Andrei Sekretenko and Meng Zhu. Bugs: MESOS-8789

Re: Review Request 71035: Added test to verify that Docker executor can override kill policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71035/#review216506 --- Patch looks great! Reviews applied: [71033, 71034, 71035]

Re: Review Request 71035: Added test to verify that Docker executor can override kill policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71035/#review216502 --- Ship it! Ship It! - Benno Evers On July 8, 2019, 6:28 p.m.,

Re: Review Request 71041: Added best-effort validation for DRAIN_AGENT master call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71041/#review216501 --- src/master/http.cpp Lines 3950 (patched)

Re: Review Request 70960: Added test for agent to leave draining state on its own.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70960/#review216500 --- Bad patch! Reviews applied: [70822, 70839, 70834, 70835, 70836,

Re: Review Request 71035: Added test to verify that Docker executor can override kill policy.

> On July 10, 2019, 3:27 p.m., Benno Evers wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 5250 (patched) > > > > > > The test itself looks good, but is it possible to run it with a

Re: Review Request 71034: Enabled the Docker executor to accept kill policy overrides.

> On July 10, 2019, 3:19 p.m., Benno Evers wrote: > > src/docker/executor.cpp > > Line 401 (original), 404 (patched) > > > > > > Should we print the override value here if it is provided? Good call; done. - Greg

Re: Review Request 71034: Enabled the Docker executor to accept kill policy overrides.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71034/ --- (Updated July 10, 2019, 8:17 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70903: Killed all tasks on the agent when draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70903/ --- (Updated July 10, 2019, 7:07 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70903: Killed all tasks on the agent when draining.

> On June 27, 2019, 1:36 p.m., Benjamin Bannier wrote: > > src/slave/slave.cpp > > Lines 1010-1016 (patched) > > > > > > What about custom executors? :/ > > > > I feel that in general we shouldn't make

Re: Review Request 70899: Refactored the agent's task-killing code.

> On July 2, 2019, 10:52 p.m., Joseph Wu wrote: > > src/slave/slave.cpp > > Lines 3673-3680 (original), 3673-3679 (patched) > > > > > > Due to splitting out the `killPendingTask`, this logic is now executed > >

Re: Review Request 70899: Refactored the agent's task-killing code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70899/ --- (Updated July 10, 2019, 6:59 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 71047: Added per-role suppress/revival to Java test framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71047/#review216493 --- Unsuppressing upon registering seems reasonable, but the

Re: Review Request 70528: Updated release guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70528/#review216492 --- Bad patch! Reviews applied: [70526, 70527, 70528] Failed

Re: Review Request 71048: Fixed the flaky RoleTest.RolesEndpointContainsConsumedQuota test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71048/#review216490 --- Ship it! Ship It! - Gilbert Song On July 10, 2019, 9:53

Re: Review Request 71048: Fixed the flaky RoleTest.RolesEndpointContainsConsumedQuota test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71048/#review216489 --- Ship it! Ship It! - Meng Zhu On July 10, 2019, 9:53 a.m.,

Review Request 71048: Fixed the flaky RoleTest.RolesEndpointContainsConsumedQuota test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71048/ --- Review request for mesos, Gilbert Song and Meng Zhu. Bugs: MESOS-9886

Re: Review Request 71043: Added quota consumption to the roles table in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71043/#review216488 --- Ship it! Nice! src/webui/app/roles/roles.html Line 17

Re: Review Request 71047: Added per-role suppress/revival to Java test framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71047/#review216487 --- Bad patch! Reviews applied: [71047] Failed command: ['bash',

Re: Review Request 70528: Updated release guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70528/#review216485 --- Ship it! - Vinod Kone On July 10, 2019, 2:58 p.m., Benno

Re: Review Request 70528: Updated release guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70528/#review216486 --- Ship it! Ship It! - Vinod Kone On July 10, 2019, 2:58 p.m.,

Re: Review Request 70527: Updated Bintray URL in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70527/#review216484 --- Ship it! Ship It! - Vinod Kone On April 23, 2019, 2:32

[GitHub] [mesos] bamarni commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT

bamarni commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT URL: https://github.com/apache/mesos/pull/340#issuecomment-510110404 @vinodkone : is this sentence a few lines above accurate then? > This call can only be made against containers that have been launched with

Re: Review Request 71035: Added test to verify that Docker executor can override kill policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71035/#review216483 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines

Re: Review Request 71034: Enabled the Docker executor to accept kill policy overrides.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71034/#review216482 --- Fix it, then Ship it! src/docker/executor.cpp Line 401

Re: Review Request 71033: Moved the Docker executor declaration into a header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71033/#review216481 --- Ship it! Ship It! - Benno Evers On July 8, 2019, 6:22 p.m.,

[GitHub] [mesos] vinodkone commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT

vinodkone commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT URL: https://github.com/apache/mesos/pull/340#issuecomment-510098398 IOSwitchboard is used by containers with or without TTY. s/launched with an associated IOSwitchboard/launched with TTYInfo in their

Re: Review Request 70528: Updated release guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70528/ --- (Updated July 10, 2019, 2:58 p.m.) Review request for mesos, Greg Mann, Joseph

[GitHub] [mesos] jdef commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT

jdef commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT URL: https://github.com/apache/mesos/pull/340#issuecomment-510070437 @vinodkone PTAL, feedback has been addressed This is an automated message from the

[GitHub] [mesos] bamarni commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT

bamarni commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT URL: https://github.com/apache/mesos/pull/340#issuecomment-510063838 Updated it, I've used `launched with an associated IOSwitchboard` instead of tty as it's what's being used elsewhere on the page.

[GitHub] [mesos] bamarni opened a new pull request #340: Documented EOF in ATTACH_CONTAINER_INPUT

bamarni opened a new pull request #340: Documented EOF in ATTACH_CONTAINER_INPUT URL: https://github.com/apache/mesos/pull/340 This documents how to indicate when EOF is reached on STDIN. See

[GitHub] [mesos] bamarni closed pull request #340: Documented EOF in ATTACH_CONTAINER_INPUT

bamarni closed pull request #340: Documented EOF in ATTACH_CONTAINER_INPUT URL: https://github.com/apache/mesos/pull/340 This is an automated message from the Apache Git Service. To respond to the message, please log on to

Review Request 71047: Added per-role suppress/revival to Java test framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71047/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9849

Re: Review Request 71043: Added quota consumption to the roles table in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71043/#review216475 --- Patch looks great! Reviews applied: [71031, 71032, 71043]