/scheduler-http-api.md
Thanks,
Andrei Sekretenko
otes here, since we're not showing a string
> > field:
> >
> > `Suppressed roles {"foo", "bar"} are not ...`
We don't need them; fixed this.
- Andrei
---
This is an automatically generated e-ma
/diff/4/
Changes: https://reviews.apache.org/r/72955/diff/3-4/
Testing
---
make check
Thanks,
Andrei Sekretenko
) {
> >
> > }
> > ```
Unfortunatley, there is no straightforward way to use a protobuf map with
`foreachkey()`.
This macro employs `std::get<>`, which is not overloaded for protobuf's
`MapPair`.
- Andrei
----------
> On Sept. 25, 2020, 10:26 p.m., Andrei Sekretenko wrote:
> > src/common/http.hpp
> > Lines 422-426 (patched)
> > <https://reviews.apache.org/r/72448/diff/3/?file=2236142#file2236142line423>
> >
> > Just `return approved(...)` ?
>
> Dong Zhu wro
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72956/#review222040
-------
On Oct. 14, 2020, 8:18 p.m., Andrei Sekretenko wrote:
>
>
ster.cpp
> > Lines 2588-2598 (original)
> > <https://reviews.apache.org/r/72955/diff/1/?file=2240633#file2240633line2589>
> >
> > Per above comment, did you mean to also move out the failover timeout
> > validation, which looks to be a similarly stateless vali
-
src/master/master.cpp d6d3ea7e27539a65b601783eca2ac4e3b688f188
src/master/validation.cpp 5b1bcb5207aac0553bf9c1a0d89525c835393ccb
Diff: https://reviews.apache.org/r/72964/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
,
Andrei Sekretenko
Thanks,
Andrei Sekretenko
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72955/#review222039
-------
On Oct. 12, 2020, 10:12 p.m., Andrei Sekretenko wrote:
>
>
d6d3ea7e27539a65b601783eca2ac4e3b688f188
src/tests/master/update_framework_tests.cpp
3f86573e8dfeea63fe99064f2137c61d901f4fc7
Diff: https://reviews.apache.org/r/72956/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
://reviews.apache.org/r/72955/diff/1/
Testing
---
make check
Thanks,
Andrei Sekretenko
check`
Thanks,
Andrei Sekretenko
`
Thanks,
Andrei Sekretenko
comment311095>
s/a absolute/an absolute/
- Andrei Sekretenko
On Oct. 8, 2020, 9:57 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
s will help avoid confusing users.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72922/#review221984
-------
On Oct
://reviews.apache.org/r/72922/diff/1-2/
Testing
---
`make check`
Thanks,
Andrei Sekretenko
/apache/mesos/MesosSchedulerDriver.java
4fdae338491709574775c52438e41d03b39917bd
Diff: https://reviews.apache.org/r/72922/diff/1/
Testing
---
`make check`
Thanks,
Andrei Sekretenko
(original), 12286 (patched)
<https://reviews.apache.org/r/72448/#comment311032>
Can you follow the same approach for obtaining `VIEW_ROLE` authorization as
well, here and below?
- Andrei Sekretenko
On July 23, 2020, 11
maps onto
`Ljava/util/Collection`
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72900/#review221954
-------
On Sept.
unless we switch to the new one.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72900/#review221954
-------
On Sept. 25, 2020, 5:48 p.m., Andrei Sekretenko wrote:
>
> ---
WIP
https://reviews.apache.org/r/72901 which will most likely be discarded) and
re-ran it.
Thanks,
Andrei Sekretenko
or options
default-constructable.
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72897/#review221952
-------
On Sept.
Mahler.
Repository: mesos
Description
---
Added `OfferConstraints` validity criteria into protobuf comments.
Diffs
-
include/mesos/scheduler/scheduler.proto
f70738ce5f4aeddb38c402130f953dcff1d43d6a
Diff: https://reviews.apache.org/r/72898/diff/2/
Testing
---
Thanks,
Andrei
/diff/2/
Changes: https://reviews.apache.org/r/72897/diff/1-2/
Testing
---
Thanks,
Andrei Sekretenko
f80d56c89d937b6a1b261202adefb37a1519bf0d
Diff: https://reviews.apache.org/r/72899/diff/2/
Changes: https://reviews.apache.org/r/72899/diff/1-2/
Testing
---
Thanks,
Andrei Sekretenko
t
`OfferConstraints`)?
- Andrei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72897/#review221926
---
On Sept. 22, 2020, 8:05 p.m., And
(original), 390 (patched)
<https://reviews.apache.org/r/72900/#comment310976>
Comments need to be synchronized with the final version of C++ ones:
https://reviews.apache.org/r/72874/
- Andrei Sekretenko
On Sept. 22, 2020, 8:09 p.m., Andrei Sekretenko
setting offer constraints to the Java example framework.
Diffs
-
src/examples/java/TestFramework.java 1dea79c0e5b76385bad74ded755911f4d1858112
Diff: https://reviews.apache.org/r/72901/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
e04916e055349ee287eb0c9327bc5f6d1e6caec3
Diff: https://reviews.apache.org/r/72900/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
441ebc10219bf3bd623fac2bb08945ea9deb7ea3
src/master/master.cpp fefa72d338384b6ccb1bcbbed7192713411035db
src/tests/master/offer_constraints_filter_tests.cpp
f80d56c89d937b6a1b261202adefb37a1519bf0d
Diff: https://reviews.apache.org/r/72897/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
)
<https://reviews.apache.org/r/72898/#comment310975>
I'll need to sync the final version into the V1 protobufs.
- Andrei Sekretenko
On Sept. 22, 2020, 8:03 p.m., Andrei Sekretenko wrote:
>
> ---
> This is an automatically g
---
Added `OfferConstraints` validity criteria into protobuf comments.
Diffs
-
include/mesos/scheduler/scheduler.proto
f70738ce5f4aeddb38c402130f953dcff1d43d6a
Diff: https://reviews.apache.org/r/72898/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
/72899/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
: https://reviews.apache.org/r/72874/diff/1-2/
Testing
---
Thanks,
Andrei Sekretenko
org/r/72887/diff/3/
Changes: https://reviews.apache.org/r/72887/diff/2-3/
Testing
---
`make check` on several platforms + tested the debug endpoint manually
Thanks,
Andrei Sekretenko
ever, I'm not 100% sure they never let allocator processes slip past the
test boundary, i.e. that all of them wait for the allocator to terminate in the
destructors/teardown.
- Andrei
---
This is an automatically generated e-
/master/allocator/mesos/hierarchical.hpp
225de160772fe689e07877c895800eb711f211b5
Diff: https://reviews.apache.org/r/72887/diff/2/
Changes: https://reviews.apache.org/r/72887/diff/1-2/
Testing
---
`make check` on several platforms + tested the debug endpoint manually
Thanks,
Andrei Sekretenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72874/#review221898
-------
On Sept. 16, 2020, 9:05 p.m., Andrei Sekretenko wrote:
>
>
/72885/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
://reviews.apache.org/r/72851/diff/3/
Changes: https://reviews.apache.org/r/72851/diff/2-3/
Testing
---
Thanks,
Andrei Sekretenko
that to compose an URL (like
`https://localhost:5050/hierarchical_allocator(0)/...`)
Diffs
-
src/master/allocator/mesos/hierarchical.hpp
7e1980ef74bb4138b83707de7698f1993cc21e41
Diff: https://reviews.apache.org/r/72887/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
,
Andrei Sekretenko
`ExamplesTest.JavaFramework` (see WIP
https://reviews.apache.org/r/72877/ which will most likely be discarded) and
re-ran it.
Thanks,
Andrei Sekretenko
ad8562
Diff: https://reviews.apache.org/r/72875/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
/update_framework_tests.cpp
d6c45f60cf50739aacbb507e99a5163a6cb3d1a0
src/tests/scheduler_driver_tests.cpp 63d7a3ba9a98d8c343324f5ad85f0b4d0cc033be
Diff: https://reviews.apache.org/r/72874/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
s in the future
What do you think?
- Andrei
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72851/#review221861
---
Benjamin Mahler wrote:
> > src/tests/master/update_framework_tests.cpp
> > Lines 921 (patched)
> > <https://reviews.apache.org/r/72840/diff/1/?file=2239297#file2239297line922>
> >
> > Any reason not to just implement the check?
Added '/fram
,
Andrei Sekretenko
---
Made `UpdateFrameworkTest.OfferConstraints` build constraints from JSON.
Diffs
-
src/tests/master/update_framework_tests.cpp
87bc3c7d23ea76118473d9a4ec3c77e7a9d5a97e
Diff: https://reviews.apache.org/r/72864/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
fer_constraints' are not valid: " +
> > filter.error());
> > }
> >
> > allocatorOptions.offerConstraintsFilter = std::move(*filter);
> > }
> > ```
agree, looks slightly clearer
- Andrei
-----
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72862/#review221856
---
Ship it!
Ship It!
- Andrei Sekretenko
On Sept. 10, 2020, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72861/#review221855
---
Ship it!
Ship It!
- Andrei Sekretenko
On Sept. 10, 2020, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72859/#review221853
---
Ship it!
Ship It!
- Andrei Sekretenko
On Sept. 10, 2020, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72860/#review221854
---
Ship it!
Ship It!
- Andrei Sekretenko
On Sept. 10, 2020, 11
(original), 35 (patched)
<https://reviews.apache.org/r/72858/#comment310922>
Maybe leave a comment that higher values lead to stuck/killed builds in the
ASF CI, most likely due to out of memory conditions?
- Andrei Sekretenko
On Sept. 10, 2020, 2:14 p.m., Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72857/#review221845
---
Ship it!
Ship It!
- Andrei Sekretenko
On Sept. 10, 2020, 2
nfigured dockerd will, at the very least,
leave a root-owned waste (`configure`, `Makefile.in`s and, potentially, the
whole `build`) in the sources dir.
- Andrei Sekretenko
On Sept. 10, 2020, 2:12 p.m., Vinod Kone wrote:
>
> ---
> This is an
/readonly_handler.cpp b1336f9aa849e826a78c3fe4bb83e3efeb186a31
Diff: https://reviews.apache.org/r/72851/diff/2/
Changes: https://reviews.apache.org/r/72851/diff/1-2/
Testing
---
Thanks,
Andrei Sekretenko
e99cc6b8e3610c8116e9b1feedc3d7ce9f954e1e
src/master/readonly_handler.cpp b1336f9aa849e826a78c3fe4bb83e3efeb186a31
Diff: https://reviews.apache.org/r/72851/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
` for the same set of actions
for the same handler.
Makes me think about moving `ObjectApprovers` creation into this method (not
100% trivial thanks to that specialization in `ObjectApprovers`).
Added a TODO.
- Andrei
---
This is an automatical
.
Diffs (updated)
-
src/master/http.cpp f34ea54ec48065f526327252aa10c6d917a96601
Diff: https://reviews.apache.org/r/72843/diff/2/
Changes: https://reviews.apache.org/r/72843/diff/1-2/
Testing
---
Thanks,
Andrei Sekretenko
f34ea54ec48065f526327252aa10c6d917a96601
Diff: https://reviews.apache.org/r/72843/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
87bc3c7d23ea76118473d9a4ec3c77e7a9d5a97e
Diff: https://reviews.apache.org/r/72842/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
488fe294e8bfe8e0c6fc23c88f06c0d41169b96d
Diff: https://reviews.apache.org/r/72841/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
87bc3c7d23ea76118473d9a4ec3c77e7a9d5a97e
Diff: https://reviews.apache.org/r/72840/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
3d1d4723d1bcef1880404007410bf00656399f10
src/master/master.cpp 5b5d5c359ca48eb0b4f5554fe7c91e928d4da08d
Diff: https://reviews.apache.org/r/72839/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
/master.hpp 3d1d4723d1bcef1880404007410bf00656399f10
src/master/master.cpp 5b5d5c359ca48eb0b4f5554fe7c91e928d4da08d
Diff: https://reviews.apache.org/r/72838/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
,
Andrei Sekretenko
heckpoint` is handled correctly might
implicitly depend on this; if we set it to false in `DEFAULT_FRAMEWORK_INFO`,
they might just stop doing anything meaningful.
- Andrei
---
This is an automatically generated e-mail. To r
://reviews.apache.org/r/72833/diff/2/
Changes: https://reviews.apache.org/r/72833/diff/1-2/
Testing
---
`support/mesos-gtest-runner.py src/mesos-tests`
Thanks,
Andrei Sekretenko
: https://reviews.apache.org/r/72822/diff/4/
Changes: https://reviews.apache.org/r/72822/diff/3-4/
Testing
---
Thanks,
Andrei Sekretenko
---
Thanks,
Andrei Sekretenko
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/72824/#review221784
-------
On Sept. 2, 2020, 2:08 p.m., Andrei Sekretenko wrote:
>
> ---
> This is an au
/diff/3/
Changes: https://reviews.apache.org/r/72825/diff/2-3/
Testing
---
`src/mesos-tests --gtest_filter='UpdateFrameworkTest.NoRedundantUpdates'
--gtest_repeat=300`
Thanks,
Andrei Sekretenko
,
Andrei Sekretenko
----------
On Sept. 2, 2020, 2:08 p.m., Andrei Sekretenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72824/
> ---
overloads for all of
> > our protobuf types, including (a broken) one for FrameworkInfo. Any
> > thoughts on why we might want to break the consistency here?
> >
> > Perhaps we should fix the existing one? For diffs, maybe we have a
> > bunch of `typeut
src/tests/resources_tests.cpp bd044310e297174155b88d5694641acd5df4cf59
Diff: https://reviews.apache.org/r/72833/diff/1/
Testing
---
`support/mesos-gtest-runner.py src/mesos-tests`
Thanks,
Andrei Sekretenko
://reviews.apache.org/r/72822/diff/3/
Changes: https://reviews.apache.org/r/72822/diff/2-3/
Testing
---
Thanks,
Andrei Sekretenko
ework update tests
> into a set of general-purpose methods.
>
>
> Diffs
> -
>
> src/common/protobuf_utils.hpp 0558249023b39863b4030ddbcfe5c83dc945570a
> src/common/protobuf_utils.cpp 723d85a8656e61f77ab99e5e63f844ec95303ff0
> src/tests/master/update_framework_tests.cpp
> 6346a4eaf2b6c70d1a7d5f32706e781436d36521
>
>
> Diff: https://reviews.apache.org/r/72822/diff/1/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
f222b43d1077d060c96daa81eb3b48b5bb76a05d
Diff: https://reviews.apache.org/r/72826/diff/1/
Testing
---
`src/mesos-tests --gtest_filter='*MasterAPITest.FrameworksEvent*'
--gtest_repeat=300`
Thanks,
Andrei Sekretenko
'
--gtest_repeat=300`
Thanks,
Andrei Sekretenko
-
src/master/master.cpp 4428985902512eea1c97205f04a4fed6c16d494e
Diff: https://reviews.apache.org/r/72824/diff/1/
Testing
---
Thanks,
Andrei Sekretenko
for removing redundant updates and broadcasts
when UPDATE_FRAMEWORK leaves `FrameworkInfo` the same.
Diffs
-
src/tests/master/update_framework_tests.cpp
6346a4eaf2b6c70d1a7d5f32706e781436d36521
Diff: https://reviews.apache.org/r/72823/diff/1/
Testing
---
Thanks,
Andrei
/protobuf_utils.hpp 0558249023b39863b4030ddbcfe5c83dc945570a
src/common/protobuf_utils.cpp 723d85a8656e61f77ab99e5e63f844ec95303ff0
src/tests/master/update_framework_tests.cpp
6346a4eaf2b6c70d1a7d5f32706e781436d36521
Diff: https://reviews.apache.org/r/72822/diff/1/
Testing
---
Thanks,
Andrei
/
Testing
---
Thanks,
Andrei Sekretenko
decoupled into a different header from
> > OfferConstraintsFilter? Is it to minimize the stuff pulled into master.hpp?
> > If so, not sure if that's worth the extra indirection?
>
> Andrei Sekretenko wrote:
> Right at this moment, this also helps minimize things that are kept in
` constructor should be made
`explicit`...
- Andrei
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72786/#review221727
---
84a1e917a52d0b98f979e454c2b982c6402b0176
Diff: https://reviews.apache.org/r/72786/diff/8/
Changes: https://reviews.apache.org/r/72786/diff/7-8/
Testing
---
Thanks,
Andrei Sekretenko
4428985902512eea1c97205f04a4fed6c16d494e
src/tests/master/offer_constraints_filter_tests.cpp
84a1e917a52d0b98f979e454c2b982c6402b0176
Diff: https://reviews.apache.org/r/72786/diff/7/
Changes: https://reviews.apache.org/r/72786/diff/6-7/
Testing
---
Thanks,
Andrei Sekretenko
> On Aug. 24, 2020, 9:30 p.m., Benjamin Mahler wrote:
> > Hm.. is it possible to have a simpler patch that avoids the factory and
> > instead passes the flags through the creation path?
>
> Andrei Sekretenko wrote:
> This is possible; however, I would argue th
re this out? Just from your own testing?
> >
> > What about with clang? Same result?
> >
> > How much faster? Is it worth bothering?
>
> Andrei Sekretenko wrote:
> Around 10% of the allocation loop time in a rather pecualr, although not
/diff/5-6/
Testing
---
Thanks,
Andrei Sekretenko
include/mesos/v1/scheduler/scheduler.proto
08fb10a146e0b57896a0cb098178a40e618df392
Diff: https://reviews.apache.org/r/72784/diff/4/
Changes: https://reviews.apache.org/r/72784/diff/3-4/
Testing
---
Thanks,
Andrei Sekretenko
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/72786/#review221697
---
On Aug. 24, 2020, 7:46 p.m., Andrei Sekretenko wrote:
>
> ---
> This is an automa
raints on a string attribute equality.
>
>
> Diffs
> -
>
> src/tests/master/offer_constraints_filter_tests.cpp
> f88e2011bc510323344ffe58fd550b7683242950
>
>
> Diff: https://reviews.apache.org/r/72776/diff/4/
>
>
> Testing
> ---
>
> `support/mesos-gtest-runner.py src/mesos-tests`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
/diff/4-5/
Testing
---
Thanks,
Andrei Sekretenko
1 - 100 of 728 matches
Mail list logo
