e740e840c38381bafd7a1a7fcde5f963832ac1fb
3rdparty/libprocess/src/tests/http_tests.cpp
97aaf3ed3d4fab6d717d5c9b6d12402562ac6b46
3rdparty/libprocess/src/tests/ssl_tests.cpp
6b8496aeeed79ae1bd39d7013f4f403b248fdd4c
Diff: https://reviews.apache.org/r/70885/diff/1/
Testing
---
Thanks,
Benno
/pid.hpp
9f09ab46fa3ceaeac09b0fbf9f532728c4ed2d7a
3rdparty/libprocess/src/process.cpp 799666f03d6a78708aa9336c2dd04bc9b5023aa0
Diff: https://reviews.apache.org/r/70884/diff/1/
Testing
---
Thanks,
Benno Evers
29a1bf71c1df9d80370455a6269ecea0ec4193b0
3rdparty/libprocess/src/posix/poll_socket.cpp
74acb6942682a9d9626df81b303eba0a1c24ecf7
3rdparty/libprocess/src/windows/poll_socket.cpp
565b0088dc2b270193e615655f57f48419eb2c12
Diff: https://reviews.apache.org/r/70883/diff/1/
Testing
---
Thanks,
Benno Evers
for operators.
Diffs (updated)
-
docs/ssl.md ce5058896144aa7824986d40d996899d92cb7c1c
Diff: https://reviews.apache.org/r/70810/diff/2/
Changes: https://reviews.apache.org/r/70810/diff/1-2/
Testing
---
Thanks,
Benno Evers
/libprocess/src/tests/ssl_tests.cpp
6b8496aeeed79ae1bd39d7013f4f403b248fdd4c
Diff: https://reviews.apache.org/r/70748/diff/4/
Changes: https://reviews.apache.org/r/70748/diff/3-4/
Testing (updated)
---
So far, mostly manual testing.
Thanks,
Benno Evers
see if
this is enough in principle.
Before we actually commit this, we should also change the implication during
flag initialization (i.e. `require_cert` => `verify_cert`) and look at the
other usages of verify/require.
- Benno
-----
29a1bf71c1df9d80370455a6269ecea0ec4193b0
3rdparty/libprocess/src/tests/ssl_tests.cpp
6b8496aeeed79ae1bd39d7013f4f403b248fdd4c
Diff: https://reviews.apache.org/r/70748/diff/3/
Changes: https://reviews.apache.org/r/70748/diff/2-3/
Testing
---
Thanks,
Benno Evers
tion as a separate review at
https://reviews.apache.org/r/70810/
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70748/#review215616
-----
---
Thanks,
Benno Evers
Diff: https://reviews.apache.org/r/70777/diff/1/
Testing
---
Some tests are failing, hence WIP status :/
Thanks,
Benno Evers
Description
---
WIP: Unit tests for hostname validation.
Diffs
-
3rdparty/libprocess/src/tests/ssl_tests.cpp
6b8496aeeed79ae1bd39d7013f4f403b248fdd4c
Diff: https://reviews.apache.org/r/70797/diff/1/
Testing
---
Thanks,
Benno Evers
Description
---
WIP: Updated SSL docs to include new libprocess flag.
Diffs
-
docs/ssl.md ce5058896144aa7824986d40d996899d92cb7c1c
Diff: https://reviews.apache.org/r/70795/diff/1/
Testing
---
Thanks,
Benno Evers
Description
---
WIP: Fix Mesos unit tests after API change.
Diffs
-
src/tests/master_tests.cpp 097f1b77a59e29c6690210773d1556ebf2bb701e
Diff: https://reviews.apache.org/r/70796/diff/1/
Testing
---
Thanks,
Benno Evers
seemed to be unaware
that calling this would involve a network operation, I'd say renaming is in
principle a good idea.
- Benno Evers
On June 6, 2019, 11:15 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail.
97aaf3ed3d4fab6d717d5c9b6d12402562ac6b46
3rdparty/libprocess/src/tests/ssl_tests.cpp
6b8496aeeed79ae1bd39d7013f4f403b248fdd4c
Diff: https://reviews.apache.org/r/70749/diff/2/
Changes: https://reviews.apache.org/r/70749/diff/1-2/
Testing (updated)
---
Todo!
Thanks,
Benno Evers
separate review later in the chain.
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70748/#review215616
-------
O
3rdparty/libprocess/src/tests/ssl_tests.cpp
6b8496aeeed79ae1bd39d7013f4f403b248fdd4c
Diff: https://reviews.apache.org/r/70748/diff/2/
Changes: https://reviews.apache.org/r/70748/diff/1-2/
Testing
---
Thanks,
Benno Evers
Does it mean that hostname validation with the help of openssl is not
> > supported for clients?
>
> Benno Evers wrote:
> I'm not sure I understand your question? This comment is basically
> talking about the issue addressed in the follow-up review in the chain.
>
>
we can use
> > https://www.openssl.org/docs/manmaster/man3/SSL_get_verify_result.html in
> > combination with `SSL_VERIFY_NONE` to mimic the OR behaviour we currently
> > have? Another question is whether we need to support OR at all.
>
> Benno Evers wrote:
> We
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70749/#review215673
-------
On May 31, 2019, 3:47 p.m., Benno Evers wrote:
>
> ---
> This is an automatically
ecurity as intended
until this TODO is fixed.
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70749/#review215673
-------
,
Benno Evers
---
Thanks,
Benno Evers
for going the extra mile and improving our unit
test suite!
src/tests/master/mock_master_api_subscriber.cpp
Lines 80 (patched)
<https://reviews.apache.org/r/70671/#comment302370>
Nit: No `.` at the end of log messages.
(same for the messages below)
- Benno Evers
On May 29, 2019
6b8496aeeed79ae1bd39d7013f4f403b248fdd4c
Diff: https://reviews.apache.org/r/70748/diff/1/
Testing
---
Thanks,
Benno Evers
/diff/1/
Testing
---
Thanks,
Benno Evers
e7dbd67913fa8e7fbbf60dee428e7e38895f86ce
3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp
29a1bf71c1df9d80370455a6269ecea0ec4193b0
Diff: https://reviews.apache.org/r/70749/diff/1/
Testing
---
Thanks,
Benno Evers
e7dbd67913fa8e7fbbf60dee428e7e38895f86ce
3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp
29a1bf71c1df9d80370455a6269ecea0ec4193b0
3rdparty/libprocess/src/tests/ssl_tests.cpp
6b8496aeeed79ae1bd39d7013f4f403b248fdd4c
Diff: https://reviews.apache.org/r/70748/diff/1/
Testing
---
Thanks,
Benno Evers
,
Benno Evers
cts connections that
don't present a certificate.
Thanks,
Benno Evers
Description
---
Improved log messages for SSL configuration.
Diffs
-
3rdparty/libprocess/src/openssl.cpp 789bef61b4bb38fa83ab2a016fd780ec97a8e6b7
Diff: https://reviews.apache.org/r/70689/diff/1/
Testing
---
No.
Thanks,
Benno Evers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70653/#review215298
---
Ship it!
Ship It!
- Benno Evers
On May 16, 2019, 9:47 a.m
this review, I went ahead and
committed it including the changes proposed by @jdef.
- Benno Evers
On March 25, 2019, 3:09 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
on the updated URL to verify it does not return a '404 File Not Found'.
Thanks,
Benno Evers
ers are easier to understand.
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70598/#review215065
---
Description
---
Added blogpost for 1.8.0 release.
Diffs (updated)
-
site/source/blog/2019-05-02-mesos-1-8-0-released.md PRE-CREATION
Diff: https://reviews.apache.org/r/70598/diff/2/
Changes: https://reviews.apache.org/r/70598/diff/1-2/
Testing
---
Thanks,
Benno Evers
---
Thanks,
Benno Evers
blogpost for 1.8.0 release.
Diffs
-
site/source/blog/2019-05-02-mesos-1-8-0-released.md PRE-CREATION
Diff: https://reviews.apache.org/r/70598/diff/1/
Testing
---
Thanks,
Benno Evers
account.
Diffs
-
support/packaging/Jenkinsfile 7446b2b8b88df6c146f4415b06dda227ca8ce631
support/packaging/bintray.sh 4f1795f14b078e8eebe95aaa40cf860d6d19ee97
Diff: https://reviews.apache.org/r/70573/diff/1/
Testing
---
Not sure how to test jenkins pipelines :/
Thanks,
Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70563/#review214955
---
Ship it!
Ship It!
- Benno Evers
On April 29, 2019, 6:43 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70559/#review214953
---
Ship it!
Ship It!
- Benno Evers
On April 26, 2019, 8:13 p.m
uot;LIBPROCESS_SSL_ENABLE_TLS_V1_2",
- "LIBPROCESS_SSL_ENABLE_TLS_V1_3"
+// On some platforms, we need to build against OpenSSL versions that
+// do not support TLS 1.3 yet.
+#ifdef SSL_OP_NO_TLSv1_3
+ "LIBPROCESS_SSL_ENABLE_TLS_V1_3",
+#endif
};
```
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70546/#review214920
---
Ship it!
Ship It!
- Benno Evers
On April 25, 2019, 8:43 p.m
be done, or at least provide
a master flag to turn off this behaviour for operators who are not in a
position to easily fix their frameworks.
- Benno Evers
On April 24, 2019, 3:28 a.m., Joseph Wu wrote:
>
> ---
> This is an auto
, this seems to be leaning very
heavily on the fact that `Owned` is in fact `shared_ptr`.
- Benno Evers
On April 22, 2019, 11:57 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70518/#review214819
---
Ship it!
Ship It!
- Benno Evers
On April 22, 2019, 11:45
Description
---
Updated Bintray URL in docs.
Diffs
-
docs/binary-packages.md 462e732246aa3f3a69f243e512fa73012341
Diff: https://reviews.apache.org/r/70527/diff/1/
Testing
---
Opened the modified links in a browser to ensure no typos.
Thanks,
Benno Evers
and then
update this review once I know what needs to be done.
Thanks,
Benno Evers
,
Benno Evers
---
Thanks,
Benno Evers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70466/#review214631
---
Ship it!
Ship It!
- Benno Evers
On April 12, 2019, 11:40
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70387/#review214581
---
Ship it!
Ship It!
- Benno Evers
On April 10, 2019, 1:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/#review214580
---
Ship it!
Ship It!
- Benno Evers
On April 11, 2019, 10:11
> On April 8, 2019, 5:26 p.m., Benno Evers wrote:
> > src/examples/operation_feedback_framework.cpp
> > Lines 329 (patched)
> > <https://reviews.apache.org/r/70412/diff/1/?file=2137761#file2137761line333>
> >
> > Is this always true even in
this should be camelCase?
- Benno Evers
On April 5, 2019, 11:35 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70386/#review214413
---
Ship it!
Ship It!
- Benno Evers
On April 5, 2019, 8:27 a.m
,
Benno Evers
it:
https://reviews.apache.org/r/70281/#review214110
---
On March 22, 2019, 4:57 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
min | 3392 | 0 | 0
FLAG=SSL,label=mesos-ec2-ubuntu-14.04 | 19 min | 3395 | 0 | 0
FLAG=SSL,label=mac | 9 min 17 sec | 2788 | 0 | 0
FLAG=Plain,label=mesos-ec2-centos-7 | 20 min | 3316 | 0 | 0
Thanks,
Benno Evers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70334/#review214203
---
Ship it!
Ship It!
- Benno Evers
On March 28, 2019, 6:27 p.m
ttps://reviews.apache.org/r/70117/#review213732
---
On March 27, 2019, 4:41 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
://reviews.apache.org/r/70117/diff/7/
Changes: https://reviews.apache.org/r/70117/diff/6-7/
Testing
---
Thanks,
Benno Evers
-framework metrics
> > added? I'm fine with not adding them, but this comment seems to be
> > incorrect?
>
> Benno Evers wrote:
> They're not added in this review because they already exist :) See line
> 816-836 inside `FrameworkMetrics::FrameworkMetrics()`.
>
> Greg
src/master/metrics.cpp 4dd73fb18a06ce8f75c4c1435dba84ade123bee9
Diff: https://reviews.apache.org/r/70116/diff/6/
Changes: https://reviews.apache.org/r/70116/diff/5-6/
Testing
---
Thanks,
Benno Evers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70323/#review214114
---
Ship it!
- Benno Evers
On March 27, 2019, 4:21 p.m
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70116/#review213734
-------
On March 26, 2019, 5:56 p.m., Benno Evers wrote:
>
> ---
>
hould probably verify before this call is sent that the list of
> > operations in the call is not empty.
We also want to accept when the list of operations is empty, to decline the
offer. I'll add a comment to clarify.
- Benno
---
o you can have a cluster with 0 operations, but the metric
> > for pending operations might be non-zero.
>
> Benno Evers wrote:
> Hm, good question. I think the only ways a slave gets removed while it
> still has operations pending is by either being marked gone, or bec
4495e65b6bb11f7236335a702c4f61e7c3f9b0aa
src/master/metrics.cpp 4dd73fb18a06ce8f75c4c1435dba84ade123bee9
Diff: https://reviews.apache.org/r/70116/diff/5/
Changes: https://reviews.apache.org/r/70116/diff/4-5/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/70282/diff/2-3/
Testing
---
Thanks,
Benno Evers
at github:
https://github.com/apache/mesos/pull/327
Thanks,
Benno Evers
microseconds to the LogSink interface.
Diffs
-
3rdparty/glog-0.4.0.patch PRE-CREATION
Diff: https://reviews.apache.org/r/70299/diff/1/
Testing
---
Thanks,
Benno Evers
os.path.exists() with a proper check of automake flags.
Diffs
-
src/python/native_common/ext_modules.py.in
eee56a94705b561794b1ee8e495701c0bba695f1
Diff: https://reviews.apache.org/r/70297/diff/1/
Testing
---
Thanks,
Benno Evers
/entrypoint.sh 0d584b8ee0606075d8de7c314395b92c0fe248eb
Diff: https://reviews.apache.org/r/70298/diff/1/
Testing
---
Thanks,
Benno Evers
/python/native_common/ext_modules.py.in
eee56a94705b561794b1ee8e495701c0bba695f1
support/mesos-tidy/entrypoint.sh 0d584b8ee0606075d8de7c314395b92c0fe248eb
Diff: https://reviews.apache.org/r/70296/diff/1/
Testing
---
Thanks,
Benno Evers
ab7f6c2027d937038ee70145705b699c4fb8f05c
Diff: https://reviews.apache.org/r/70282/diff/2/
Changes: https://reviews.apache.org/r/70282/diff/1-2/
Testing
---
Thanks,
Benno Evers
, the comment seems to be more
confusing than clearing things up.
Diffs
-
src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320
Diff: https://reviews.apache.org/r/70294/diff/1/
Testing
---
Thanks,
Benno Evers
.
Diffs (updated)
-
src/master/master.hpp ca2f8b147a3e17a0801b4c3e31ec1e995faebc07
src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320
Diff: https://reviews.apache.org/r/70185/diff/2/
Changes: https://reviews.apache.org/r/70185/diff/1-2/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/70293/diff/1/
Testing
---
Not a functional change.
Thanks,
Benno Evers
src/v1/mesos.cpp 704ad7697689d9cb21d6ed2675ac6c0044ce18c8
Diff: https://reviews.apache.org/r/70281/diff/1/
Testing
---
Thanks,
Benno Evers
/examples/operation_feedback_framework.cpp PRE-CREATION
src/tests/CMakeLists.txt ab7f6c2027d937038ee70145705b699c4fb8f05c
Diff: https://reviews.apache.org/r/70282/diff/1/
Testing
---
Thanks,
Benno Evers
-
3rdparty/stout/include/stout/iterable_queue.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/70262/diff/1/
Testing
---
Will add a unit test if we have consensus to move forward with adding this.
Thanks,
Benno Evers
ode goes through camelCase
interfaces (i.e. `Option::isSome()`, `Future::isReady()`) so in general it
would be better to update the style guide to reflect this reality.
- Benno Evers
On March 20, 2019, 9:48 a.m., Benjamin Bannier wr
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70250/#review213827
---
Ship it!
- Benno Evers
On March 20, 2019, 9:56 a.m
s.
Fixed this while merging.
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70206/#review213805
---
On March
75711edbaf46797e5eb54ba720ea11cf3de81522
3rdparty/libprocess/src/metrics/metrics.cpp
623d44adbe838f995ddbe89ee26f5bcc9c600be5
Diff: https://reviews.apache.org/r/70211/diff/1/
Testing
---
Thanks,
Benno Evers
d.
Diffs
-
3rdparty/libprocess/src/process.cpp 124836472313721a5dbfe4b1ca55f0da3cecd66b
Diff: https://reviews.apache.org/r/70210/diff/1/
Testing
---
Thanks,
Benno Evers
this
behaviour, or remove the `operations_unreachable` metric altogether.
What do you think?
- Benno
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70116/#review213632
b2f22cd4db223d167aa35109cd8de6df82ed1f4d
Diff: https://reviews.apache.org/r/70156/diff/3/
Changes: https://reviews.apache.org/r/70156/diff/2-3/
Testing
---
Thanks,
Benno Evers
lly generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213641
-------
On March 13, 2019, 4:01 p.m., Benno Evers wrote:
>
> ---
>
/
Changes: https://reviews.apache.org/r/70117/diff/5-6/
Testing
---
Thanks,
Benno Evers
://reviews.apache.org/r/70206/diff/1/
Testing
---
Thanks,
Benno Evers
/diff/5/
Changes: https://reviews.apache.org/r/70117/diff/4-5/
Testing
---
Thanks,
Benno Evers
7945384867f26fa15dc734a235ae509d5d6d350f
Diff: https://reviews.apache.org/r/70117/diff/4/
Changes: https://reviews.apache.org/r/70117/diff/3-4/
Testing
---
Thanks,
Benno Evers
4dd73fb18a06ce8f75c4c1435dba84ade123bee9
Diff: https://reviews.apache.org/r/70116/diff/4/
Changes: https://reviews.apache.org/r/70116/diff/3-4/
Testing
---
Thanks,
Benno Evers
/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce
Diff: https://reviews.apache.org/r/70185/diff/1/
Testing
---
Thanks,
Benno Evers
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70116/#review213404
---
On March 8, 2019, 11:48 p.m., Benno Evers wrote:
>
>
7945384867f26fa15dc734a235ae509d5d6d350f
Diff: https://reviews.apache.org/r/70117/diff/3/
Changes: https://reviews.apache.org/r/70117/diff/2-3/
Testing
---
Thanks,
Benno Evers
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213417
---
On March 7, 2019, 5:01 p.m., Benno Evers wrote:
>
> ---
> This is an automatically gen
an be decremented, but they should not be unless we have a bug in the
master code. I'm still a bit hesitant to `CHECK` for this, please see my
comment to a similar suggestion by Greg above.
- Benno
---
This is an automatically generated e-mai
201 - 300 of 867 matches
Mail list logo
