Re: Review Request 45605: Introduced HTB class.

768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 Diff: https://reviews.apache.org/r/45605/diff/ Testing --- make && make check Thanks, Cong Wang

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

> On May 20, 2016, 5:02 a.m., Cong Wang wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 3927 > > <https://reviews.apache.org/r/47633/diff/1/?file=1388820#file1388820line3927> > > > > You need to move this check int

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

(line 3927) <https://reviews.apache.org/r/47633/#comment198745> You need to move this check into the script rather than in the C++ code. Something like "test -f /proc/sys/net/ipv6/conf/all/disable_ipv6 && echo 1 > /proc/sys/net/ipv6/conf/all/disable_ipv6". - Con

Re: Review Request 47209: Establish TCP connection after backing off.

t; with master right after a new master is detected, right? But I think we > > want to do the link after the initial backoff to avoid SYN flood. > > Cong Wang wrote: > Authentication code path doesn't have a backoff, so we don't want to > touch it in this patch. > > Qian Zhang

Re: Review Request 47209: Establish TCP connection after backing off.

--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47209/ > --- > > (Updated May 13, 2016, 3:37 a.m.) > > > Review request for mesos, Benjamin Mahler, Ian Downes, and Cong

Re: Review Request 47209: Establish TCP connection after backing off.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47209/#review132597 --- Ship it! Ship It! - Cong Wang On May 11, 2016, 12:58 a.m

Re: Review Request 47080: Agent should backoff when establishing a socket.

080/#comment196366> One thing to note is the authentication could need a connect with master, so this could impact it. But essentially we need a backoff for authentication too. - Cong Wang On May 6, 2016, 10:51 p.m., David Robinson

Re: Review Request 47080: Agent should backoff when establishing a socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47080/#review132111 --- Ship it! Ship It! - Cong Wang On May 6, 2016, 10:51 p.m

Re: Review Request 45690: Ensured the bind mount root is a shared mount in its own peer group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45690/#review127173 --- Ship it! Ship It! - Cong Wang On April 5, 2016, 6:25 p.m

Re: Review Request 45690: Ensured the bind mount root is a shared mount in its own peer group.

(line 1963) <https://reviews.apache.org/r/45690/#comment190275> It is still not clear why we need to handle this case, at least I don't see Fedora needs it. If it is really needed by some distro, please add some comments to explain this. - Cong Wang On April 4, 2016, 5:30 p.m.,

Re: Review Request 45520: Used realpath for the bind mount root in port mapping isolator.

the places, other places than the mount table checking should be fine. But I am totally fine with this patch too. Please consider to backport this to other releases. - Cong Wang On April 4, 2016, 5:29 p.m., Jie Yu wrote

Re: Review Request 45607: Move HTB qdisc out of containers.

and/or --egress_rate_limit_per_container Thanks, Cong Wang

Review Request 45607: Moved HTB out of containers.

/port_mapping.cpp 323c84a3d960a196d8ba87f753814e9d43a07957 Diff: https://reviews.apache.org/r/45607/diff/ Testing --- Manual test with --egress_unique_flow_per_container and/or --egress_rate_limit_per_container Thanks, Cong Wang

Review Request 45606: Added default class to htb qdisc.

: https://reviews.apache.org/r/45606/diff/ Testing --- make && make check Thanks, Cong Wang

Review Request 45605: Introduced HTB class.

://reviews.apache.org/r/45605/diff/ Testing --- make && make check Thanks, Cong Wang

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

parent? At least on fedora21 this is not the case. Also, why do you fix two bugs in one patch? I know you don't care about bisect, but even so this is still not a good practice at all. - Cong Wang On March 31, 2016, 1:47 a.m., Jie Yu wrote

Review Request 45513: Fixed mount point check in port mapping isolator.

323c84a3d960a196d8ba87f753814e9d43a07957 Diff: https://reviews.apache.org/r/45513/diff/ Testing --- Manually start mesos slave and verify there is no more leak in /proc/mounts. Thanks, Cong Wang

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

on your osx... - Cong Wang On March 30, 2016, 6:34 p.m., Deshi Xiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45401: Fixed typo in subprocess doxygen comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45401/#review125777 --- Ship it! Ship It! - Cong Wang On March 28, 2016, 9:42 p.m

Re: Review Request 45399: Fixed capitalization of Watchdog enum.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45399/#review125776 --- Ship it! Ship It! - Cong Wang On March 28, 2016, 9:41 p.m

Re: Review Request 45400: Adapted port_mapping with missing subprocess parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45400/#review125763 --- Ship it! Ship It! - Cong Wang On March 28, 2016, 9:41 p.m

Re: Review Request 45230: Refactored subproces setup functions [1/7].

8, 2016 at 7:06 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote: > >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/45230/ >> 3rdparty/libprocess/include/process/subprocess.hpp >> <https://reviews.apache.org/r/45

Re: Review Request 45230: Refactored subproces setup functions [1/7].

<https://reviews.apache.org/r/45230/#comment188546> Ditto - Cong Wang On March 28, 2016, 4:51 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

(line 228) <https://reviews.apache.org/r/44514/#comment187871> You always have ifIndex==0 here, it is never changed. So either you miss some code or it is not needed at all. - Cong Wang On March 23, 2016, 5:10 a.m., Qian Zhang

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 6:19 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 228 > > > > > > Can there be a use case where you want multiple NICs to be attached to > >

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

FTS_NOSTAT flag to speed up? We don't need statp anyway. - Cong Wang On March 18, 2016, 12:16 a.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/#review125120 --- Ship it! Ship It! - Cong Wang On March 18, 2016, 12:16 a.m

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

> On March 20, 2016, 2:33 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > This comment seems incorrect: > > > > (1) The relevant

Re: Review Request 40988: stout: Fixed comments for numify(), cleaned up some test code.

> On March 18, 2016, 11:13 p.m., Cong Wang wrote: > > Can you separate the non-numify() change from the numify() one? It is best > > to do one thing per commit. > > Neil Conway wrote: > This change was committed a few months ago. I know it, I noticed this one

Re: Review Request 40988: stout: Fixed comments for numify(), cleaned up some test code.

? It is best to do one thing per commit. - Cong Wang On Dec. 4, 2015, 9:50 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

> On March 15, 2016, 8:02 p.m., Neil Conway wrote: > > Is it feasible/portable to have a test case for this change? > > Cong Wang wrote: > Yes, like in our case, you can create some socket or device file and try > to remove the directory contains it, it would fa

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

> On March 15, 2016, 8:02 p.m., Neil Conway wrote: > > Is it feasible/portable to have a test case for this change? Yes, like in our case, you can create some socket or device file and try to remove the directory contains it, it would fail without this patch. - Cong

Re: Review Request 44473: Added decrement operator to Counter.

g --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44473/#review123017 --- On March 9, 2016, 7:07 p.m., Cong Wang wrote: > > -

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

/metrics.cpp f1e6774ebf8670b006ba6ea181439d0ef1529b40 Diff: https://reviews.apache.org/r/44675/diff/ Testing --- make check Thanks, Cong Wang

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

default capture by reference. Could you explicitly > > list the variables that need to be captured here? > > Cong Wang wrote: > 1. Fixed > > 2. We need to capture all the function parameters, and in this context it > equals to capture all. So I don't think

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

makes sense to list them one by one? - Cong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44675/#review122996 -------

Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

/44675/diff/ Testing --- make check Thanks, Cong Wang

Re: Review Request 44666: Fixed typos in comments in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44666/#review122950 --- Ship it! Ship It! - Cong Wang On March 10, 2016, 6:13 p.m

Re: Review Request 44026: Moved future tests into future_tests.cpp.

/libprocess/src/tests/process_tests.cpp e9bf80ee69f4add299cb828ed3245ac07398943c Diff: https://reviews.apache.org/r/44026/diff/ Testing --- make check Thanks, Cong Wang

Re: Review Request 44474: Improve master tasks metrics.

check Thanks, Cong Wang

Re: Review Request 44475: Improve master slave metrics.

://reviews.apache.org/r/44475/diff/ Testing --- Manual check Thanks, Cong Wang

Re: Review Request 44473: Added decrement operator to Counter.

a13cc7e18c8b23eae83c326d63874d9d2aaedc0d 3rdparty/libprocess/src/tests/metrics_tests.cpp b84dc8d858f58bc9f52b218b7153510417cf34c2 Diff: https://reviews.apache.org/r/44473/diff/ Testing --- make check Thanks, Cong Wang

Re: Review Request 44026: Moved future tests into future_tests.cpp.

/process_tests.cpp e9bf80ee69f4add299cb828ed3245ac07398943c Diff: https://reviews.apache.org/r/44026/diff/ Testing --- make check Thanks, Cong Wang

Re: Review Request 44474: Improve master tasks metrics.

.apache.org/r/44474/#review122401 --- On March 7, 2016, 10:51 p.m., Cong Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44474/ > ---

Re: Review Request 44474: Improve master tasks metrics.

reach over enum, can we? - Cong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44474/#review122423 --- On March 7,

Re: Review Request 44474: Improve master tasks metrics.

e-mail. To reply, visit: https://reviews.apache.org/r/44474/#review122423 --- On March 7, 2016, 10:51 p.m., Cong Wang wrote: > > --- > This is an automatically generate

Review Request 44475: Improve master slaves metrics.

57ff4a39039f573b8586bc03f873f97826b97f6f src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 Diff: https://reviews.apache.org/r/44475/diff/ Testing --- Manual check Thanks, Cong Wang

Review Request 44474: Improve master tasks metrics.

57ff4a39039f573b8586bc03f873f97826b97f6f src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 Diff: https://reviews.apache.org/r/44474/diff/ Testing --- Manual check Thanks, Cong Wang

Re: Review Request 44153: Obtained uid/gids before changing filesystem root.

we remove it? 2. How about making getuid()+getgid()+getgrouplist() a helper function to reduce code duplication? Same for setgroups()+setuid(). - Cong Wang On Feb. 29, 2016, 12:09 a.m., Jie Yu wrote: > > --- > This is an auto

Re: Review Request 44151: Added stout functions to get and set supplementary groud ids.

(line 322) <https://reviews.apache.org/r/44151/#comment182954> You can construct vector with array, no need to bother a loop. 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 335) <https://reviews.apache.org/r/44151/#comment182956> Use vector::data()?

Re: Review Request 44026: Moved future tests into future_tests.cpp.

---- On Feb. 25, 2016, 5:59 p.m., Cong Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44026/ > -

Re: Review Request 38074: Calculate schedule latency with trace events

> time and act accordingly. That means we would need two separated code to handle two kernel versions. - Cong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/#review106958 ---

Review Request 44026: Moved future tests into future_tests.cpp.

://reviews.apache.org/r/44026/diff/ Testing --- make check Thanks, Cong Wang

Re: Review Request 43932: Added overlayfs provisioning backend.

> On Feb. 25, 2016, 2:52 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, line 106 > > > > > > just a question, does there are any policy when to use `Failure` and > >

Re: Review Request 43461: Used foreach loop to iterate std list/set.

/process/future.hpp 77655f22ad4ce6e81fd46bcdebbf2a82786e8f49 Diff: https://reviews.apache.org/r/43461/diff/ Testing --- make check Thanks, Cong Wang

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

tout rather than > > range-based`for`. > > * Mesos generally prefers explicit types than `auto`. > > > > ``` > > foreach (Future future, futures) { > > ... > > } > > ``` > > > > Here and below. > > Cong W

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

ct rule? At least src/tests/hierarchical_allocator_tests.cpp uses for(auto...) too. - Cong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43461/#review120550 -----

Re: Review Request 43462: Used list::splice() for clock::tick().

--- make check Thanks, Cong Wang

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

/ Testing --- make check Thanks, Cong Wang

Re: Review Request 43718: Added fs::supported() function.

tps://reviews.apache.org/r/43718/#comment181441> Well, not all kernels compile ext4 module, you can actually test "procfs" and "sysfs" here, they are required by Mesos. - Cong Wang On Feb. 21, 2016, 1

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review119819 --- Ship it! Ship It! - Cong Wang On Feb. 19, 2016, 2:02 a.m

Re: Review Request 38117: Added per container SNMP statistics.

he.org/r/43730/ - Cong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review119643 --- On Feb. 11, 2016, 12:

Review Request 43730: Added SNMP statistics to v1 mesos.proto too.

: mesos Description --- As Neil Conway noticed, we should add these SNMP statistics to v1 mesos.proto too. Diffs - include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 Diff: https://reviews.apache.org/r/43730/diff/ Testing --- make Thanks, Cong Wang

Re: Review Request 43718: Added fs::supported() function.

718/#comment180989> Use os::read() which handles error nicely. src/linux/fs.cpp (line 413) <https://reviews.apache.org/r/43718/#comment180990> Use tokenize("\n") - Cong Wang On Feb. 18, 2016, 4:01

Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

/ Testing --- make check Thanks, Cong Wang

Re: Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

tically generated e-mail. To reply, visit: https://reviews.apache.org/r/43535/#review119065 --- On Feb. 12, 2016, 6:57 p.m., Cong Wang wrote: > > --- > This is an automaticall

Review Request 43461: Used C++11 for loop to iterate std list/set.

: mesos Description --- Used C++11 for loop to iterate std list/set. Diffs - 3rdparty/libprocess/include/process/future.hpp 77655f22ad4ce6e81fd46bcdebbf2a82786e8f49 Diff: https://reviews.apache.org/r/43461/diff/ Testing --- make check Thanks, Cong Wang

Review Request 43462: Used list::splice() for clock::tick().

: mesos Description --- Used list::splice() for clock::tick(). Diffs - 3rdparty/libprocess/src/clock.cpp 6c32792aa2c00a4ff672c5aa0f784304b64d43bf Diff: https://reviews.apache.org/r/43462/diff/ Testing --- make check Thanks, Cong Wang

Re: Review Request 38117: Added per container SNMP statistics.

://reviews.apache.org/r/38117/diff/ Testing --- ./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics --pid= Thanks, Cong Wang

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to isolate a mesos container using the net_cls cgroup subsystem.

> On Jan. 15, 2016, 6 a.m., Cong Wang wrote: > > Why do we need netcls to regulate framework traffic on a per-container > > basis? Given the fact that a) the port range based filters already work and > > the code (see egress fq_codel) already exists b) we only have

Re: Review Request 41911: Added a test case for corrupt packets.

/port_mapping_tests.cpp 182fe9217a5da9af603d6f9c203a1689eff4ca1b Diff: https://reviews.apache.org/r/41911/diff/ Testing --- make check Thanks, Cong Wang

Re: Review Request 41911: Added a test case for corrupt packets

way really improves anything here. - Cong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41911/#review115242 ---

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class.

> On Jan. 15, 2016, 6 a.m., Cong Wang wrote: > > Why do we need netcls to regulate framework traffic on a per-container > > basis? Given the fact that a) the port range based filters already work and > > the code (see egress fq_codel) already exists b) we only have

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class.

> On Jan. 15, 2016, 6 a.m., Cong Wang wrote: > > Why do we need netcls to regulate framework traffic on a per-container > > basis? Given the fact that a) the port range based filters already work and > > the code (see egress fq_codel) already exists b) we only have

Re: Review Request 38117: Export per container SNMP statistics

-helper statistics --eth0_name=X --enable_snmp_statistics --pid= Thanks, Cong Wang

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to isolate a mesos container using the net_cls cgroup subsystem.

doesn't help at all. - Cong Wang On Jan. 15, 2016, 5:44 a.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41911: Added a test case for corrupt packets

://reviews.apache.org/r/41911/diff/ Testing --- make check Thanks, Cong Wang

Re: Review Request 38117: Export per container SNMP statistics

s, because it is a bit hard to expose this code to tests. - Cong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review110563 ------

Re: Review Request 38117: Export per container SNMP statistics

://reviews.apache.org/r/38117/diff/ Testing --- ./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics --pid= Thanks, Cong Wang

Re: Review Request 41648: Used initializer list c-tor for brevity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41648/#review112962 --- Ship it! Ship It! - Cong Wang On Jan. 5, 2016, 11:45 p.m

Re: Review Request 41911: Added a test case for corrupt packets

://reviews.apache.org/r/41911/diff/ Testing --- make check Thanks, Cong Wang

Review Request 41911: Added a test case for corrupt packets

Description --- Add a test case to ensure no corrupt packet could be delivered to application Diffs - src/tests/containerizer/port_mapping_tests.cpp 9bcf05ec071b44156b57d8515f47ee6a8bbfdfa0 Diff: https://reviews.apache.org/r/41911/diff/ Testing --- make check Thanks, Cong Wang

Review Request 41414: Exit nicely when a pid gets reused

iff: https://reviews.apache.org/r/41414/diff/ Testing --- Run recovery tests Thanks, Cong Wang

Re: Review Request 41414: Exit nicely when a pid gets reused

izer/mesos/isolators/network/port_mapping.cpp 49e215ba3502bba029956fedfc8bd828c3b4a028 Diff: https://reviews.apache.org/r/41414/diff/ Testing --- Run recovery tests Thanks, Cong Wang

Re: Review Request 38117: Export per container SNMP statistics

--eth0_name=X --enable_snmp_statistics --pid= Thanks, Cong Wang

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

iew109644 --- On Dec. 9, 2015, 11:15 p.m., Cong Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41158/ > -

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/#review109903 --- On Dec. 9, 2015, 11:15 p.m., Cong Wang wrote: > > --- > Thi

Review Request 41245: Use ethtool -k lo to check ethtool command

: https://reviews.apache.org/r/41245/diff/ Testing --- Manually start mesos slave Thanks, Cong Wang

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

rx checksum is turned off as expected. 3) I don't see any noticable performance issue after turning this off Thanks, Cong Wang

Review Request 41158: Turn off rx checksum offloading for veth in container

Thanks, Cong Wang

Re: Review Request 37541: Add trace event API

line974> > > > > this could use some comments. I will add some ASCII arts here to draw the ring buffer. - Cong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 36610: Add explicit syscall header file to linux fs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36610/#review109277 --- Isn't SYS_xxx in sys/syscall.h instead of syscall.h? - Cong Wang

Re: Review Request 40953: Avoid accepting hex float literals

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40953/#review109018 --- On Dec. 4, 2015, 5:23 a.m., Cong Wang w

Re: Review Request 37540: Add perf event API

- Cong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review108686 --- On Sept. 30, 2015, 12:12 a.m., Cong W

Re: Review Request 38117: Export per container SNMP statistics

--enable_snmp_statistics --pid= Thanks, Cong Wang

Re: Review Request 38117: Export per container SNMP statistics

--enable_snmp_statistics --pid= Thanks, Cong Wang

Review Request 40953: Avoid accepting hex float literals

/include/stout/numify.hpp 2035653d578497e88ef465dc6cd49e2c0fc53366 3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp 26fa7a4a06b36f9e7490e3274264f84b0369d412 Diff: https://reviews.apache.org/r/40953/diff/ Testing --- make check Thanks, Cong Wang

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

qdisc and classes. Thanks, Cong Wang

Re: Review Request 40497: Add hex number support to numify()

/stout/tests/numify_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/40497/diff/ Testing --- make check Thanks, Cong Wang

Re: Review Request 40506: Add stdout/tests/numify_tests.cpp into Makefile.am

/ Testing --- make check Thanks, Cong Wang

  1   2   3   >