://reviews.apache.org/r/66493/diff/3/
Changes: https://reviews.apache.org/r/66493/diff/2-3/
Testing
---
make on FreeBSD, with both lld and gold.
Thanks,
David Forsythe
comment Benjamin. It's because of how the linker command is formed (described
> [here](https://cmake.org/pipermail/cmake/2014-August/058268.html)). Not
> knowing this will leave you bewildered here.
>
> David Forsythe wrote:
> I'll make the comment a bit more descriptive.
I'm t
://reviews.apache.org/r/66493/diff/2/
Changes: https://reviews.apache.org/r/66493/diff/1-2/
Testing
---
make on FreeBSD, with both lld and gold.
Thanks,
David Forsythe
oreach ()
> endforeach ()
>
> ```
>
> Note that this only matters if you're using a multi-configuration
> generator (like Visual Studio and some other IDEs), but not `make` nor
> `ninja`.
Will switch over to something like that.
- David
-
---
make on FreeBSD, with both lld and gold.
Thanks,
David Forsythe
/r/66387/diff/2/
Changes: https://reviews.apache.org/r/66387/diff/1-2/
Testing
---
Thanks,
David Forsythe
9d0fd552a15387754fb7a27256308ef8beb1e3ed
cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c
Diff: https://reviews.apache.org/r/66385/diff/3/
Changes: https://reviews.apache.org/r/66385/diff/2-3/
Testing
---
Thanks,
David Forsythe
/66384/diff/2/
Changes: https://reviews.apache.org/r/66384/diff/1-2/
Testing
---
Thanks,
David Forsythe
://reviews.apache.org/r/66392/diff/4/
Changes: https://reviews.apache.org/r/66392/diff/3-4/
Testing
---
make on FreeBSD
Thanks,
David Forsythe
2b63b58f7d6a88c9986b746283dcfa79b7bcb270
Diff: https://reviews.apache.org/r/66314/diff/4/
Changes: https://reviews.apache.org/r/66314/diff/3-4/
Testing
---
make on FreeBSD
Thanks,
David Forsythe
://reviews.apache.org/r/66314/diff/3/
Changes: https://reviews.apache.org/r/66314/diff/2-3/
Testing
---
make on FreeBSD
Thanks,
David Forsythe
, so let's
> > maybe reflect that in a more general name, e.g., just `MAKE` if it is
> > available.
>
> David Forsythe wrote:
> I took a look at find_program, but I don't think that will solve the
> problem.
>
> We actually *do* depend on gmake here (even on dar
upstream to ZooKeeper (looks to me like
> > it should) then let's make sure it does. Their process is [pretty
> > similar](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute).
> >
> > If you don't want to, I can upstream it.
>
>
ly don't know,
> > so `UNKNOWN`).
Yup. Fixed.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66392/#review200370
----
://reviews.apache.org/r/66392/diff/3/
Changes: https://reviews.apache.org/r/66392/diff/2-3/
Testing (updated)
---
make on FreeBSD
Thanks,
David Forsythe
://reviews.apache.org/r/66314/diff/2/
Changes: https://reviews.apache.org/r/66314/diff/1-2/
Testing (updated)
---
make on FreeBSD
Thanks,
David Forsythe
, so let's
> > maybe reflect that in a more general name, e.g., just `MAKE` if it is
> > available.
>
> David Forsythe wrote:
> I took a look at find_program, but I don't think that will solve the
> problem.
>
> We actually *do* depend on gmake here (even on dar
, so let's
> > maybe reflect that in a more general name, e.g., just `MAKE` if it is
> > available.
>
> David Forsythe wrote:
> I took a look at find_program, but I don't think that will solve the
> problem.
>
> We actually *do* depend on gmake here (even on dar
and this code can go unchanged.
Fixed. Let me know if there is a better way to do it.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66392/#review200307
---
://reviews.apache.org/r/66392/diff/2/
Changes: https://reviews.apache.org/r/66392/diff/1-2/
Testing
---
Thanks,
David Forsythe
2b63b58f7d6a88c9986b746283dcfa79b7bcb270
cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c
Diff: https://reviews.apache.org/r/66385/diff/2/
Changes: https://reviews.apache.org/r/66385/diff/1-2/
Testing
---
Thanks,
David Forsythe
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66385/#review200291
---
On April 3, 2018, 4:58 a.m., David Forsythe wrote:
>
> ---
> This is a
to, I can upstream it.
I can add it to my todo list.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66384/#review200292
----
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66384/#review200289
-------
On April 1, 2018, 2:32 a.m., David Forsythe wrote:
>
>
lly generated e-mail. To reply, visit:
https://reviews.apache.org/r/66314/#review200305
---
On April 2, 2018, 6:36 p.m., David Forsythe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org
, so let's
> > maybe reflect that in a more general name, e.g., just `MAKE` if it is
> > available.
>
> David Forsythe wrote:
> I took a look at find_program, but I don't think that will solve the
> problem.
>
> We actually *do* depend on gmake here (even on dar
://reviews.apache.org/r/66392/diff/1/
Testing
---
Thanks,
David Forsythe
,
David Forsythe
64cc56ee4208afe05df0f28af5890157e4c7d82c
Diff: https://reviews.apache.org/r/66385/diff/1/
Testing
---
Thanks,
David Forsythe
/browse/MESOS-4176
Repository: mesos
Description
---
Link libm in ZooKeeper build on FreeBSD.
Diffs
-
3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0
Diff: https://reviews.apache.org/r/66384/diff/1/
Testing
---
Thanks,
David Forsythe
> On March 30, 2018, 8:34 a.m., David Forsythe wrote:
> > src/CMakeLists.txt
> > Line 35 (original)
> > <https://reviews.apache.org/r/66371/diff/1/?file=1990431#file1990431line35>
> >
> > Should this line be removed?
>
> Chun-Hung Hsiao
if it would be better to
gate this rather than removing it completely?
- David Forsythe
On March 29, 2018, 11:58 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
tps://reviews.apache.org/r/66371/#comment280886>
Should this line be removed?
- David Forsythe
On March 29, 2018, 11:58 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
, so let's
> > maybe reflect that in a more general name, e.g., just `MAKE` if it is
> > available.
>
> David Forsythe wrote:
> I took a look at find_program, but I don't think that will solve the
> problem.
>
> We actually *do* depend on gmake here (even on dar
ry: mesos
>
>
> Description
> ---
>
> Fix 3rdparty build commands for FreeBSD.
>
>
> Diffs
> -
>
> 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270
> cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c
>
>
> Diff: https://reviews.apache.org/r/66314/diff/1/
>
>
> Testing
> ---
>
> cmake --build on FreeBSD
>
>
> Thanks,
>
> David Forsythe
>
>
/66314/diff/1/
Testing
---
cmake --build on FreeBSD
Thanks,
David Forsythe
/disk_full_framework.cpp e13d4c8a427905793dda9bb01c52b6d372c19150
Diff: https://reviews.apache.org/r/54775/diff/
Testing
---
gmake check
Thanks,
David Forsythe
fails, but it no longer hangs when given the correct
addr.
Thanks,
David Forsythe
/os_tests.cpp f4b9ad71b22b5cc70a412c9a6a3e21da67121e17
Diff: https://reviews.apache.org/r/53926/diff/
Testing
---
gmake check on FreeBSD
Thanks,
David Forsythe
check
Thanks,
David Forsythe
/stout/tests/os_tests.cpp f4b9ad71b22b5cc70a412c9a6a3e21da67121e17
Diff: https://reviews.apache.org/r/53927/diff/
Testing
---
gmake check
Thanks,
David Forsythe
Diff: https://reviews.apache.org/r/53926/diff/
Testing
---
gmake check on FreeBSD
Thanks,
David Forsythe
to build completion.
Thanks,
David Forsythe
---
../configure
Thanks,
David Forsythe
://issues.apache.org/jira/browse/MESOS-6610
Repository: mesos
Description
---
Disable sentinel checks for clang on FreeBSD.
Diffs
-
configure.ac 5380cbc6a7951ede2f883f7045952a3f3434479e
Diff: https://reviews.apache.org/r/53913/diff/
Testing
---
gmake on FreeBSD.
Thanks,
David
run.
Thanks,
David Forsythe
://issues.apache.org/jira/browse/MESOS-6607
Repository: mesos
Description
---
Fix configure on FreeBSD.
Diffs
-
configure.ac 5380cbc6a7951ede2f883f7045952a3f3434479e
Diff: https://reviews.apache.org/r/53882/diff/
Testing
---
../configure
Thanks,
David Forsythe
218a38512d4dc8e160d975a99c577e4411879eee
Diff: https://reviews.apache.org/r/42735/diff/
Testing
---
Thanks,
David Forsythe
9d37c81a13cb0c281f4a53884c6c55e09c341d85
support/vote.sh 218a38512d4dc8e160d975a99c577e4411879eee
Diff: https://reviews.apache.org/r/42735/diff/
Testing
---
Thanks,
David Forsythe
9d37c81a13cb0c281f4a53884c6c55e09c341d85
support/vote.sh 218a38512d4dc8e160d975a99c577e4411879eee
Diff: https://reviews.apache.org/r/42735/diff/
Testing
---
Thanks,
David Forsythe
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42735/#review116182
-------
On Jan. 25, 2016, 8:07 p.m., David Forsythe wrote:
>
> --
https://issues.apache.org/jira/browse/MESOS-4502
Repository: mesos
Description
---
Make commit-msg hook portable.
Diffs
-
support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60
Diff: https://reviews.apache.org/r/42735/diff/
Testing
---
Thanks,
David
/3rdparty/stout/include/stout/posix/os.hpp
74af0077a39ef4cfa636b0b9e0c6b93eabc04bc8
Diff: https://reviews.apache.org/r/42757/diff/
Testing
---
gmake check on FreeBSD and Ubuntu.
Thanks,
David Forsythe
://reviews.apache.org/r/41726/diff/
Testing
---
gmake check
Thanks,
David Forsythe
into separate, platform specfic files.
I thought about that while writing this, but didn't want to be presumptuous.
I'll split things up in another change. Done.
- David
---
This is an automatically generated e-mai
/3rdparty/stout/include/stout/os/sysctl.hpp
8cfc77fc30d1bd17f7d3d3b2e8ca449f331aa9ca
Diff: https://reviews.apache.org/r/41596/diff/
Testing
---
gmake check on FreeBSD 10.2-R
Thanks,
David Forsythe
---
gmake check
Thanks,
David Forsythe
://reviews.apache.org/r/41726/diff/
Testing
---
gmake check
Thanks,
David Forsythe
---
gmake check
Thanks,
David Forsythe
/sysctl.hpp
8cfc77fc30d1bd17f7d3d3b2e8ca449f331aa9ca
Diff: https://reviews.apache.org/r/41596/diff/
Testing (updated)
---
gmake check on FreeBSD 10.2-R
Thanks,
David Forsythe
/
Testing
---
gmake check on FreeBSD 10.2-R
Thanks,
David Forsythe
---
make check on ubuntu 14.04
Thanks,
David Forsythe
check on ubuntu
Thanks,
David Forsythe
attached)
File Attachments
check.log
https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log
Thanks,
David Forsythe
attached)
File Attachments
check.log
https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log
Thanks,
David Forsythe
---
make check on ubuntu 14.04
Thanks,
David Forsythe
check on ubuntu
Thanks,
David Forsythe
e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8
Diff: https://reviews.apache.org/r/39634/diff/
Testing
---
make check on ubuntu 14.04
Thanks,
David Forsythe
attached)
File Attachments
check.log
https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log
Thanks,
David Forsythe
check on ubuntu
Thanks,
David Forsythe
attached)
File Attachments
check.log
https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log
Thanks,
David Forsythe
---
make check on ubuntu 14.04
Thanks,
David Forsythe
check on ubuntu
Thanks,
David Forsythe
uff up to date if this gets merged.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/#review104756
-------
On O
---
make check on ubuntu 14.04
Thanks,
David Forsythe
check on ubuntu
Thanks,
David Forsythe
attached)
File Attachments
check.log
https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log
Thanks,
David Forsythe
7c2bcffe5c7be1f7d90e6df470d20a00245bfbff
3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975
3rdparty/libprocess/src/tests/http_tests.cpp
d13d3888abbf3db552df4a9f83e54667e598ded9
Diff: https://reviews.apache.org/r/39635/diff/
Testing
---
make check on ubuntu
Thanks,
David Forsythe
check.log
https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log
Thanks,
David Forsythe
ou cleaning things
> > up?
This, and all changes like it, are for issues I ran into when running tests.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3934
/2015/10/20/c6757057-d221-444f-8b61-0f853e568e9e__check3.log
Thanks,
David Forsythe
/uploaded/files/2015/10/19/5b62f825-006f-4316-b0a4-c1f39f9a__check2.log
Thanks,
David Forsythe
/2015/10/19/5b62f825-006f-4316-b0a4-c1f39f9a__check2.log
Thanks,
David Forsythe
/uploaded/files/2015/10/15/6661fae4-32bf-409a-b975-05514aae3174__freebsd_check.log
Thanks,
David Forsythe
https://reviews.apache.org/media/uploaded/files/2015/10/15/6661fae4-32bf-409a-b975-05514aae3174__freebsd_check.log
Thanks,
David Forsythe
85 matches
Mail list logo
