Re: Review Request 53411: Use a random TCP port for framework tests.

2016-11-03 Thread David Robinson
e anything between 1024 and 65535. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53411/#review154795 --- On Nov. 2, 2016,

Review Request 53411: Use a random TCP port for framework tests.

2016-11-02 Thread David Robinson
:24269 ... DEBUG: I1102 22:39:14.312568 46937 slave.cpp:915] New master detected at master@127.0.0.1:24269 ... DEBUG: [ OK ] ExamplesTest.DiskFullFramework (17988 ms) Thanks, David Robinson

Re: Review Request 50177: Add systemd watchdog support.

2016-07-20 Thread David Robinson
DOG_USEC / 2 microseconds. The message indicates liveliness to systemd. - David Robinson On July 19, 2016, 1:14 a.m., Lawrence Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 47209: Establish TCP connection after backing off.

2016-05-12 Thread David Robinson
://reviews.apache.org/r/47209/diff/ Testing --- make check Also started a master and agent and captured a tcpdump to verify the connection is only established _after_ the registration backoff. Thanks, David Robinson

Re: Review Request 47209: Establish TCP connection after backing off.

2016-05-12 Thread David Robinson
://reviews.apache.org/r/47209/diff/ Testing --- make check Also started a master and agent and captured a tcpdump to verify the connection is only established _after_ the registration backoff. Thanks, David Robinson

Review Request 47209: Establish TCP connection after backing off.

2016-05-10 Thread David Robinson
Also started a master and agent and captured a tcpdump to verify the connection is only established _after_ the registration backoff. Thanks, David Robinson

Review Request 47154: Establish TCP connection after backing off.

2016-05-09 Thread David Robinson
://reviews.apache.org/r/47154/diff/ Testing --- make check Also started a master and agent and captured a tcpdump to verify the connection is only established _after_ the registration backoff. Thanks, David Robinson

Re: Review Request 47080: Agent should backoff when establishing a socket.

2016-05-09 Thread David Robinson
To reply, visit: https://reviews.apache.org/r/47080/#review132205 --- On May 6, 2016, 10:51 p.m., David Robinson wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 47080: Agent should backoff when establishing a socket.

2016-05-06 Thread David Robinson
/47080/diff/ Testing (updated) --- make tests make check Also started a master and agent and captured a tcpdump to verify the connection is only established _after_ the registration backoff. Thanks, David Robinson

Review Request 47080: Agent should backoff when establishing a socket.

2016-05-06 Thread David Robinson
tests Also started a master and agent and captured a tcpdump to verify the connection is only established _after_ the registration backoff. Thanks, David Robinson

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

2016-03-15 Thread David Robinson
> On March 15, 2016, 8:02 p.m., Neil Conway wrote: > > Is it feasible/portable to have a test case for this change? > > Cong Wang wrote: > Yes, like in our case, you can create some socket or device file and try > to remove the directory contains it, it would fail without this patch.

Re: Review Request 42980: Increased the default registry_store_timeout.

2016-01-29 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42980/#review117040 --- Ship it! Ship It! - David Robinson On Jan. 29, 2016, 10:46

Re: Review Request 41245: Use ethtool -k lo to check ethtool command

2015-12-11 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41245/#review109965 --- Ship it! Ship It! - David Robinson On Dec. 11, 2015, 5:20 a.m

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

2015-12-10 Thread David Robinson
loopback interface - David Robinson On Dec. 9, 2015, 11:15 p.m., Cong Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie