and Timothy Chen.
Changes
---
Fix comments from Haosdent Huang and Guangya Liu
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/mesos
and Timothy Chen.
Changes
---
Fixed the error message in case multiple networks are specified during "run"
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review125921
---
On March 29, 2016, 4:33 p.m., Ezra Silvera wrote:
>
> -
and Timothy Chen.
Changes
---
Don't allow multiple network_info elements during "docker run"
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
y allows you to attach container to
> > multiple network but not using the `docker run` command, so doesn't fit the
> > model for `DockerContainerizer`.
>
> Ezra Silvera wrote:
> I'm not sure I follow you point ... Indeed in Docker run it's not
> allowed to speci
and Timothy Chen.
Changes
---
Typo Warnning --> Warning
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/me
fos, the docker containerizer will only take the first network info.
> >
> > It is a tricky part here, if an operator defined many network infos and
> > only the first one do not have network name, error will return here.
>
> Ezra Silvera wrote:
>
.
Changes
---
Add warnning for multiple network_infos.
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/mesos
y fail the operation for elements > 1 if you
think it will be more clear.
- Ezra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review125841
--------
y allows you to attach container to
> > multiple network but not using the `docker run` command, so doesn't fit the
> > model for `DockerContainerizer`.
>
> Ezra Silvera wrote:
> I'm not sure I follow you point ... Indeed in Docker run it's not
> allowed to speci
.
Changes
---
Fixing comments from Guangya Liu
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/mesos
he `{}` block.
> > 3) Updated indent in L559.
Thanks. Fixed.
- Ezra
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review125835
.
Changes
---
Fix Indentation
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/mesos.proto cb68e2c13409620fa4836c12d877488f43
il. To reply, visit:
https://reviews.apache.org/r/42516/#review125635
-------
On March 28, 2016, 10:51 a.m., Ezra Silvera wrote:
>
> ---
> This is an automat
os/blob/master/src/master/http.cpp#L482 as
> > reference.
> >
> > I think that we still need update `DockerInfo` by adding `network_name`
> > and always using `network_name` from `DockerInfo` first; if no
> > `network_name` in `DockerInfo`, use `name` from
os/blob/master/src/master/http.cpp#L482 as
> > reference.
> >
> > I think that we still need update `DockerInfo` by adding `network_name`
> > and always using `network_name` from `DockerInfo` first; if no
> > `network_name` in `DockerInfo`, use `name` from
il. To reply, visit:
https://reviews.apache.org/r/42516/#review125645
-------
On March 28, 2016, 10:51 a.m., Ezra Silvera wrote:
>
> ---
> This is an automat
)
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/mesos.proto cb68e2c13409620fa4836c12d877488f4333ace7
include/mesos/v1/mesos.proto af1dc9e11a26b52cfc348324b8dd796c1f72323f
src/docker/docker.cpp 4d35513cdd9c044d37d876a6db7dd9321ceaca53
Diff:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/
---
(Updated March 28, 2016, 10 a.m.)
Review request for mesos and Timothy Chen.
add a singular `NetworkInfo`, do we still need to add the
> `optional string network_name` field?
>
> Qian Zhang wrote:
> I think what we are going to do is to add a singular `name` field in the
> existing `NetworkInfo` message rather than to add a singular `NetworkInfo`
> me
array.
- Ezra Silvera
On Feb. 17, 2016, 10:52 p.m., Travis Hegner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On March 9, 2016, 8:48 p.m., Ezra Silvera wrote:
> > Please note that a container can be attached to more then one network! In
> > that case HostConfig.NetworkMode will contain the first NW the container
> > was attached two. The desired IP, however, might be the one o
network! In that
case HostConfig.NetworkMode will contain the first NW the container was
attached two. The desired IP, however, might be the one on a different NW in
the NetworkSettings.Networks array.
- Ezra Silvera
On Feb. 17, 2016, 10:52 p.m., Travis Hegner wrote
ge and then when that request is merged we
can easily go and change the code to use that field. It seems we keep moving
gin circles here on a relatively simple change which prohibit us to use
user-networks from our Swarm based cloud..
- Ezra
---------
.
Changes
---
Fixing typos
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2
i
e.org/r/42516/#review119266
---
On Feb. 11, 2016, 1:51 p.m., Ezra Silvera wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
.9 .. I'll push another commit shortly.
Is that OK ?
- Ezra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review119031
------
> On Feb. 11, 2016, 9:34 a.m., Klaus Ma wrote:
> > src/docker/docker.cpp, line 529
> > <https://reviews.apache.org/r/42516/diff/9/?file=1239370#file1239370line529>
> >
> > Also check whether `network_name()` is empty string `""`.
>
> Ezr
> On Feb. 11, 2016, 9:34 a.m., Klaus Ma wrote:
> > src/docker/docker.cpp, line 529
> > <https://reviews.apache.org/r/42516/diff/9/?file=1239370#file1239370line529>
> >
> > Also check whether `network_name()` is empty string `""`.
>
> Ezr
ready covered this issue in previous review comments. Is there
anything special you think is missing ?
Ezra Silvera 3 weeks ago (Jan. 20, 2016, 12:47 p.m.)
Guangya Liu, I went through the testing functions and I'm not sure we
actually need to add test for this. Currently there are 3 possible va
.
Changes
---
Loaded the correct diff
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74
.
Changes
---
Change error message + add a test for network_name=""
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/m
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review118633
-------
On Feb. 10, 2016, 8:34 a.m., Ezra Silvera wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apach
d of ">=",
> > we can wait for the comments from Tim.
>
> Ezra Silvera wrote:
> The problem is that "higher or equal to" seemed too awkward to me
>
> Guangya Liu wrote:
> Just saw that @tnachen already showed his comments above about this an
d of ">=",
> > we can wait for the comments from Tim.
>
> Ezra Silvera wrote:
> The problem is that "higher or equal to" seemed too awkward to me
>
> Guangya Liu wrote:
> Just saw that @tnachen already showed his comments above about this and
&g
.
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3
include/mesos/v1/mesos
.
Changes
---
Fixed error message
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74
TimothyIL.
Changes
---
Validate engine version >= 1.9.0
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/me
TimothyIL.
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466
include/mesos/v1/mesos
good catch. thanks :-)
- Ezra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review116010
---
On Jan. 24, 20
TimothyIL.
Changes
---
fix type smpty-->empty
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/me
TimothyIL.
Changes
---
Verify that network_name is not empty
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description (updated)
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/mesos
TimothyIL.
Changes
---
use has_network_name()
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Diffs (updated)
-
include/mesos/mesos
--
On Jan. 20, 2016, 12:25 p.m., Ezra Silvera wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> -
TimothyIL.
Changes
---
fix typos
Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369
Repository: mesos
Description (updated)
---
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
Review: https://reviews.apache.org/r/42549
Diffs (updated)
-
include
> On Jan. 19, 2016, 11:29 p.m., Guangya Liu wrote:
> > A unit test also needed, please refer to
> > https://github.com/apache/mesos/blob/master/src/tests/containerizer/docker_containerizer_tests.cpp#L297
> > for detail
>
> Ezra Silvera wrote:
> Thanks. I'll
the executer so it supports processing port mapping also for
user-define network (instead of just for legacy bridge)
Note that using the new user-defined network (both local and overlay) is
considered the prefered Docker networking option.
Signed-off-by: Ezra Silvera <e...@il.ibm.com>
engine/userguide/networking/dockernetworks/#user-defined-networks
- Ezra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review115278
-------
On Jan. 19, 2016, 6:53 p.m., Ezra Silvera wrote:
>
>
48 matches
Mail list logo
