ed data structures and
I don't think that we should add a new one just for this.
src/master/master.cpp
Lines 11402 (patched)
<https://reviews.apache.org/r/71080/#comment303979>
Nit: s/ids/IDs/
- Gastón Kleiman
On July 17, 2019, 11:
)
<https://reviews.apache.org/r/70528/#comment303732>
Super minor nit: s/ / / =)
- Gastón Kleiman
On July 10, 2019, 7:58 a.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70587/#review215039
---
Ship it!
Ship It!
- Gastón Kleiman
On May 2, 2019, 3 p.m
://reviews.apache.org/r/70593/
```
- Gastón Kleiman
On May 3, 2019, 9:38 a.m., Andrei Sekretenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70593/#review215022
---
Ship it!
Ship It!
- Gastón Kleiman
On May 3, 2019, 9:38 a.m
://reviews.apache.org/r/70506/diff/2/
Changes: https://reviews.apache.org/r/70506/diff/1-2/
Testing
---
Thanks,
Gastón Kleiman
: mesos
Description
---
Added metrics to the operation feedback example framework.
Diffs
-
src/examples/operation_feedback_framework.cpp
ab19605dda069db06b6215a95049014244fc2d4f
Diff: https://reviews.apache.org/r/70506/diff/1/
Testing
---
Thanks,
Gastón Kleiman
Diff: https://reviews.apache.org/r/70478/diff/1/
Testing
---
Manual testing.
Thanks,
Gastón Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70377/#review214641
---
Ship it!
Ship It!
- Gastón Kleiman
On April 10, 2019, 8:31
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70379/#review214640
---
Ship it!
Ship It!
- Gastón Kleiman
On April 10, 2019, 8:35
, 2600 (patched)
<https://reviews.apache.org/r/70408/#comment300826>
Please shift this line left to fix the indentation.
- Gastón Kleiman
On April 10, 2019, 8:29 a.m., Andrei Sekretenko wrote:
>
> ---
> This is an auto
://reviews.apache.org/r/70412/diff/3/
Changes: https://reviews.apache.org/r/70412/diff/2-3/
Testing
---
Manual testing.
Thanks,
Gastón Kleiman
so
we shouldn't get any status updates.
- Gastón
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70412/#review214481
-------
/70412/diff/2/
Changes: https://reviews.apache.org/r/70412/diff/1-2/
Testing
---
Manual testing.
Thanks,
Gastón Kleiman
the presence of `RESERVATION_REFINEMENT`?
>
> Gastón Kleiman wrote:
> This framework only pushes one reservation, so I guess that there should
> only be one element for reservations made by it?
>
> The check would fail if the example framework shares a role with
ated e-mail. To reply, visit:
https://reviews.apache.org/r/70412/#review214468
-------
On April 5, 2019, 4:35 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apach
. Otherwise it
will unreserve reservations made by another framework.
Diffs
-
src/examples/operation_feedback_framework.cpp
2480c340c4ccb4246098c35e0315093f3eb44e81
Diff: https://reviews.apache.org/r/70412/diff/1/
Testing
---
Manual testing.
Thanks,
Gastón Kleiman
,
Gastón Kleiman
pp#L724-L747
The `MockHTTPScheduler` also has a `error` callback that can be used to
check whether the master rejects the re-registration attempt.
- Gastón Kleiman
On April 3, 2019, 8:42 a.m., Andrei Sekretenko wrote:
>
> ---
> Thi
debase.
- Gastón Kleiman
On April 3, 2019, 9:01 a.m., Andrei Sekretenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
src/master/master.cpp
Lines 2598 (patched)
<https://reviews.apache.org/r/70379/#comment300593>
I think I'd rather not mention the old principal to prevent leaking
information.
src/master/master.cpp
Lines 10763 (patched)
<https://reviews.ap
---
>
> (Updated March 28, 2019, 4:27 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Chun-Hung Hsiao,
> Gastón Kleiman, Joseph Wu, and Meng Zhu.
>
>
> Bugs: MESOS-8582
> https://issues.apache.org/jira/browse/MESOS
: I'd say: "Failed to unschedule framework directories scheduled for gc"
I would also include the path that couldn't be gc'd.
- Gastón Kleiman
On March 28, 2019, 4:27 p.m., Greg Mann wrote:
>
> ---
> This i
283/diff/1/
Testing
---
`OperationReconciliationTest.AgentPendingOperationAfterMasterFailover` passed
over 5000 iterations under stress. Other tests still pass on GNU/Linux.
Thanks,
Gastón Kleiman
But I like Joseph's suggestion better =).
- Gastón Kleiman
On March 21, 2019, 3:26 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To rep
/operation_reconciliation_tests.cpp
Lines 284-293 (patched)
<https://reviews.apache.org/r/70208/#comment299748>
We could remove this if the first operation also reserved 0.1 CPUs
- Gastón Kleiman
On March 15, 2019, 3:53 p.m., Greg Mann
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70221/#review213755
---
Ship it!
Ship It!
- Gastón Kleiman
On March 15, 2019, 3:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70200/#review213754
---
Ship it!
Ship It!
- Gastón Kleiman
On March 15, 2019, 3:35
only `RESERVE`
opertions don't need a resource provider. Removing the instantiation of the RP
would make remove a lot of boilerplate and some amount of clock manipulation,
thus making the test much shorter, readable and less prone to races.
- Gastón Kleiman
On March 13, 2019, 6:41 p.m., Greg
returns a response, but
it just happens to be the case that no call does that at the moment.
I would delete this comment.
- Gastón Kleiman
On March 14, 2019, 10:24 a.m., Greg Mann wrote:
>
> ---
> This is an automatically genera
he updated test doesn't call `result->response()`, so there is no risk of
it crashing.
src/tests/storage_local_resource_provider_tests.cpp
Lines 4658-4660 (original), 4662-4664 (patched)
<https://reviews.apache.org/r/70200/#comment299693>
`%s/ASSERT/EXPECT/g`
- Gastón Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70186/#review213626
---
Ship it!
Ship It!
- Gastón Kleiman
On March 11, 2019, 12:18
ive?
src/master/metrics.cpp
Lines 684 (patched)
<https://reviews.apache.org/r/70116/#comment299500>
Can counters for terminal states be decremented? I guess not? If I'm
correct, then we could add a `CHECK` here.
- Gastón Kleiman
On M
tps://reviews.apache.org/r/70156/#comment299492>
Nit: I'd name this `EXPECT_METRIC_EQ`.
- Gastón Kleiman
On March 7, 2019, 8:59 a.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70115/#review213539
---
Ship it!
Ship It!
- Gastón Kleiman
On March 4, 2019, 9 a.m
ply, visit:
https://reviews.apache.org/r/69978/#review213234
-----------
On Feb. 22, 2019, 5:28 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically ge
7ad495504e4ff144ac31812fbd4a3a1f4da86f02
src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
Diff: https://reviews.apache.org/r/70044/diff/2/
Changes: https://reviews.apache.org/r/70044/diff/1-2/
Testing
---
Tests still pass on GNU/Linux + quite some manual testing.
Thanks,
Gastón Kleiman
sit:
https://reviews.apache.org/r/70044/#review213205
---
On Feb. 22, 2019, 5:34 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To re
: https://reviews.apache.org/r/70044/diff/1/
Testing
---
Thanks,
Gastón Kleiman
e3c2c005d865b5c333e92e50e49ef398fe06ad79
Diff: https://reviews.apache.org/r/70044/diff/1/
Testing (updated)
---
Tests still pass on GNU/Linux + quite some manual testing.
Thanks,
Gastón Kleiman
://reviews.apache.org/r/69978/diff/5/
Changes: https://reviews.apache.org/r/69978/diff/4-5/
Testing
---
Manual testing + existing tests still pass.
Thanks,
Gastón Kleiman
/69978/diff/3-4/
Testing
---
Manual testing + existing tests still pass.
Thanks,
Gastón Kleiman
ck somewhere. i.e.
> > ```
> > // NOTE: Operations found in the `ResourceState`, but not in the
> > // operation update streams directory are streams to be created.
> > // These operations have nothing to recover.
> > ```
I agree,
/
Changes: https://reviews.apache.org/r/69977/diff/2-3/
Testing
---
Manual testing + existing tests still pass.
Thanks,
Gastón Kleiman
--
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69960/
> ---
>
> (Updated Feb. 19, 2019, 4:45 p.m.)
>
>
> Review request for mesos, Benno Evers
/r/69977/ which makes
`Slave::_recoverOperations()` handle that case.
- Gastón
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69978/#review213008
----------
inuation, we will no longer
> > remove the operation if there is an error when calling
> > `operationStatusUpdateManager.acknowledgement()`; is that what we want?
> > Perhaps we should add a `removeOperation()` call in the `err()` helper as
> > well?
>
> Ga
/r/69978/diff/2-3/
Testing
---
Manual testing + existing tests still pass.
Thanks,
Gastón Kleiman
nother corner case that the SLRP
handles and I had missed: the agent could fail over right before executing this
lambda. It should notice that during recovery and garbage collect the stream —
I'm adding a new patch to this chain that does this.
- Gastón Kleiman
On Feb. 13, 2019, 3:15 p.m.,
reply, visit:
https://reviews.apache.org/r/69978/#review212881
-------
On Feb. 13, 2019, 3:15 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically
---
Tests are still passing.
Thanks,
Gastón Kleiman
/diff/2/
Changes: https://reviews.apache.org/r/69977/diff/1-2/
Testing
---
Manual testing + existing tests still pass.
Thanks,
Gastón Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69957/#review212883
---
Ship it!
Ship It!
- Gastón Kleiman
On Feb. 13, 2019, 8:09
ed, so the task shoudl have been removed
from the master's unreachable tasks list`
- Gastón Kleiman
On Feb. 6, 2019, 8:41 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69908/#review212849
---
Ship it!
Ship It!
- Gastón Kleiman
On Feb. 6, 2019, 8:38
(original), 1799 (patched)
<https://reviews.apache.org/r/69907/#comment298733>
Can you fix it here too?
- Gastón Kleiman
On Feb. 6, 2019, 8:35 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69969/#review212814
---
Ship it!
Ship It!
- Gastón Kleiman
On Feb. 12, 2019, 6:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69964/#review212813
---
Ship it!
Ship It!
- Gastón Kleiman
On Feb. 12, 2019, 6:39
: https://reviews.apache.org/r/69978/diff/1-2/
Testing
---
Manual testing + existing tests still pass.
Thanks,
Gastón Kleiman
of the `Slave::operationStatusAcknowledgement` method.
Diffs
-
src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
Diff: https://reviews.apache.org/r/69978/diff/1/
Testing
---
Manual testing + existing tests still pass.
Thanks,
Gastón Kleiman
fails over while processing the
acknowledgement of a terminal operation status update.
Diffs
-
src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
Diff: https://reviews.apache.org/r/69977/diff/1/
Testing
---
Manual testing + existing tests still pass.
Thanks,
Gastón
tps://reviews.apache.org/r/69964/#comment298687>
Can we check here that the framework doesn't get any operation status
updates?
- Gastón Kleiman
On Feb. 12, 2019, 3:42 p.m., Greg Mann wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69958/#review212778
---
Ship it!
Ship It!
- Gastón Kleiman
On Feb. 12, 2019, 1:53
(patched)
<https://reviews.apache.org/r/69964/#comment298686>
Should we do `GET_OPERATIONS` here and check the response?
- Gastón Kleiman
On Feb. 12, 2019, 3:42 p.m., Greg Mann wrote:
>
> ---
> This is an automatically g
t;;
```
If they get that, then it might be easier for them to debug missing
capabilities.
src/master/master.cpp
Line 8725 (original)
<https://reviews.apache.org/r/69957/#comment298683>
Would the following assertion hold?
`CHE
ly, visit:
https://reviews.apache.org/r/69911/#review212654
-------
On Feb. 8, 2019, 3:12 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail.
d
Thanks,
Gastón Kleiman
-tests.sh--gtest_filter="*AgentOperationFeedbackTest*"
--gtest_repeat=5000 --gtest_break_on_failure`
Thanks,
Gastón Kleiman
, visit:
https://reviews.apache.org/r/69910/#review212651
-------
On Feb. 7, 2019, 1:53 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically gener
://reviews.apache.org/r/69913/diff/1/
Testing
---
`GLOG_v=1 bin/mesos-tests.sh --verbose
--gtest_filter="*OperationReconciliationTest*"` passed
Thanks,
Gastón Kleiman
/agent_operation_feedback_tests.cpp
Lines 564 (patched)
<https://reviews.apache.org/r/69922/#comment298500>
Can we also check that the agent ID is set and that the RP ID isn't?
- Gastón Kleiman
On Feb. 7, 2019, 3:23 p.m., Greg Mann
428e14ef2e6b9f0e622a6ce05c469dd0ed97d07e
Diff: https://reviews.apache.org/r/69920/diff/1/
Testing
---
Thanks,
Gastón Kleiman
---
Thanks,
Gastón Kleiman
eedback_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/69910/diff/1/
>
>
> Testing
> ---
>
> `bin/mesos-tests.sh--gtest_filter="*AgentOperationFeedbackTest*"
> --gtest_repeat=5000 --gtest_break_on_failure`
>
>
> Thanks,
>
> Gastón Kleiman
>
>
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69911/#review212632
---
On Feb. 7, 2019, 1:55 p.m., Gastón Kleiman wrote:
>
> ---
eviews.apache.org/r/69913/#review212635
-------
On Feb. 6, 2019, 2:04 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To re
="*OperationReconciliationTest*"
--gtest_repeat=5000 --gtest_break_on_failure` passed
Thanks,
Gastón Kleiman
status updates that it generates.
Diffs (updated)
-
src/master/master.cpp 4c9ef2528d0ab74b565dcb03d05c5189d0aa0c0f
Diff: https://reviews.apache.org/r/69912/diff/2/
Changes: https://reviews.apache.org/r/69912/diff/1-2/
Testing
---
`bin/mesos-tests.sh` passed
Thanks,
Gastón
: https://reviews.apache.org/r/69910/diff/1-2/
Testing
---
`bin/mesos-tests.sh--gtest_filter="*AgentOperationFeedbackTest*"
--gtest_repeat=5000 --gtest_break_on_failure`
Thanks,
Gastón Kleiman
eviews.apache.org/r/69913/#review212635
-------
On Feb. 6, 2019, 2:04 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To re
```
- Gastón
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69912/#review212634
-------
On Feb. 6
---
`GLOG_v=1 bin/mesos-tests.sh --verbose
--gtest_filter="*OperationReconciliationTest*"` passed
Thanks,
Gastón Kleiman
4c9ef2528d0ab74b565dcb03d05c5189d0aa0c0f
Diff: https://reviews.apache.org/r/69912/diff/1/
Testing
---
`bin/mesos-tests.sh` passed
Thanks,
Gastón Kleiman
/69911/diff/1/
Testing
---
`bin/mesos-tests.sh --gtest_filter="*OperationReconciliationTest*"
--gtest_repeat=5000 --gtest_break_on_failure` passed
Thanks,
Gastón Kleiman
src/tests/agent_operation_feedback_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/69910/diff/1/
Testing
---
`bin/mesos-tests.sh--gtest_filter="*AgentOperationFeedbackTest*"
--gtest_repeat=5000 --gtest_break_on_failure`
Thanks,
Gastón Kleiman
> On Feb. 4, 2019, 4:28 p.m., Gastón Kleiman wrote:
> > src/tests/master_tests.cpp
> > Lines 9419 (patched)
> > <https://reviews.apache.org/r/69876/diff/1/?file=2123554#file2123554line9419>
> >
> > We should consider making the agent not recover t
(patched)
<https://reviews.apache.org/r/69876/#comment298353>
We should consider making the agent not recover the operation status update
manager if it isn't started with the `AGENT_OPERATION_FEEDBACK` capability.
- Gastón Kleiman
On Jan. 31, 2019, 3:08 p.m., Greg Mann
slave failed recovery and hence registering as a new
// slave before the master removed the old slave from its map.
// - If the slave was shutting down while it had a registration
// retry scheduled. See MESOS-8463.
```
- Gastón Kleiman
On Feb. 4, 2019, 1:
600 (patched)
<https://reviews.apache.org/r/69871/#comment298345>
Nit: remove this extra line.
- Gastón Kleiman
On Jan. 31, 2019, 9:57 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail.
/r/69795/diff/7-8/
Testing
---
Current tests still pass.
Thanks,
Gastón Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69843/#review212429
---
Ship it!
Ship It!
- Gastón Kleiman
On Jan. 25, 2019, 6:22
/69795/diff/6-7/
Testing
---
Current tests still pass.
Thanks,
Gastón Kleiman
epeat=5000 --gtest_break_on_failure` passed on CentOS 7.4.1708.
Thanks,
Gastón Kleiman
/diff/5-6/
Testing
---
Current tests still pass.
Thanks,
Gastón Kleiman
/slave.cpp ed92f672f5155d70a36ba3619bb6f06fa09bc836
src/tests/slave_tests.cpp 9168e06348a83dcb20400a2fe0e3bb1f26e6ff1b
Diff: https://reviews.apache.org/r/69794/diff/5/
Changes: https://reviews.apache.org/r/69794/diff/4-5/
Testing
---
Current tests still pass.
Thanks,
Gastón Kleiman
new proto with both cmake and autotools.
Thanks,
Gastón Kleiman
---
Thanks,
Gastón Kleiman
/
Testing
---
`GLOG_v=1 bin/mesos-tests.sh --verbose
--gtest_filter="*Slave*RetryOperationStatusUpdateAfterRecovery*"
--gtest_repeat=5000 --gtest_break_on_failure` passed on CentOS 7.4.1708.
Thanks,
Gastón Kleiman
/69795/diff/4-5/
Testing
---
Current tests still pass.
Thanks,
Gastón Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69786/#review212351
---
Ship it!
Ship It!
- Gastón Kleiman
On Jan. 17, 2019, 6:30
1 - 100 of 781 matches
Mail list logo
