Re: Review Request 44553: Added authentication to agent HTTP endpoints.

tps://reviews.apache.org/r/44553/#comment185316> http::get() - Joerg Schad On March 11, 2016, 9:52 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

> On March 11, 2016, 2:29 p.m., Joerg Schad wrote: > > src/tests/slave_tests.cpp, line 1435 > > <https://reviews.apache.org/r/44553/diff/3/?file=1295709#file1295709line1435> > > > > Should we add a comment that authn is required by default? required -

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

s/slave_tests.cpp (line 1469) <https://reviews.apache.org/r/44553/#comment185312> I would combine both test cases into a single one, saves code and setup time. Feel free to drop with good reason to keep them seperate. - Joerg Schad On

Review Request 44702: Added missing blank line in reservation_test.

--- Added missing blank line in reservation_test. Diffs - src/tests/reservation_tests.cpp d7f9de6f2bce061316916260f356efdb96ecd482 Diff: https://reviews.apache.org/r/44702/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

://reviews.apache.org/r/44087/diff/ Testing --- sudo make check (on Linux) Thanks, Joerg Schad

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

entHook. > > > Diffs > - > > src/slave/containerizer/mesos/linux_launcher.cpp > 9c80cfb621ef2e28aabfb2649846892964d2d4f3 > > Diff: https://reviews.apache.org/r/44087/diff/ > > > Testing > --- > > sudo make check (on Linux) > > > Thanks, > > Joerg Schad > >

Re: Review Request 44652: Omitted names of unused parameters in command executor.

case I don't believe it makes a large difference as the Type is descriptive enough, but that might be different with more general types (imagine a string). - Joerg Schad On March 10, 2016, 5:14 p.m., Alexander Rukletsov

Re: Review Request 44515: Added agent flags for HTTP authentication.

g/r/44515/#comment185037> Did you add those flags to configuration.md or do you plan to do this via your script? - Joerg Schad On March 10, 2016, 3:52 p.m., Greg Mann wrote: > > --- > This is an automatically generated e

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 Diff: https://reviews.apache.org/r/44621/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 Diff: https://reviews.apache.org/r/44621/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 44186: Added authentication to master endpoints.

e.org/r/44186/#review122886 --- On March 10, 2016, 10:31 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44186/ > --

Re: Review Request 44186: Added authentication to master endpoints.

--- make check Thanks, Joerg Schad

Re: Review Request 44186: Added authentication to master endpoints.

------ On March 10, 2016, 10:31 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44186/ > ---

Re: Review Request 43798: Added overview section to upgrades.md.

://reviews.apache.org/media/uploaded/files/2016/02/29/44ca4c96-5849-45b9-b1de-0be25630fbaa__Screen_Shot_2016-02-29_at_3.15.12_AM.png Rendered Website https://reviews.apache.org/media/uploaded/files/2016/03/08/dae6b1ea-a627-4198-b5ad-8e744120ab68__Screen_Shot_2016-03-08_at_15.06.55.png Thanks, Joerg Schad

Re: Review Request 43798: Added overview section to upgrades.md.

/2016/02/29/44ca4c96-5849-45b9-b1de-0be25630fbaa__Screen_Shot_2016-02-29_at_3.15.12_AM.png Rendered Website https://reviews.apache.org/media/uploaded/files/2016/03/08/dae6b1ea-a627-4198-b5ad-8e744120ab68__Screen_Shot_2016-03-08_at_15.06.55.png Thanks, Joerg Schad

Re: Review Request 43798: Added overview section to upgrades.md.

/uploaded/files/2016/02/29/44ca4c96-5849-45b9-b1de-0be25630fbaa__Screen_Shot_2016-02-29_at_3.15.12_AM.png Thanks, Joerg Schad

Re: Review Request 43798: Added overview section to upgrades.md.

/2016/02/29/44ca4c96-5849-45b9-b1de-0be25630fbaa__Screen_Shot_2016-02-29_at_3.15.12_AM.png HTML Table https://reviews.apache.org/media/uploaded/files/2016/03/08/72054577-c08b-46b8-8d76-4b26541f179f__Screen_Shot_2016-03-08_at_14.32.04.png Thanks, Joerg Schad

Re: Review Request 43798: Added overview section to upgrades.md.

/2016/02/29/44ca4c96-5849-45b9-b1de-0be25630fbaa__Screen_Shot_2016-02-29_at_3.15.12_AM.png Thanks, Joerg Schad

Re: Review Request 43798: Added overview section to upgrades.md.

/2016/02/29/44ca4c96-5849-45b9-b1de-0be25630fbaa__Screen_Shot_2016-02-29_at_3.15.12_AM.png Thanks, Joerg Schad

Re: Review Request 43798: Added overview section to upgrades.md.

://reviews.apache.org/media/uploaded/files/2016/02/29/44ca4c96-5849-45b9-b1de-0be25630fbaa__Screen_Shot_2016-02-29_at_3.15.12_AM.png Thanks, Joerg Schad

Re: Review Request 43798: Added overview section to upgrades.md.

AM.png https://reviews.apache.org/media/uploaded/files/2016/02/29/44ca4c96-5849-45b9-b1de-0be25630fbaa__Screen_Shot_2016-02-29_at_3.15.12_AM.png Thanks, Joerg Schad

Re: Review Request 43798: Added overview section to upgrades.md.

/2016/02/29/44ca4c96-5849-45b9-b1de-0be25630fbaa__Screen_Shot_2016-02-29_at_3.15.12_AM.png Thanks, Joerg Schad

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

docker website container. Thanks, Joerg Schad

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

docker website container. Thanks, Joerg Schad

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

proper use of the the schedulerDriver... - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review120465 -----

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

container. Thanks, Joerg Schad

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

Will remove `= 0` from both parts - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review120465 ------- On Feb. 22, 2016, 3 a.m., Joerg Schad wrote: > > ---

Re: Review Request 44286: Unified/Added Future checks for http methods in tests.

eply, visit: https://reviews.apache.org/r/44286/#review122274 ------- On March 2, 2016, 8:53 p.m., Joerg Schad wrote: > > --- > This is an automatically g

Re: Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.

. Diffs - src/tests/reservation_endpoints_tests.cpp f3a143812aa10bc445ac5d27c00318e91eb086aa Diff: https://reviews.apache.org/r/44227/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 44186: Added authentication to master endpoints.

, Joerg Schad

Re: Review Request 44186: Added authentication to master endpoints.

fc3a72894631279460ee7971a4627d73c3d8c351 src/tests/status_update_manager_tests.cpp d64d3b8c96270478f6b681c038de77c3a9eb68fe Diff: https://reviews.apache.org/r/44186/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 44339: Disabled Appc simple fetch test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44339/#review121871 --- Isn't there already a CurlFilter for tests? - Joerg Schad

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

/r/44087/diff/ Testing --- sudo make check (on Linux) Thanks, Joerg Schad

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

://reviews.apache.org/r/44087/diff/ Testing --- sudo make check (on Linux) Thanks, Joerg Schad

Re: Review Request 44314: Added authentication to http master endpoint tests.

/status_update_manager_tests.cpp d64d3b8c96270478f6b681c038de77c3a9eb68fe Diff: https://reviews.apache.org/r/44314/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 44186: Added authentication to master endpoints.

bb104562659e135492f9857e5b452c8a0a9e97da src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 src/tests/status_update_manager_tests.cpp d64d3b8c96270478f6b681c038de77c3a9eb68fe Diff: https://reviews.apache.org/r/44186/diff/ Testing --- make check Thanks, Joerg Schad

Review Request 44314: Added authentication to http master endpoint tests.

d64d3b8c96270478f6b681c038de77c3a9eb68fe Diff: https://reviews.apache.org/r/44314/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 44186: Added authenticated to master endpoints.

/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 44186: Added authentication to master endpoints.

/status_update_manager_tests.cpp d64d3b8c96270478f6b681c038de77c3a9eb68fe Diff: https://reviews.apache.org/r/44186/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 44286: Unified/Added Future checks for http methods in tests.

/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf Diff: https://reviews.apache.org/r/44286/diff/ Testing --- sudo make check Thanks, Joerg Schad

Review Request 44247: Remove race condition from filesystem_isolator_tests.cpp.

/ Testing --- sudo make check Thanks, Joerg Schad

Re: Review Request 44110: Updated flag examples to refer to /metrics/snapshot instead of stats.json.

/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d Diff: https://reviews.apache.org/r/44110/diff/ Testing --- make test + manually checked the flags example. Thanks, Joerg Schad

Re: Review Request 44112: Updated tests to use /state endpoint.

982468f851cd9d95eb6cde7c57f2d737d46a827c src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 Diff: https://reviews.apache.org/r/44112/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 44111: Updated UI controller to use master/state endpoint.

56a44fccdc2a004463576c710f9eb117646514a2 Diff: https://reviews.apache.org/r/44111/diff/ Testing --- make check + manually checked the UI Thanks, Joerg Schad

Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.

/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 44110: Updated flag examples to refer to /metrics/snapshot instead of stats.json.

--- make test + manually checked the flags example. Thanks, Joerg Schad

Review Request 44144: Improved the documentation for setting ACLs.

Thanks, Joerg Schad

Re: Review Request 44112: Updated tests to use /state endpoint.

982468f851cd9d95eb6cde7c57f2d737d46a827c src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 Diff: https://reviews.apache.org/r/44112/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 44111: Updated UI controller to use master/state endpoint.

56a44fccdc2a004463576c710f9eb117646514a2 Diff: https://reviews.apache.org/r/44111/diff/ Testing --- make check + manually checked the UI Thanks, Joerg Schad

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

2353e78a80548b63f871c52e840ffe2fe869f4d7 src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d Diff: https://reviews.apache.org/r/44110/diff/ Testing --- make test + manually checked the flags example. Thanks, Joerg Schad

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d Diff: https://reviews.apache.org/r/44110/diff/ Testing --- make test + manually checked the flags example. Thanks, Joerg Schad

Re: Review Request 43798: Added overview section to upgrades.md.

s - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/#review120924 --- On Feb. 23, 2016, 9:39 p.m., Jo

Re: Review Request 43798: Added overview section to upgrades.md.

://reviews.apache.org/r/43798/diff/ Testing --- Viewed via gist (https://gist.github.com/joerg84/eddbc0302a5a4b291e81) and docker website container. Thanks, Joerg Schad

Re: Review Request 43798: Added overview section to upgrades.md.

/ Testing --- Viewed via gist (https://gist.github.com/joerg84/eddbc0302a5a4b291e81) and docker website container. Thanks, Joerg Schad

Re: Review Request 43838: Added note about not implemented requestResources call.

sure for all others. I will check. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43838/#review120253 ------- On Feb. 22, 2016, 4:54 p.m., Joerg Schad wrote: > > ---

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

5f771f02db9bd098f3cd36730cd84bf2f5e87a33 Diff: https://reviews.apache.org/r/43588/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 37168: Added example for dynamic reservation features.

amework_test.sh (line 30) <https://reviews.apache.org/r/37168/#comment181637> Thy do we need this? Comparing to persistent_volume_framework_test.sh src/tests/examples_tests.cpp (line 36) <https://reviews.apache.org/r/37168/#comment181636> additional blank line. - Joerg Schad

Re: Review Request 43850: Added a wait for killed tast to prevent misscount of events.

) <https://reviews.apache.org/r/43850/#comment181621> Maybe rename this to runningStatus? src/tests/containerizer/memory_pressure_tests.cpp (line 292) <https://reviews.apache.org/r/43850/#comment181623> Do we still need this at this point? - Joerg Schad On Feb. 22, 20

Review Request 43849: Fixed typos in subprocess.cpp comments.

Description --- Fixed typos in subprocess.cpp comments. Diffs - 3rdparty/libprocess/src/subprocess.cpp 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c Diff: https://reviews.apache.org/r/43849/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

eviews.apache.org/r/43588/#review119257 --- On Feb. 15, 2016, 9:23 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 43798: Added overview section to upgrades.md.

. Diffs (updated) - docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 Diff: https://reviews.apache.org/r/43798/diff/ Testing --- Viewed via gist (https://gist.github.com/joerg84/eddbc0302a5a4b291e81) and docker website container. Thanks, Joerg Schad

Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

apache.org/jira/browse/MESOS-4734) Adapted to your proposed format. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43792/#review120129 --- On Feb. 22, 2016, 6 p.m., Joerg Scha

Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

--- Viewed in github (https://gist.github.com/joerg84/3cd9077f3446a6c6bb50) and via docker website renderer. Thanks, Joerg Schad

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

(https://gist.github.com/joerg84/74e065fbcfd130d90cf7) and Docker website container. Thanks, Joerg Schad

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

ollow up by making the other files consistent. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43634/#review120127 ------- On

Review Request 43838: Added note about not implemented requestResources call.

bf866f5ebece2505eaa27bf39a1382cd1a2a069a Diff: https://reviews.apache.org/r/43838/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review120091 --- On Feb. 22, 2016, 3 a.m., Joerg Schad wrote: > >

Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

/b4bf279a55e1b62051e6) and via docker website container. Thanks, Joerg Schad

Re: Review Request 43798: Added overview section to upgraded.md.

/ Testing --- Viewed via gist (https://gist.github.com/joerg84/eddbc0302a5a4b291e81) and docker website container. Thanks, Joerg Schad

Re: Review Request 43798: Added overview section to upgraded.md.

/ Testing --- Viewed via gist (https://gist.github.com/joerg84/eddbc0302a5a4b291e81) and docker website container. Thanks, Joerg Schad

Review Request 43798: Added overview section to upgraded.md.

://gist.github.com/joerg84/eddbc0302a5a4b291e81) and docker website container. Thanks, Joerg Schad

Re: Review Request 43792: Made bullet point structure consistent in ugrades.md.

) - docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 Diff: https://reviews.apache.org/r/43792/diff/ Testing --- Viewed in github (https://gist.github.com/joerg84/3cd9077f3446a6c6bb50) and via docker website renderer. Thanks, Joerg Schad

Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

: https://reviews.apache.org/r/43792/diff/ Testing --- Viewed in github (https://gist.github.com/joerg84/3cd9077f3446a6c6bb50) and via docker website renderer. Thanks, Joerg Schad

Review Request 43792: Made bullet point structure consistent in upgrades.md.

docker website renderer. Thanks, Joerg Schad

Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

e1ca81dab85a7ab1391eca0d6bd995548bf79c22 Diff: https://reviews.apache.org/r/43769/diff/ Testing --- Thanks, Joerg Schad

Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

: mesos Description --- Added note about resending of KillTaskMessages between Master and Agent. Diffs - src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 Diff: https://reviews.apache.org/r/43769/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 43583: Added documentation for multiple-disk support.

. - Joerg Schad On Feb. 16, 2016, 9:43 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 43633: Improved Multiple Disk documentation.

-volume.md 728854076595a0908a17d85482a7031acfbb09a0 Diff: https://reviews.apache.org/r/43633/diff/ Testing --- viewed via docker website container. Thanks, Joerg Schad

Review Request 43633: Improved Multiple Disk documentation.

728854076595a0908a17d85482a7031acfbb09a0 Diff: https://reviews.apache.org/r/43633/diff/ Testing --- viewed via docker website container. Thanks, Joerg Schad

Re: Review Request 43583: Added documentation for multiple-disk support.

lume.md (line 29) <https://reviews.apache.org/r/43583/#comment180684> s/Multiple Disk/multiple disk consistent capitalization with the above doc. - Joerg Schad On Feb. 16, 2016, 9:43 p.m., Joris Van Remoortere wrote: > > --- &g

Re: Review Request 43583: Added documentation for multiple-disk support.

ee quota.md). - Joerg Schad On Feb. 16, 2016, 9:43 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

ttps://reviews.apache.org/r/41950. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43588/#review119257 --- On Feb. 15, 2

Review Request 43588: Added allocator recovery tests in presence of quota.

/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 43582: Added flag to disable system support.

g/r/43582/#comment180517> Regarding the summary: s/`to disable system support.`/`to disable systemd support`? - Joerg Schad On Feb. 15, 2016, 5:59 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically g

Re: Review Request 43582: Added flag to disable system support.

> On Feb. 15, 2016, 6:35 p.m., Joerg Schad wrote: > > src/slave/flags.hpp, line 97 > > <https://reviews.apache.org/r/43582/diff/2/?file=1241721#file1241721line97> > > > > Should we document this in configure.md? Or are we generating this automatically af

Re: Review Request 43582: Added flag to disable system support.

l `true` would be easier to read. - Joerg Schad On Feb. 15, 2016, 5:59 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > <https://reviews.apache.org/r/43093/diff/3/?file=1233160#file1233160line307> > > > > Are these additional checks which should apply in both cases (i.e. > > de

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

r/docker.cpp (line 322) <https://reviews.apache.org/r/43093/#comment179655> We don't end log messages with a period. hanks - Joerg Schad On Feb. 4, 2016, 9:27 p.m., Travis Hegner wrote: > > --- > This is an aut

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

On Feb. 9, 2016, 7:13 p.m., Travis Hegner wrote: > > hanks Oh btw regarding the commit message: We usually have commit messages stating what changed, so in your case it could be something along the lines of 'Added support for new docker network setting.' - Joerg

Re: Review Request 43324: Updated endpoints/index.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43324/#review118208 --- Ship it! Ship It! - Joerg Schad On Feb. 8, 2016, 7:07 a.m

Re: Review Request 43319: Remove md files from doxygen.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43319/#review118205 --- Ship it! Ship It! - Joerg Schad On Feb. 8, 2016, 12:40 a.m

Re: Review Request 43202: Fixed rendering error in quota docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43202/#review117859 --- Ship it! Ship It! - Joerg Schad On Feb. 4, 2016, 6:51 p.m

Re: Review Request 42754: Added support for labels to resource reservations.

> On Feb. 3, 2016, 8:38 p.m., Joerg Schad wrote: > > src/tests/resources_tests.cpp, line 1756 > > <https://reviews.apache.org/r/42754/diff/2/?file=1221650#file1221650line1756> > > > > Isn't this already checked above? > > Neil Conway wrote: > Hm

Re: Review Request 42755: Added documentation for labeled reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/#review117675 --- Ship it! After previous issues are resolved :-). - Joerg

Re: Review Request 42754: Added support for labels to resource reservations.

volume we have one blank line between the last `stream <<` and return statement. - Joerg Schad On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote: > > --- > This is an automatically generate

Re: Review Request 42755: Added documentation for labeled reserved resources.

vely we can change all others to agent, but should be consistent. docs/reservation.md (line 81) <https://reviews.apache.org/r/42755/#comment178951> into a single reservation despite having the same role. - Joerg Schad On Feb. 3, 2016, 5:51 p.m.,

Re: Review Request 42750: Used `std::any_of` instead of `std::count_if` when validating IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42750/#review117626 --- Ship it! Ship It! - Joerg Schad On Jan. 25, 2016, 10:49 p.m

Re: Review Request 42751: Tweaked some resource test cases.

ce(begin,end)) just to get the item count looks unintuitive here. I see that is currently the easiest way given Resources, but maybe it makes sense to add a count() or similar function to Resources (Not a real issue for me for this review). - Joerg Schad On Jan. 25, 2016, 10:59 p.m.,

Re: Review Request 42752: Fixed some typos in test case comments.

/port_mapping_tests.cpp (line 2116) <https://reviews.apache.org/r/42752/#comment178882> s/destroy/destruction? - Joerg Schad On Jan. 25, 2016, 10:59 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 42753: Allowed `createLabel` to take an optional "value".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42753/#review117638 --- Ship it! Ship It! - Joerg Schad On Jan. 25, 2016, 11 p.m

<    1   2   3   4   5   6   7   8   9   10   >