/diff/
Testing
---
make check
Thanks,
Till Toenshoff
390>
Lets keep this one.
- Till Toenshoff
On Feb. 7, 2017, 7:49 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55771/#review164621
---
Rebase please.
- Till Toenshoff
On Feb. 7, 2017, 7:49 p.m
ld look like this;
```
Checking C++ standard library has undefined behaviour with selected
optimization level... no
```
- Till Toenshoff
On Jan. 23, 2017, 11:33 a.m., Benjamin Bannier wrote:
>
> ---
> This is an a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55771/#review162802
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 23, 2017, 11:33
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55772/#review162801
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 23, 2017, 11:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55773/#review162800
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 21, 2017, 12:23
<https://reviews.apache.org/r/55037/#comment231208>
By not adding `syswow64` we are excluding 32bit runnables, is this
intentional and documented? Is this still a thing on windows?
- Till Toenshoff
On Dec. 26, 2016, 9:53 a.m., Alex C
of those changes are unrelated to ARM64 and hence not strictly
within the scope
of this ticket -- so we do not need those changes. However, having things in
sync with upstream
is definitely valuable and in these specific cases appears to be free of
additional risks.
- Till Toenshoff
On Dec
ddress), 16, stack->size)
!=
0) {
return -1;
}
```
- Till Toenshoff
On Dec. 22, 2016, 9:24 p.m., Aaron Wood wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55006/#review160157
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 23, 2016, 2:22
/CMakeLists.txt (line 67)
<https://reviews.apache.org/r/55005/#comment231206>
s/process-tests/libprocess-tests/ ?
- Till Toenshoff
On Dec. 23, 2016, 2:09 a.m., Michael Park wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55004/#review160155
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 23, 2016, 2:09
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54896/#review159943
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 21, 2016, 11:20
> On Dec. 14, 2016, 1:25 p.m., Till Toenshoff wrote:
> > thanks for cleaning up Benjamin - the CI and hence the entire team will
> > appreciate :)
Quick note, Benjamin also did a quick sweep over the entire codebase to check
for further instances of this issue and it seems we
the entire team will
appreciate :)
- Till Toenshoff
On Dec. 14, 2016, 12:45 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54702/#review158997
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 13, 2016, 12:53
> On Dec. 9, 2016, 3:46 p.m., Till Toenshoff wrote:
> > docs/health-checks.md, line 306
> > <https://reviews.apache.org/r/54570/diff/2/?file=1580448#file1580448line306>
> >
> > I wonder how significant this overhead is. Do we have any profiling
> > inf
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54571/#review158687
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 9, 2016, 4:23
tps://reviews.apache.org/r/54570/#comment229479>
I wonder how significant this overhead is. Do we have any profiling
information we could add to the ticket for reasoning?
- Till Toenshoff
On Dec. 9, 2016, 3:11 p.m., Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54553/#review158679
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 8, 2016, 11:05
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54554/#review158678
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 8, 2016, 11:05
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54555/#review158677
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 8, 2016, 11:05
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54205/#review158673
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 8, 2016, 1:57
tps://reviews.apache.org/r/54205/#comment229284>
Would it make sense to not cast into an int at all here, now that we got
the epsilon covered?
- Till Toenshoff
On Nov. 30, 2016, 12:41 p.m., Benjamin Bannier wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54426/#review158519
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 8, 2016, 12:47
(updated)
-
src/slave/container_loggers/lib_logrotate.cpp
27726abd7f5bd42b0f368f00c524c7eaabee38c0
Diff: https://reviews.apache.org/r/54494/diff/
Testing
---
make check
Thanks,
Till Toenshoff
/lib_logrotate.cpp
27726abd7f5bd42b0f368f00c524c7eaabee38c0
Diff: https://reviews.apache.org/r/54494/diff/
Testing
---
make check
Thanks,
Till Toenshoff
/diff/
Testing
---
make check
Thanks,
Till Toenshoff
://issues.apache.org/jira/browse/MESOS-6747
Repository: mesos
Description
---
see summary.
Diffs
-
src/slave/container_loggers/lib_logrotate.cpp
27726abd7f5bd42b0f368f00c524c7eaabee38c0
Diff: https://reviews.apache.org/r/54494/diff/
Testing
---
make check
Thanks,
Till
limited` and not `unbegrenzt` or alike :)
src/tests/containerizer/posix_rlimits_isolator_tests.cpp (line 202)
<https://reviews.apache.org/r/54035/#comment228002>
See above on failure-reason.
- Till Toenshoff
On Nov. 23, 2016, 4:35 p.m., Benj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54034/#review157406
---
Ship it!
Ship It!
- Till Toenshoff
On Nov. 23, 2016, 4:35
ttps://reviews.apache.org/r/54174/#review157322
---
On Nov. 29, 2016, 7:54 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
://reviews.apache.org/r/54129/diff/
Testing
---
make check
Thanks,
Till Toenshoff
---
make check and sudo tests
Thanks,
Till Toenshoff
/manager.cpp 59f402b1f8f076b151b771b2b1ae89a3b4d34d5b
src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941
Diff: https://reviews.apache.org/r/54174/diff/
Testing
---
make check and sudo tests
Thanks,
Till Toenshoff
5ce4667b61bb226f726beda6e21b839456e0b941
src/tests/hook_tests.cpp d334d6c5ff7f966d55b395bfbf4f25ee3fa2
Diff: https://reviews.apache.org/r/54129/diff/
Testing
---
make check
Thanks,
Till Toenshoff
d334d6c5ff7f966d55b395bfbf4f25ee3fa2
Diff: https://reviews.apache.org/r/54128/diff/
Testing (updated)
---
make check and sudo tests
Thanks,
Till Toenshoff
/
Testing
---
make check
Thanks,
Till Toenshoff
Arya.
Repository: mesos
Description
---
see summary.
Diffs
-
src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941
Diff: https://reviews.apache.org/r/54165/diff/
Testing
---
make check
Thanks,
Till Toenshoff
-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0
```
Thanks,
Till Toenshoff
d334d6c5ff7f966d55b395bfbf4f25ee3fa2
Diff: https://reviews.apache.org/r/54128/diff/
Testing
---
make check in isolation
NOTE: This test and the test-hook is breaking other tests -- we need to remove
the superceded hooks ASAP and then we can land this.
Thanks,
Till Toenshoff
---
make check
Thanks,
Till Toenshoff
d334d6c5ff7f966d55b395bfbf4f25ee3fa2
Diff: https://reviews.apache.org/r/54116/diff/
Testing
---
make check && functional testing
Thanks,
Till Toenshoff
5e91a71f2450cf3c37eb9039ef28c026095c917e
src/hook/manager.hpp 5ecfcab48da808c84d36f9bcfcb5a8e0ad2167e5
src/hook/manager.cpp 24885226a788a7abd851e12b527f74fa972ec935
Diff: https://reviews.apache.org/r/54068/diff/
Testing
---
make check && functional testing of entire RR chain.
Thanks,
Till Toenshoff
,
Till Toenshoff
5ecfcab48da808c84d36f9bcfcb5a8e0ad2167e5
src/hook/manager.cpp 24885226a788a7abd851e12b527f74fa972ec935
Diff: https://reviews.apache.org/r/54068/diff/
Testing
---
make check && functional testing of entire RR chain.
Thanks,
Till Toenshoff
> > ```
Doh :)
> On Nov. 24, 2016, 3:38 a.m., Adam B wrote:
> > src/slave/containerizer/docker.cpp, lines 1178-1179
> > <https://reviews.apache.org/r/54038/diff/1/?file=1569514#file1569514line1178>
> >
> > I still don't understand why `sandboxDirectory = container->directory`
> > and `mappedDire
*
Thanks,
Till Toenshoff
)
<https://reviews.apache.org/r/53611/#comment227172>
s/After the/After this/?
really unsure here :)
include/mesos/v1/mesos.proto (line 408)
<https://reviews.apache.org/r/53611/#comment227173>
see above?
- Till Toenshoff
On Nov. 24, 2016, 11:29 a.m., Alexander Ruk
views.apache.org/r/53610/#comment227170>
s/For example/As an example/ ?
- Till Toenshoff
On Nov. 24, 2016, 11:29 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To
/docker.cpp ccabf99f305d7874e1c46bc618ea74341eb281ef
Diff: https://reviews.apache.org/r/54038/diff/
Testing
---
make check
*WIP - functional test pending - unit tests pending - WIP*
Thanks,
Till Toenshoff
:
https://reviews.apache.org/r/53877/#review156658
-------
On Nov. 22, 2016, 10:01 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-
mesos/sandbox
MESOS_CONTAINER_NAME=mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0
```
Thanks,
Till Toenshoff
s://reviews.apache.org/r/53877/#review156618
-------
On Nov. 22, 2016, 7:36 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail.
r.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c
Diff: https://reviews.apache.org/r/53998/diff/
Testing
---
make check
* WIP - functional testing pending - WIP *
Thanks,
Till Toenshoff
org/r/53998/diff/
Testing
---
make check
* WIP - functional testing pending - WIP *
Thanks,
Till Toenshoff
puDS
foo=bar
MESOS_SANDBOX=/mnt/mesos/sandbox
MESOS_CONTAINER_NAME=mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0
```
Thanks,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53615/#review156572
---
Ship it!
Ship It!
- Till Toenshoff
On Nov. 9, 2016, 5:08
oint /bin/sh --name
mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0
alpine -c sleep 200
```
```
$ more /tmp/l53ILz/ktpuDS
foo=bar
MESOS_SANDBOX=/mnt/mesos/sandbox
MESOS_CONTAINER_NAME=mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0
```
Thanks,
Till Toenshoff
s patch too close to the
docker-home configuration temp folder.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53877/#review156306
------
oint /bin/sh --name
mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0
alpine -c sleep 200
```
```
$ more /tmp/l53ILz/ktpuDS
foo=bar
MESOS_SANDBOX=/mnt/mesos/sandbox
MESOS_CONTAINER_NAME=mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0
```
Thanks,
Till Toenshoff
oint /bin/sh --name
mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0
alpine -c sleep 200
```
```
$ more /tmp/l53ILz/ktpuDS
foo=bar
MESOS_SANDBOX=/mnt/mesos/sandbox
MESOS_CONTAINER_NAME=mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0
```
Thanks,
Till Toenshoff
3d18-44f1-a562-9f759c281da0
```
Thanks,
Till Toenshoff
sh --name
mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0
alpine -c sleep 200
```
```
$ more /tmp/l53ILz/ktpuDS
foo=bar
MESOS_SANDBOX=/mnt/mesos/sandbox
MESOS_CONTAINER_NAME=mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0
```
Thanks,
Till Toenshoff
pitalize "out"?
Nope :)
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53772/#review155922
---
On Nov
and manually inspected those results
Thanks,
Till Toenshoff
Rukletsov.
Repository: mesos
Description
---
see summary.
Diffs
-
site/data/releases.yml 1e9bb8555d266658baaf37c4b608eebeb0d14da8
Diff: https://reviews.apache.org/r/53773/diff/
Testing (updated)
---
Thanks,
Till Toenshoff
erate with that on this patch.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53308/#review155592
---
On Oct. 31
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53531/#review155130
---
Ship it!
Ship It!
- Till Toenshoff
On Nov. 7, 2016, 1:07
.
Repository: mesos
Description
---
see summary.
Diffs
-
include/mesos/hook.hpp c8a58641e0768628a9028a70d8c28f7fb412
Diff: https://reviews.apache.org/r/52853/diff/
Testing
---
no functional change - make check
Thanks,
Till Toenshoff
.
Repository: mesos
Description
---
see summary.
Diffs
-
include/mesos/hook.hpp c8a58641e0768628a9028a70d8c28f7fb412
Diff: https://reviews.apache.org/r/52853/diff/
Testing
---
no functional change - make check
Thanks,
Till Toenshoff
-
cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2
Diff: https://reviews.apache.org/r/53380/diff/
Testing
---
cmake ..;make (+functional check)
Thanks,
Till Toenshoff
/Process3rdpartyConfigure.cmake
3ef9040e9fe37058886aea0480582886c255ccb8
Diff: https://reviews.apache.org/r/53379/diff/
Testing
---
cmake ..;make (+functional check)
Thanks,
Till Toenshoff
6650c7c12b188b08c70cfee72b3200e83e7a1cd2
Diff: https://reviews.apache.org/r/53380/diff/
Testing
---
cmake ..;make (+functional check)
Thanks,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53304/#review155121
---
Ship it!
Ship It!
- Till Toenshoff
On Nov. 7, 2016, 11:16
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53381/#review154815
---
Ship it!
Ship It!
- Till Toenshoff
On Nov. 3, 2016, 1:33
--
>
> (Updated Nov. 3, 2016, 9:27 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This change includes:
> * Automatic enumeration of lists.
> * T
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53382/#review154807
---
Ship it!
Modulo Vinod's comments.
- Till Toenshoff
O
Good to call out indeed!
- Till Toenshoff
On Nov. 3, 2016, 1:34 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
)
<https://reviews.apache.org/r/53429/#comment224491>
While the reader COULD have picked this pattern up from the linked
dashboard, I still think it is really valuable to call that query out here.
- Till Toenshoff
On Nov. 3, 2016, 2:12 p.m., Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51609/#review154584
---
Ship it!
Ship It!
- Till Toenshoff
On Oct. 31, 2016, 6:56
tps://reviews.apache.org/r/51608/#comment224199>
See MESOS-6533
- Till Toenshoff
On Oct. 31, 2016, 6:56 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
> On Nov. 2, 2016, 4:29 p.m., Till Toenshoff wrote:
> > src/health-check/health_checker.cpp, line 77
> > <https://reviews.apache.org/r/51607/diff/3/?file=1549257#file1549257line77>
> >
> > Some abstraction doing this automagically would be cool to have, no?
Not a big fan of such messages for our users.
However I feel this surpasses the scope of this review and should be
discussed in a more general way (if at all).
- Till Toenshoff
On Oct. 31, 2016, 6:56 p.m., Ale
> On Nov. 2, 2016, 1:26 p.m., Till Toenshoff wrote:
> > Thanks for https://issues.apache.org/jira/browse/MESOS-6309 -- we need to
> > fix that immediately, it is just too bizarre to leave as is.
Just proposed a fix for the above by https://reviews.apache.org/r/53
..;make (+functional check)
Thanks,
Till Toenshoff
/53379/diff/
Testing
---
cmake ..;make (+functional check)
Thanks,
Till Toenshoff
/MESOS-6309 -- we need to fix
that immediately, it is just too bizarre to leave as is.
- Till Toenshoff
On Oct. 31, 2016, 6:55 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
> On Nov. 2, 2016, 11:33 a.m., Till Toenshoff wrote:
> > Ship It!
modulo my comments :)
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51605/#rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51605/#review154538
---
Ship it!
Ship It!
- Till Toenshoff
On Oct. 31, 2016, 6:55
he.org/r/51605/#comment224143>
Missing `endl`
src/health-check/tcp_connect.cpp (line 88)
<https://reviews.apache.org/r/51605/#comment224140>
s/socketFd/socket/
- Till Toenshoff
On Oct. 31, 2016, 6:55 p.m., Alexander Rukletsov wrote:
>
>
---
make check and functional test in a hook-module
Thanks,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53084/#review154119
---
Ship it!
Ship It!
- Till Toenshoff
On Oct. 28, 2016, 11:41
://reviews.apache.org/r/53084/
> ---
>
> (Updated Oct. 27, 2016, 3:49 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, haosdent huang, Jie Yu, Till
> Toenshoff, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> `LIBPROCESS_SSL_
nd see if you can play along a bit more in line.
- Till Toenshoff
On Oct. 24, 2016, 9:05 a.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
the LIBPROCESS_SSL_ version.
```
- Till Toenshoff
On Oct. 21, 2016, 11:36 a.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apa
What are we trying to achieve here?
- Till Toenshoff
On Oct. 18, 2016, 10:47 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53055/#review153385
---
Ship it!
Ship It!
- Till Toenshoff
On Oct. 20, 2016, 11:52
:)
- Till Toenshoff
On Oct. 17, 2016, 10:12 a.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
501 - 600 of 1274 matches
Mail list logo
