----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52600/#review153194 -----------------------------------------------------------
Seems you got a lot more within this review than planned :) - Till Toenshoff On Oct. 17, 2016, 10:12 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52600/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2016, 10:12 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, and Till Toenshoff. > > > Bugs: MESOS-6401 > https://issues.apache.org/jira/browse/MESOS-6401 > > > Repository: mesos > > > Description > ------- > > Standarize the way in which authorization is perfomed by enabling > all actions suffixed with `_WITH_ROLE` and `_WITH_PRINCIPAL` to > perform authorization using whole protobuf messages instead of > forcing a single field from the message. > > While this change is still in the deprecation cycle, the original > value is also set. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 71319891a451bd1d565210dcce2fb61fc69e1f61 > 3rdparty/libprocess/configure.ac 1644035d7fe1a45c798b13dbfb3c66f74466f2a2 > 3rdparty/libprocess/include/process/deferred.hpp > ee902a6c8de48f17f7401ee7b3814d92eabd65f8 > 3rdparty/libprocess/src/openssl.cpp > 8e4e0490a84c46e8f4842cf567f55a3c988ad445 > 3rdparty/libprocess/src/process.cpp > 18a8e206f6f297157d246a94f374311be67cd782 > 3rdparty/libprocess/src/tests/CMakeLists.txt > 66597fd3021bc7c3c53cb0f38416edc85ace5a9b > 3rdparty/libprocess/src/tests/future_tests.cpp > 7c411c7be1849119fe0b070622dbe4488fa11b7a > 3rdparty/libprocess/src/tests/http_tests.cpp > 533104c93dd1eaf67bf3752163d2e0cad090078d > 3rdparty/libprocess/src/tests/limiter_tests.cpp > b80b1da214f97b50aa7b61b79bbf683fd01116aa > 3rdparty/libprocess/src/tests/metrics_tests.cpp > d7fdb06060b273e16be27a263b5ee268842aa25c > 3rdparty/libprocess/src/tests/process_tests.cpp > a4af54aa78c162bc0ecbe2f25796d8c9b12e0f31 > 3rdparty/libprocess/src/tests/reap_tests.cpp > 30518dee6c2fb904a607c7a457a5ec7366aab818 > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > 483ac1c5540d54921de1c1488ccb5e63b17ac481 > 3rdparty/libprocess/src/tests/time_tests.cpp > 08ddb56f1789f400b8cd072c53e885c759f13ddc > 3rdparty/stout/Makefile.am 4e10ae25a6c8a2d01d7b98b04ccf06a216611938 > 3rdparty/stout/README.md 693e3a3e76300f7fa6c6f6518497edf44cc9f6a2 > 3rdparty/stout/configure.ac cbb0fdb0e1584ace7bbd6bf496f0f55b9846ce0b > 3rdparty/stout/include/Makefile.am 1eb9c146d3eebacaea32e0f724d145f0c1dd676f > 3rdparty/stout/include/stout/flags/flags.hpp > 794a598169684c8474184b47de533498f3b234e0 > 3rdparty/stout/include/stout/gtest.hpp > b2f75b6c706df9de68edbac86a1e2dec32a574ed > 3rdparty/stout/include/stout/mac.hpp > 7ed5f38ae4f93e267406254cb2acff201faffe45 > 3rdparty/stout/include/stout/os.hpp > 96e8621b198a3ec4cce78e0a6ff5f271eda05ff1 > 3rdparty/stout/include/stout/os/linux.hpp > bf12e0b0577810c64cc8276ff0d987524327ffcd > 3rdparty/stout/include/stout/os/posix/killtree.hpp > f47f0d85f88bf69b5a9ae74e32d4f41c9f4a985a > 3rdparty/stout/include/stout/os/posix/shell.hpp > 70a9184e85ba322f1cd4ce5d12b963cd4b3ad500 > 3rdparty/stout/include/stout/os/raw/environment.hpp > b3e82ac8071b41748aeb098b7d5fcc210a1d3c43 > 3rdparty/stout/include/stout/os/wait.hpp > 5f6483c0d754dd1c1f5fdcfc542a0cc05c0a8df5 > 3rdparty/stout/include/stout/os/windows/rmdir.hpp > 4437484c068e9ef046e0be14683c97db447f2da1 > 3rdparty/stout/include/stout/os/windows/shell.hpp > 17e3d564564abebf1d558b7a7a277aef3c87e5ae > 3rdparty/stout/include/stout/windows/os.hpp > 7ca0b5dc9793369ea142684e3614e8f33cac64b6 > 3rdparty/stout/tests/CMakeLists.txt > e52aa62479a345bbcee70047109ebd80b8f9813d > 3rdparty/stout/tests/flags_tests.cpp > 201b16a6c040e32f8a14fa7a2520c86997c363ad > 3rdparty/stout/tests/ip_tests.cpp b5a206fe5fdcdadaa383698f505d87ddb2c6806d > 3rdparty/stout/tests/mac_tests.cpp d4560e75ae4e03d1765c599298e88842381690b9 > 3rdparty/stout/tests/os/process_tests.cpp > 4cb3b5fab389492bdc1258a27e821e60aef19dc8 > 3rdparty/stout/tests/os/rmdir_tests.cpp > 9aa4059d589e84f3c377163b1d6d2a278d4130b6 > 3rdparty/stout/tests/os_tests.cpp 0b7ee0723b6a608d6f110fa8ac16e0fd7b75ddea > CHANGELOG 2e0da96d055c7a4c228726c628d94f3414b2be86 > configure.ac 015255ec1876a51b9eb2cf488b375af90f73c722 > docs/app-framework-development-guide.md > de92c7570cd0d0ac8639ce50a79e5158844ac53c > docs/configuration.md c83a58eb6884c8d8c37880a745e04cf0b789ebdc > docs/contributors.yaml aa49acd188fada6659626d6cb9224c0dfc671f0f > docs/design-docs.md 7fafd09c7178559fedfa037faee0debfc29a927c > docs/docker-containerizer.md bab84dc2b0ce104b3ec59aaf0ef800b418a6517c > docs/executor-http-api.md a3b8d6f7cff4f182c8fb77dc216d82eca1d30e7c > docs/home.md 1c6b191bd194a9100ce1ad4bf5aff62a20ed8f41 > docs/oversubscription.md ec7194638003d90a1a7a6eab722fb6ea9ff56732 > docs/scheduler-http-api.md 958cfc52496b1585564e019f9ce8b06a623f2d5c > docs/shared-resources.md 29e43389c530f816118a32dcd7c2f1b82b0af431 > docs/upgrades.md 8e45fdbb485829930f9b918d1d6f24893228e873 > include/mesos/authorizer/authorizer.hpp > cb365c7d8d088f2810bde11b72dc20843a18fa51 > include/mesos/authorizer/authorizer.proto > b6a9f142eecbdfd59210872a92e3126f04de334c > include/mesos/docker/v2.proto 9b5bfb5d03ae8115c1b20a8c640640d6dbaa257d > include/mesos/executor.hpp 68cba9e3c411eb9f396b49adcc9d71137a5d948c > include/mesos/log/log.hpp d92d7a0b982c1c4bc0fdedde19fe012a6523a224 > include/mesos/master/master.proto 3553c683c17004ac1831ec90271aa8584c950e53 > include/mesos/mesos.proto 0017d3d9d46433b391703025f611ce437bbc7ebe > include/mesos/resources.hpp f569c931ff7db8d51dfd7c96f4f2addab05df85d > include/mesos/slave/container_logger.hpp > 939974736f9eb744c83036e074718d2a1eba8b0a > include/mesos/slave/containerizer.proto > 94e8cb4c37aa2a06c59726773834812c5eb660d8 > include/mesos/type_utils.hpp 88c7bcf7e8c3053e6e8bb78c67bf93b8276ac053 > include/mesos/v1/master/master.proto > 022b491b7d5c49c5aeddf4ffc97c148f55629c95 > include/mesos/v1/mesos.proto def33ef5e446576c86da0498e8a24e2e2de17918 > include/mesos/v1/resources.hpp f60ab794a0c7c24885c49cc47b798c363e3279e7 > src/CMakeLists.txt e60d34ca4b714bb237d5864b4682280f11b147a6 > src/Makefile.am 3bcc0f2dfc2c4f71841bd6d161f39e0e919fc0d7 > src/authorizer/local/authorizer.cpp > f1dff65d973fc84f4171f68fd0391a2343a96965 > src/cli/execute.cpp 600542b5dcdc5dc1fd171ef2d236968406eb0ab4 > src/cli_new/.gitignore 3ce5f74748dae6ac60170a1f0c73191fc26177d9 > src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af > src/cli_new/activate 65df76f4590caf8160435ccbc1d6b199b115f7f8 > src/cli_new/bin/config.py 274f8c63b0c642637f17aa2e3c8c4a8a5a059e37 > src/cli_new/bin/main.py bbfb52c894540158c70e0f50ebb8a277b692d54d > src/cli_new/bin/mesos c5152a2ebf8704c804bb4f39e46580a512aecdea > src/cli_new/bootstrap 6d62e9adf1d543ed00a3a2cf2484edf1c33ee443 > src/cli_new/deactivate 3dbe16765cad6f10523b1a3824608005e81b0944 > src/cli_new/lib/mesos/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb > src/cli_new/lib/mesos/docopt.py 86a4e9c74326fb80cc59487113f07358dd96960d > src/cli_new/lib/mesos/exceptions.py > c78f4a97debdb89cc9972c89c5c1ea249836713b > src/cli_new/lib/mesos/plugins/__init__.py > e743772afce3aad753be3cd2a923a4331bafc31c > src/cli_new/lib/mesos/plugins/base.py > 61b15428b029cec9ec7c9d89ab949959c3dc5b88 > src/cli_new/lib/mesos/util.py 87d2a65e78f04209566c1434b489b941d570ee01 > src/cli_new/mesos.bash_completion 21211819760c3a49566d32d4113116c9355182a5 > src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d40000318f2d0e439a6edf > src/cli_new/pylint.config c398220db063d249e6c62cf7e8cd6757e7860630 > src/common/http.cpp fb8454a97ad78c306d17b4222c14d68b3598175d > src/common/protobuf_utils.hpp 80c66c4f7d52fc184e7553d173195ba7714971d4 > src/common/protobuf_utils.cpp 7362b875ce1ffca6bc6376169a11494bdb9cf062 > src/common/resources.cpp 4bb9beffcb3509f4226b4985e05eccec01412d0f > src/common/type_utils.cpp c6cf4f1d4acd040d21434221e5469ca911404a39 > src/executor/executor.cpp 1d47b52d89eedee59d160badd6313d34e3bdb6d2 > src/health-check/health_checker.cpp > 96ae1a733ff3d211b84d0893b4603873af1c89f0 > src/java/jni/org_apache_mesos_state_AbstractState.cpp > 0f12f4f7763727da51edb72f8e16cc520a783e42 > src/java/src/org/apache/mesos/Executor.java > 078c0c7ea3ad68e9b4b40802c3d6b94084cbb69b > src/launcher/default_executor.cpp af4a97f7de5f2157aa65fdab742455b0683c40a4 > src/launcher/executor.cpp 3e95d6029bea0ce6e0dfb39c24b795fe98d90d13 > src/launcher/posix/executor.hpp d057ff6211a77e681ee80599d2ec5851a2fa6785 > src/launcher/posix/executor.cpp da0081c0e470aebb16d2e78031d276f5d7d2c726 > src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d > src/linux/fs.hpp da49c9ebfa938d169152ed3b6e4df7378711b013 > src/linux/fs.cpp 913e23317291db164fe6bdf77f3eca146dedec9b > src/local/local.cpp 257179443827ffdfc946ed655a6840fcea70d454 > src/log/CMakeLists.txt 8a92de4b0f9f69164930bd28c527f3a92ea0d17e > src/log/replica.cpp d596e617d4b4eab91245e0a88a3b9479fc75b813 > src/master/allocator/sorter/drf/metrics.cpp > 15aab32db5ca1a7a14080e9bbb7c65283be3ec20 > src/master/allocator/sorter/drf/sorter.cpp > 4ff153963229f2ecc73e05ba80f895c23e6a870e > src/master/http.cpp bb9c87327dfe2161a6f1fd4cded72aa9a5ffaf66 > src/master/main.cpp 9d2fd92dbc2fc5af166edec907adbdb541eb0dd3 > src/master/master.hpp 881f0d6127c4d6a7fccb1677fb3129310777f737 > src/master/master.cpp 3c6b18ead44cd5f2978093f5415e974cfcbfa714 > src/master/quota_handler.cpp d87d6c6266ba596c4e6bd36124f5a360428fe171 > src/master/validation.cpp f690a9eacd278b51a52f5588dbeea377df074435 > src/master/weights_handler.cpp c240fb2980a7e957136d11ddd3f43ee4761a07dc > src/slave/constants.hpp 6c381f06365b9deb84f43cdd101a2d2e5d826f57 > src/slave/container_loggers/lib_logrotate.hpp > d6e4f95e63825c01cb5fc05847ec249efc1348d2 > src/slave/container_loggers/lib_logrotate.cpp > 53698d339f0f4d2dc916b53239ca0c36bbebcd42 > src/slave/container_loggers/sandbox.hpp > e0aeb32a9ec83af049af8a10010b819c1d8b25d8 > src/slave/container_loggers/sandbox.cpp > cc263ebef7e0c3e778fabafa49faa6dd315adc45 > src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 > src/slave/containerizer/mesos/containerizer.hpp > c4fea8b56c39d5a363f6ea80bd109fd2d3db52d9 > src/slave/containerizer/mesos/containerizer.cpp > eac70d955e08142a2d054039d610a3d516b1b57e > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > c2fcc0b21c5b1e51cb38b61245d4bbd3856a9512 > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > df16b8fee6799a69c7d96f33a5049bd9787c48f5 > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > 270d2aa6e06f323bfb6eee3b703a24a600a55871 > src/slave/containerizer/mesos/isolators/linux/capabilities.hpp > c3afe2054bb206e9b2823c008435f78e70ce7d63 > src/slave/containerizer/mesos/isolators/linux/capabilities.cpp > 60d22aa877c1ab62a08222e5efe8800e337684da > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 7c35c3056326a8a135e4ad944ac741cda96cab99 > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp > f8d38c6f6694e9eb9dc3f4f600b6a1976dd9c66a > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.hpp > 7fad707a240234e35828917aea1bc79f42fe130e > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > 2ff8b0e76a11b6f6c98b839d3ac91a81e41285f5 > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp > ccd511ec14810dcc1020dec5e1641141f3a319b4 > src/slave/containerizer/mesos/launch.hpp > cfbf79029dd2d0b74b015e6e051bd2d429321825 > src/slave/containerizer/mesos/launch.cpp > 8a30ff8bd6f9263d68a4344b79f2374a2ae53c04 > src/slave/containerizer/mesos/linux_launcher.cpp > 0305d14c1f791c93edcd3b32786b483b15f40a2d > src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp > f5e90527e6ace45a7745ca1ba1a9eeef938d2a68 > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > 817e30c5d6d6a4b011193e3209301fc3cdf88b06 > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp > 395c36b0f6b8f8e037681ec5f2df99e83a7cf155 > src/slave/containerizer/mesos/provisioner/docker/paths.hpp > 232c027f8f96da0cb30b957bce4607d3695050d2 > src/slave/containerizer/mesos/provisioner/docker/paths.cpp > dea37566cbe0313f84f2bac27e29752a980b4394 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > b06ddff68a8d2df13abb838b03a8e73d4e273c31 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > e192f86a1848b373f3aa73d29688a96375cac313 > src/slave/flags.hpp ec619f84c7f3be81db8ce8536936bf7d4207efa2 > src/slave/flags.cpp 87d9e4632321134192bb0a67f1b91db7d89f539b > src/slave/http.cpp a32aca437cffd52bc2bcde859eedddca2038e3f1 > src/slave/main.cpp 219914d594ace009201d9caf8209ca3dd4eaa1a5 > src/slave/slave.hpp d8c5873bb7380b8449f8f344e85689519c467251 > src/slave/slave.cpp 6bd9b49c3bbdb973a0d03552ae8fe55b33371083 > src/tests/api_tests.cpp f0bafd1d5207a687ca0489b05ed1acdc2a6d875d > src/tests/authorization_tests.cpp 5d7e17b67821357b8cb538798acc883945c8f8fd > src/tests/container_logger_tests.cpp > 1bb94a8461e481983f25a44737e4011ed5fc4b1f > src/tests/containerizer.hpp 940c4146f4e854a6b1b9ccaba5687e76d5723cba > src/tests/containerizer.cpp 27c29b40f3241807fb22b27f0d9ca64b3e602a8f > src/tests/containerizer/cgroups_isolator_tests.cpp > b5797574ca2bfe3a005c80a3ba6bb6965c54cc95 > src/tests/containerizer/fs_tests.cpp > ccdd5967d01abfe4fa7746e3588ff93c6e0fe7e4 > src/tests/containerizer/linux_capabilities_isolator_tests.cpp > edb46659324c4c6345606cfa4c19f4fce05c59fe > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > f17ed4437a5e1366f85803ce7e29bee24162504c > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > c690b41f3852de035e5cc6378e7fc44d2c9a6fb9 > src/tests/containerizer/provisioner_appc_tests.cpp > a999fc7991da805dfbcdf5659fcfb762aee5b2b9 > src/tests/containerizer/provisioner_docker_tests.cpp > d8fb7abb55410cfd0835f59bfc0f35566aeeae37 > src/tests/containerizer/rootfs.hpp 6bc3835cbb62536ec933ef38c9e15138b8611e5f > src/tests/containerizer/volume_image_isolator_tests.cpp > f14a0bd1c44c069c2784638132a08072a2343309 > src/tests/default_executor_tests.cpp > 92e6b9f5fb80811c94632de3bb20c8e6d2e895ff > src/tests/environment.cpp 970136f98c601c4fbc71e8ffbf506bebe89c3658 > src/tests/executor_http_api_tests.cpp > a9f1a7b0498acd541c6f58ad1388da49c9951e22 > src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522 > src/tests/hierarchical_allocator_tests.cpp > 2e979d784b8e6cdacebac78a67498b5f4d023540 > src/tests/master_maintenance_tests.cpp > 6917272f2de7a09bf4de7e932994655f4e54d3da > src/tests/master_validation_tests.cpp > da43f990e3b8f61e27b22d551cd3e07638c7ff37 > src/tests/mesos.hpp 9309b5a985c0d7136a2ee5aa1598b4fee6194816 > src/tests/oversubscription_tests.cpp > b356fb62a4e068bc171a75a76001c6d0e76af92a > src/tests/persistent_volume_tests.cpp > 6289009fe9ed0a57ba5eff46dbbe0633a75d2616 > src/tests/resources_tests.cpp 6a12783c26f359dda835b4866b299a8fcfb3f972 > src/tests/scheduler_http_api_tests.cpp > 6390f2eb53d8bb97b98e64ec6e0f795abc3f3c7f > src/tests/slave_recovery_tests.cpp 703948f7a6861a4401ee45ce9cae2644106083f3 > src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc > src/tests/utils.cpp fc004a9c567898ffbc38a42cc2340dd57347a829 > src/v1/resources.cpp 46cc00f2f453f5eb4ddc4b0b9b89be2bd89f05d9 > src/webui/master/static/agent_executor.html > 95e921d1c3ca0f005e3eb3f79eb0d9a70a3b3f91 > src/webui/master/static/framework.html > 6297cf932838ed32c8def1022efda9ef5a053d37 > src/webui/master/static/home.html 07f862f69802bef8fda2d0a94e33c3b463ddcd4c > src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382 > src/webui/master/static/js/controllers.js > 3dead4f20e2dbeec8447e22ad287dd6ed2378345 > src/webui/master/static/js/jquery.pailer.js > 537fe002166167748a6357a50f4b7dd04b1f4257 > src/zookeeper/group.cpp 1df4b54883d451fe36f132af45f2f7c77f3f221b > support/mesos-gtest-runner.py 457211a7721a1595a8efaf51a10041da0494bdfe > support/mesos-style.py 3a5bec81950ccf8083cbd73577c49b2fb3b910f8 > support/windows-build.bat b3b6d0bbe877cf3794a5c616374ffce8c1b1552c > > Diff: https://reviews.apache.org/r/52600/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
