Review Request 69839: Fix scheduler library on multiple SUBSCRIBE requests per connection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69839/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-9210

Re: Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into smaller tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69721/#review212036 --- Ship it! Ship It! - Till Toenshoff On Jan. 14, 2019, 7:54

Re: Review Request 69720: Made `SSLTest` an unparameterized test suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69720/#review212037 --- Ship it! Ship It! - Till Toenshoff On Jan. 14, 2019, 7:54

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/ --- (Updated Jan. 10, 2019, 3:52 a.m.) Review request for mesos. Repository:

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/ --- (Updated Jan. 10, 2019, 2:32 a.m.) Review request for mesos. Repository:

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/ --- (Updated Jan. 9, 2019, 10:54 p.m.) Review request for mesos. Changes ---

Re: Review Request 69701: Improved debuggability of `verify-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69701/#review211778 --- Ship it! Ship It! - Till Toenshoff On Jan. 9, 2019, 3:46

Re: Review Request 69698: Added try/except for `shell()` calls in `verify-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69698/#review211777 --- Ship it! Ship It! - Till Toenshoff On Jan. 9, 2019, 9:35

Re: Review Request 69697: Reverted cleanup step of `verify-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69697/#review211776 --- Ship it! Ship It! - Till Toenshoff On Jan. 9, 2019, 9:30

Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/ --- Review request for mesos. Repository: mesos Description --- Dont review

Re: Review Request 69608: Fixed a typo in module manager log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69608/#review211497 --- Ship it! Ship It! - Till Toenshoff On Dec. 21, 2018, 2:03

Re: Review Request 69591: Fixed allocator benchmark names to ensure proper filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69591/#review211437 --- Ship it! Ship It! - Till Toenshoff On Dec. 19, 2018, 6:11

Re: Review Request 69590: Moves CNI root directory to a persistent location.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69590/#review211416 --- Thanks for this. Just some nitpicking below :)

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211397 --- Ship it! Ship It! - Till Toenshoff On Dec. 17, 2018, 3:55

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

> On Dec. 17, 2018, 12:52 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Lines 277 (patched) > > > > > > Python's way of `contains` for a dictionary is commonly something like > > this; > > > >

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211355 --- support/verify-reviews.py Lines 36 (patched)

Re: Review Request 69412: Fixed thread safety issue in jwt signature validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69412/#review210906 --- Fix it, then Ship it! The test itself appears a bit wonky and

Review Request 69444: Allowed for unbundled leveldb in CMake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69444/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Bugs: MESOS-9406

Re: Review Request 69442: Updated 'REPOSITORY_URL' in 'support/reviewboardrc' to use gitbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69442/#review210843 --- Ship it! Ship It! - Till Toenshoff On Nov. 24, 2018, 1:13

Re: Review Request 69441: Fixed sandbox creation chmod error handling in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69441/#review210842 --- Ship it! Ship It! - Till Toenshoff On Nov. 24, 2018, 5:22

Re: Review Request 67136: Added a function to get rlimits.

> On Nov. 24, 2018, 1:17 a.m., Till Toenshoff wrote: > > Thanks for adding this Benjamin - also thanks James for reviewing! Just realized that we should consider moving this into stout, no? - Till --- This is an automatically generated

Re: Review Request 67136: Added a function to get rlimits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/#review210838 --- Fix it, then Ship it! Thanks for adding this Benjamin - also

Review Request 69439: Added guards around convertStringToInt to prevent warning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69439/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 69438: Skipped an rlimit test if the environment is incompatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69438/#review210835 --- Ship it!

Re: Review Request 69311: Enabled parallel test runner to cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69311/#review210707 --- Ship it! Ship It! - Till Toenshoff On Nov. 14, 2018, 1:11

Re: Review Request 69312: Enabled parallel test runner to cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69312/#review210706 --- Ship it! Ship It! - Till Toenshoff On Nov. 11, 2018, 12:01

Re: Review Request 69313: Enabled parallel test runner to cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69313/#review210705 --- Ship it! - Till Toenshoff On Nov. 11, 2018, 12:01 a.m.,

Review Request 69405: Refactored createAuthorizationCallbacks into common/authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69405/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Greg Mann.

Re: Review Request 69384: Introduced common/authorization and refactored collectAuthorizations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69384/ --- (Updated Nov. 20, 2018, 2:26 a.m.) Review request for mesos, Alexander

Re: Review Request 69368: Added test reproducing crash on authorization failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69368/#review210649 --- src/tests/master_tests.cpp Line 10101 (original), 10101

Review Request 69386: Added test for ACCESS_MESOS_LOG authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69386/ --- Review request for mesos, Alexander Rukletsov and Alexander Rojas. Repository:

Review Request 69385: Refactored createSubject and authorizeLogAccess to common/authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69385/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin

Review Request 69384: Introduced common/authorization and refactored collectAuthorizations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69384/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin

Re: Review Request 69368: Added test reproducing crash on authorization failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69368/ --- (Updated Nov. 18, 2018, 10:48 p.m.) Review request for mesos, Alexander

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69369/ --- (Updated Nov. 18, 2018, 10:49 p.m.) Review request for mesos, Alexander

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69369/ --- (Updated Nov. 18, 2018, 1:25 a.m.) Review request for mesos, Alexander

Re: Review Request 69368: Added test reproducing crash on authorization failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69368/ --- (Updated Nov. 18, 2018, 1:23 a.m.) Review request for mesos, Alexander

Review Request 69369: Added collectAuthorizations helper to master.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69369/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin

Review Request 69368: Added test reproducing crash on authorization failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69368/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin

Re: Review Request 69324: Removed some unnecessary intermediate build variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69324/#review210505 --- Ship it! Ran it through our internal CI - all green :) - Till

Re: Review Request 69323: Removed separate automake variables for header sources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69323/#review210501 --- Ship it! Thanks a bunch for this James - makes rather common

Re: Review Request 69224: Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69224/#review210255 --- Ship it! Ship It! - Till Toenshoff On Nov. 1, 2018, 3:15

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

> On Oct. 24, 2018, 6:21 p.m., Joseph Wu wrote: > > We could probably do away with some of the double-negatives (i.e. `not > > UNBUNDLED` -> `BUNDLED`) in the new variable names and logic. That one I would prefer to change, if needed, within a new RR as I am strictly following the logic path

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

> On Oct. 24, 2018, 6:21 p.m., Joseph Wu wrote: > > 3rdparty/cmake/FindLIBARCHIVE.cmake > > Lines 21-24 (patched) > > > > > > Prefix this with: > > ``` > > # NOTE: If this fails, stderr is ignored, and the

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/ --- (Updated Oct. 30, 2018, 8:20 p.m.) Review request for mesos, Andrew

Review Request 69216: Added small style fix-ups for libevent unbundling on CMake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69216/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Repository: mesos

Re: Review Request 68812: Added example framework for inverse-offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68812/ --- (Updated Oct. 26, 2018, 5:20 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 68812: Added example framework for inverse-offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68812/ --- (Updated Oct. 26, 2018, 4:45 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 69160: Included corresponding header file first.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69160/#review210096 --- Ship it! Ship It! - Till Toenshoff On Oct. 25, 2018, 10:54

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 11:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

> On Oct. 24, 2018, 11:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review21 --- Fix it, then Ship it! src/tests/fetcher_tests.cpp Lines

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209956 --- 3rdparty/cmake/FindLIBARCHIVE.cmake Lines 19 (patched)

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209953 --- 3rdparty/CMakeLists.txt Line 998 (original), 998 (patched)

Review Request 69140: Allowed for unbundled libarchive on cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, James Peach,

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/ --- (Updated Oct. 22, 2018, 4:22 p.m.) Review request for mesos, Alexander

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x.

> On Oct. 22, 2018, 4:03 p.m., James Peach wrote: > > src/uri/fetchers/docker.cpp > > Lines 123 (patched) > > > > > > If curl is so old that it doesn't accept the `--http1.1` flags, then > > it's not going to use

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/ --- (Updated Oct. 22, 2018, 11:22 a.m.) Review request for mesos, Alexander

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209768 --- src/uri/fetchers/docker.cpp Lines 104 (patched)

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/ --- (Updated Oct. 18, 2018, 11:41 p.m.) Review request for mesos, Alexander

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/ --- (Updated Oct. 18, 2018, 11:03 p.m.) Review request for mesos, Alexander

Review Request 69075: Updated docker image fetcher to enforce HTTP1.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/ --- Review request for mesos, Alexander Rukletsov, Armand Grillet, Jie Yu, and

Re: Review Request 68992: Added 'received' timestamp into `process::Request`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68992/#review209605 --- Fix it, then Ship it!

Re: Review Request 68993: Introduced `logResponse` for http handlers.

> On Oct. 11, 2018, 3:11 p.m., Benno Evers wrote: > > src/common/http.cpp > > Lines 1200 (patched) > > > > > > Since the outputs of this log line are likely to be used for > > rudimentary analysis using shell

Re: Review Request 68993: Introduced `logResponse` for http handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68993/#review209609 --- Ship it! Modulo Benno's comment. src/common/http.hpp Lines

Re: Review Request 68994: Logged request processing time for some endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68994/#review209611 --- Ship it! Ship It! - Till Toenshoff On Oct. 11, 2018, 2:16

Re: Review Request 68994: Logged request processing time for some endpoints.

> On Oct. 12, 2018, 10:32 p.m., Benno Evers wrote: > > As we already discussed offline, it's a bit unfortunate to have some code > > duplication here and only have the statistics enabled for selected > > endpoints. (for those unaware, this is done in order to avoid spamming the > > logs with

Re: Review Request 68970: Fixed JSON object type error when using `support/apply-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68970/#review209406 --- Ship it! Ship It! - Till Toenshoff On Oct. 10, 2018, 5:21

Re: Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68951/#review209317 --- support/verify-reviews.py Line 97 (original), 97 (patched)

Re: Review Request 68939: Updated cpplint.py to be less verbose when there is no linting issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68939/#review209268 --- Ship it! Thanks a bunch Armand - huge improvement. I guess, at

Re: Review Request 68937: Removed output in mesos-style.py when linting goes well.

> On Oct. 5, 2018, 2:24 p.m., Till Toenshoff wrote: > > Thanks a bunch Armand. Can we please have the same for "apple-reviews.py"? Jeez - sorry for this confusion - here some more orderly feedback: Before applying your patch: ``` Checking 1 C++ file Done processing

Re: Review Request 68937: Removed output in mesos-style.py when linting goes well.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68937/#review209265 --- Ship it! Thanks a bunch Armand. Can we please have the same

Re: Review Request 68937: Removed output in mesos-style.py when linting goes well.

> On Oct. 5, 2018, 2:17 p.m., Till Toenshoff wrote: > > support/mesos-style.py > > Line 229 (original) > > > > > > Why is this not needed anymore? Ah, now understood -- sorry for the silly question. This "error" is

Re: Review Request 68937: Removed output in mesos-style.py when linting goes well.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68937/#review209263 --- support/mesos-style.py Line 229 (original)

Re: Review Request 68936: Fixed libevent dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68936/#review209254 --- Ship it! Ship It! - Till Toenshoff On Oct. 5, 2018, 9:10

Re: Review Request 68906: Fixed ssl build specific incompatiblity with libevent later than 2.1.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68906/ --- (Updated Oct. 3, 2018, 11:06 p.m.) Review request for mesos, Benjamin Mahler

Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68919/ --- Review request for mesos, Benjamin Bannier and James Peach. Repository: mesos

Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68916/ --- (Updated Oct. 3, 2018, 7:32 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68915: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68915/ --- (Updated Oct. 3, 2018, 7:32 p.m.) Review request for mesos, Benjamin Bannier

Review Request 68915: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68915/ --- Review request for mesos, Benjamin Bannier and James Peach. Repository: mesos

Review Request 68916: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68916/ --- Review request for mesos, Benjamin Bannier and James Peach. Repository: mesos

Review Request 68914: Updated libevent linkage to adhere to best practices.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68914/ --- Review request for mesos, Benjamin Bannier and James Peach. Bugs: MESOS-9222

Review Request 68913: Updated libevent linkage to adhere to best practices.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68913/ --- Review request for mesos, Benjamin Bannier and James Peach. Bugs: MESOS-9222

Re: Review Request 67748: Added monitoring paragraph to high-availability.md.

> On June 26, 2018, 9:12 p.m., Joerg Schad wrote: > > docs/high-availability.md > > Lines 58 (patched) > > > > > > Can we check what the exact defintion of this metric is? (connected to > > each other, connected to

Review Request 68906: Fixed ssl build specific incompatiblity with libevent later than 2.1.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68906/ --- Review request for mesos, Benjamin Mahler and James Peach. Bugs: MESOS-9265

Review Request 68905: Removed version check from libevent dependency tracking from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68905/ --- Review request for mesos, Benjamin Bannier and James Peach. Bugs: MESOS-9265

Review Request 68904: Removed version check from libevent dependency tracking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68904/ --- Review request for mesos, Benjamin Bannier and James Peach. Bugs: MESOS-9265

Review Request 68857: Fixed libevent M4 macro to be fully compatible with older autoconf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68857/ --- Review request for mesos, Benjamin Bannier, Benno Evers, and James Peach.

Review Request 68858: Fixed libevent M4 macro to be fully compatible with older autoconf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68858/ --- Review request for mesos, Benjamin Bannier, Benno Evers, and James Peach.

Re: Review Request 68856: Added missing python egg build extensions for libevent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/ --- (Updated Sept. 26, 2018, 10:19 p.m.) Review request for mesos, Benjamin

Re: Review Request 68856: Added missing python egg build extensions for libevent.

> On Sept. 26, 2018, 10:06 p.m., Benjamin Bannier wrote: > > src/python/native_common/ext_modules.py.in > > Lines 121-126 (patched) > > > > > > As discussed offline, I misunderstood part of the intention here. We >

Re: Review Request 68856: Added missing python egg build extensions for libevent.

> On Sept. 26, 2018, 9:48 p.m., Benjamin Bannier wrote: > > src/python/native_common/ext_modules.py.in > > Lines 121-126 (patched) > > > > > > This is inconsistent in checking whether files exist, and also > >

Review Request 68856: Added missing python egg build extensions for libevent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/ --- Review request for mesos, Benjamin Bannier, Benno Evers, and James Peach.

Re: Review Request 68816: Prevented leaking files in some stout tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68816/#review209026 --- Ship it! Ship It! - Till Toenshoff On Sept. 23, 2018, 7:32

Re: Review Request 68816: Prevented leaking files in some stout tests.

> On Sept. 26, 2018, 2:42 p.m., Till Toenshoff wrote: > > Ship It! Modulo CI issues. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68816/#review209026

Re: Review Request 68817: Prevented leaking files in some libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68817/#review209025 --- Ship it! Ship It! - Till Toenshoff On Sept. 23, 2018, 7:32

Re: Review Request 68819: Asserted element exists before accessing it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68819/#review209024 --- Ship it! Ship It! - Till Toenshoff On Sept. 23, 2018, 7:32

Re: Review Request 68641: Added version check and bundling of libevent within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68641/ --- (Updated Sept. 23, 2018, 8:44 p.m.) Review request for mesos, Benjamin

Review Request 68812: Added example framework for inverse-offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68812/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5827

Re: Review Request 68640: Added version check and bundling of libevent to autotools.

> On Sept. 21, 2018, 3:57 p.m., James Peach wrote: > > configure.ac > > Line 1491 (original), 1491 (patched) > > > > > > Minor nit, this could be: > > > > ``` > > test "x$without_bundled_libevent" =

<    1   2   3   >