Re: Review Request 34633: Added QoS Controller test.

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/ --- (Updated June 4, 2015, 10:42 a.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 34633: Added QoS Controller test.

2015-06-04 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/#review86679 --- src/tests/oversubscription_tests.cpp

Re: Review Request 34633: Added QoS Controller test.

2015-06-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/#review86508 --- Ship it! src/tests/oversubscription_tests.cpp

Re: Review Request 34633: Added QoS Controller test.

2015-06-03 Thread Vinod Kone
On May 29, 2015, 7:23 p.m., Vinod Kone wrote: src/tests/oversubscription_tests.cpp, line 117 https://reviews.apache.org/r/34633/diff/1/?file=970999#file970999line117 Why not implement the TODO? s/AWAIT_READY(received)/AWAIT_ASSERT_EQ(expected, received)/ ? Niklas

Re: Review Request 34633: Added QoS Controller test.

2015-06-02 Thread Niklas Nielsen
On May 29, 2015, 12:23 p.m., Vinod Kone wrote: src/tests/oversubscription_tests.cpp, line 117 https://reviews.apache.org/r/34633/diff/1/?file=970999#file970999line117 Why not implement the TODO? s/AWAIT_READY(received)/AWAIT_ASSERT_EQ(expected, received)/ ? We still

Re: Review Request 34633: Added QoS Controller test.

2015-06-02 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/ --- (Updated June 2, 2015, 9:29 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34633: Added QoS Controller test.

2015-05-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/#review85775 --- src/tests/oversubscription_tests.cpp