---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/#review88525
---
src/master/detector.cpp (line 447)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/#review88557
---
I will get the last things in before committing. Thanks folks
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/#review88359
---
Ship it!
This looks great Marco. Let's get this committed folks!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/
---
(Updated June 18, 2015, 2:46 p.m.)
Review request for mesos, Niklas Nielsen
On June 18, 2015, 11:09 a.m., Benjamin Hindman wrote:
src/master/detector.cpp, lines 468-469
https://reviews.apache.org/r/35571/diff/5/?file=986674#file986674line468
You should always know this is an error because you're in the 'else'
branch, so you can just do:
On June 18, 2015, 7:53 a.m., Benjamin Hindman wrote:
Still a Ship It, just a minor nit from the revision.
@BenH and @BenM; thanks for stepping in!
I can get this committed today.
- Niklas
---
This is an automatically generated
On June 17, 2015, 11:52 p.m., Niklas Nielsen wrote:
LGTM modulo wrapping at line 450-451.
Would love to see a test before we ship this.
@vinod - can you take a look at this too?
i'll take a look now.
- Vinod
---
This is an
On June 18, 2015, 1:08 a.m., Ben Mahler wrote:
src/master/detector.cpp, lines 444-447
https://reviews.apache.org/r/35571/diff/4/?file=986626#file986626line444
Our logging messages do not end with periods, please do a sweep :)
Ditto for aligning on the operator. To be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/#review88423
---
Thanks Marco, want to see this polished off properly before a ship
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/
---
(Updated June 17, 2015, 6:18 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/#review88266
---
Patch looks great!
Reviews applied: [35571]
All tests passed.
-
On June 17, 2015, 9:12 p.m., Niklas Nielsen wrote:
Looks great! I inlined a few suggestions below.
Will you be following up with a test?
I may need some help with how to unit test this - but the short answer is
**yes!** :)
(I wanted this out ASAP, to avoid wasting too much time if I'd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/#review88297
---
Adding a bit to Niq's review...
src/master/detector.cpp (lines
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/#review88307
---
LGTM modulo wrapping at line 450-451.
Would love to see a test
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/
---
(Updated June 17, 2015, 10:56 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/#review88276
---
Looks great! I inlined a few suggestions below.
Will you be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/#review88315
---
Saw that this got a LGTM, so wanted to help show Nik and Till the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/#review88328
---
Patch looks great!
Reviews applied: [35571]
All tests passed.
-
On June 18, 2015, 1:08 a.m., Ben Mahler wrote:
src/master/detector.cpp, lines 431-436
https://reviews.apache.org/r/35571/diff/4/?file=986626#file986626line431
As a follow up for later, is this case still needed?
not sure about this - would you like me to file a Jira or add a TODO?
19 matches
Mail list logo
