Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Sept. 16, 2015, 3:50 a.m.) Review request for mesos, Artem

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/#review99115 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (lines 223 - 225)

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 15, 2015, 11:12 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, lines 223-225 > > > > > > Just curious, why aren't you using the protobuf-2.5.0 tarball that's > > included in the

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Sept. 16, 2015, 2:55 a.m.) Review request for mesos, Artem

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Sept. 15, 2015, 6:42 p.m.) Review request for mesos, Artem

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 11, 2015, 10:41 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 192 > > > > > > Hmm, does protobuf build for you? This command should fail on VS2015 > > because stdex is

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 11, 2015, 10:41 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat, line 22 > > > > > > Rather than interpolating a `'#'` between the projects, can we pass in > > all the

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Sept. 15, 2015, 4:40 p.m.) Review request for mesos, Artem

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Sept. 15, 2015, 3:18 p.m.) Review request for mesos, Artem

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Sept. 15, 2015, 2:08 p.m.) Review request for mesos, Artem

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/#review98687 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 75)

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 77 > > > > > > So, why change the value to `TRUE` here? Is there some consequence of > > this, or is it just

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 8, 2015, 9:44 p.m., Joseph Wu wrote: > > Just a bit more cleanup, and I think this would be good to go. > > > > If possible, you should coordinate with Alex Clemmer to make sure this > > change doesn't conflict/break what he's working on > > (https://reviews.apache.org/r/37019/). >

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 8, 2015, 9:44 p.m., Joseph Wu wrote: > > Just a bit more cleanup, and I think this would be good to go. > > > > If possible, you should coordinate with Alex Clemmer to make sure this > > change doesn't conflict/break what he's working on > > (https://reviews.apache.org/r/37019/). >

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/#review98026 --- Ship it! Just a bit more cleanup, and I think this would be good

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Sept. 9, 2015, 2:38 a.m.) Review request for mesos, Artem

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 8, 2015, 9:44 p.m., Joseph Wu wrote: > > Just a bit more cleanup, and I think this would be good to go. > > > > If possible, you should coordinate with Alex Clemmer to make sure this > > change doesn't conflict/break what he's working on > > (https://reviews.apache.org/r/37019/).

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Sept. 5, 2015, noon) Review request for mesos, Artem Harutyunyan,

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Aug. 31, 2015, 6:46 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, lines 72-84 > > > > > > (This is just speculation, since I haven't tried this on a Windows > > box.) > > `TRUE`

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Sept. 5, 2015, 12:43 p.m.) Review request for mesos, Artem

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Aug. 31, 2015, 6:46 p.m., Joseph Wu wrote: > > For any future CMake reviews, could you also add Artem (hartem) and I > > (kaysoky) as reviewers? > > Thanks in advance :) Sure? thank you very much. - haosdent --- This is an

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/#review97108 --- For any future CMake reviews, could you also add Artem (hartem) and