Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-12-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/#review108483 --- Ship it! Ship It! - Michael Park On Nov. 30, 2015, 8:32 p.m.,

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/ --- (Updated Nov. 30, 2015, 8:32 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-13 Thread Greg Mann
> On Nov. 13, 2015, 9:59 p.m., Jie Yu wrote: > > include/mesos/authorizer/authorizer.proto, line 75 > > > > > > Can we call it ReserveResources to match other ACLs? (also, in case we > > have other things that we

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/ --- (Updated Nov. 13, 2015, 11:11 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/#review106509 --- Ship it! include/mesos/authorizer/authorizer.proto (line 73)

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/ --- (Updated Nov. 13, 2015, 4:34 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/ --- (Updated Nov. 9, 2015, 5:25 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/#review105596 --- Ship it! Ship It! - Guangya Liu On 十一月 6, 2015, 11:52 p.m.,

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-06 Thread Greg Mann
> On Nov. 6, 2015, 7:22 a.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 28 > > > > > > We have some discussions want to reduce the comments to 70 chars per > > line. > > Adam B wrote: >

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-06 Thread Adam B
> On Nov. 5, 2015, 11:22 p.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 28 > > > > > > We have some discussions want to reduce the comments to 70 chars per > > line. We actually

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-06 Thread Guangya Liu
> On 十一月 6, 2015, 7:22 a.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 28 > > > > > > We have some discussions want to reduce the comments to 70 chars per > > line. > > Adam B wrote: >

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-06 Thread Guangya Liu
> On 十一月 6, 2015, 7:22 a.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 28 > > > > > > We have some discussions want to reduce the comments to 70 chars per > > line. > > Adam B wrote: >

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-06 Thread Adam B
> On Nov. 5, 2015, 11:22 p.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 28 > > > > > > We have some discussions want to reduce the comments to 70 chars per > > line. > > Adam B wrote:

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-06 Thread Guangya Liu
> On 十一月 6, 2015, 7:22 a.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 28 > > > > > > We have some discussions want to reduce the comments to 70 chars per > > line. > > Adam B wrote: >

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-05 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/ --- (Updated Nov. 5, 2015, 9:50 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/#review105376 --- include/mesos/authorizer/authorizer.proto (line 28)