Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

> On Nov. 25, 2016, 3:09 p.m., haosdent huang wrote: > > src/tests/health_check_tests.cpp, line 842 > > > > > > Change here to make it consistent with > > > > ``` > > // This test creates a task whose

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review156925 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 25, 2016,

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review156922 --- src/tests/health_check_tests.cpp (line 842)

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/ --- (Updated Nov. 25, 2016, 3:08 p.m.) Review request for mesos, Alexander

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review156873 --- src/tests/health_check_tests.cpp (line 779)

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/ --- (Updated Nov. 24, 2016, 10:51 p.m.) Review request for mesos, Alexander

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

> On April 19, 2016, 2:35 p.m., Neil Conway wrote: > > This patch does not solve the flakiness for me: failed once after 2 > > iterations, then again after 77 iterations. Verbose test log here: > > https://gist.github.com/neilconway/e6134b4717ee022e7fc32a1f95619fa9 > > haosdent huang wrote: >

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review156871 --- Ship it! LGTM, modulo rebase.

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

> On May 13, 2016, 8:50 p.m., Benjamin Mahler wrote: > > This looks good but when you mentioned the consecutive failures in the > > description I was confused. The test should probably just say that we > > launch a task that toggles between healthy and unhealthy, and will never be > > killed

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/ --- (Updated May 17, 2016, 4:46 p.m.) Review request for mesos, Alexander

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

> On May 13, 2016, 8:50 p.m., Benjamin Mahler wrote: > > src/tests/health_check_tests.cpp, line 504 > > > > > > Why did this change? Yes, we need this so that we could check the stdout/stderr from console if it

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review133198 --- This looks good but when you mentioned the consecutive failures

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/ --- (Updated May 7, 2016, 8:59 a.m.) Review request for mesos, Alexander

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

> On April 19, 2016, 2:35 p.m., Neil Conway wrote: > > This patch does not solve the flakiness for me: failed once after 2 > > iterations, then again after 77 iterations. Verbose test log here: > > https://gist.github.com/neilconway/e6134b4717ee022e7fc32a1f95619fa9 > > haosdent huang wrote: >

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

> On April 19, 2016, 2:35 p.m., Neil Conway wrote: > > This patch does not solve the flakiness for me: failed once after 2 > > iterations, then again after 77 iterations. Verbose test log here: > > https://gist.github.com/neilconway/e6134b4717ee022e7fc32a1f95619fa9 Thank you very much for

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review129534 --- This patch does not solve the flakiness for me: failed once after

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review129272 --- Patch looks great! Reviews applied: [46307] Passed command:

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/ --- (Updated April 17, 2016, 5:15 p.m.) Review request for mesos, Alexander

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review129265 --- Bad patch! Reviews applied: [46307] Failed command:

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/ --- (Updated April 17, 2016, 3:11 p.m.) Review request for mesos, Ben Mahler, Neil

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/ --- (Updated April 17, 2016, 3:11 p.m.) Review request for mesos, Ben Mahler, Neil