Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review142975 --- Fix it, then Ship it!

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated July 19, 2016, 9:12 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated July 19, 2016, 6:30 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

> On 七月 15, 2016, 1:42 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 199 > > > > > > I recalled Gilbert asked why returning `Future` here but you dropped > > the

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review142431 --- src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

> On July 15, 2016, 6:42 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 199 > > > > > > I recalled Gilbert asked why returning `Future` here but you dropped > > the

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review142350 --- src/slave/containerizer/mesos/provisioner/appc/store.cpp (line

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated July 14, 2016, 5:28 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated July 13, 2016, 11:05 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review142137 --- Fix it, then Ship it!

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated July 13, 2016, 10:26 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review141297 --- src/slave/containerizer/mesos/provisioner/appc/store.cpp (line

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review141211 --- src/slave/containerizer/mesos/containerizer.cpp (line 306)

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated July 6, 2016, 6:32 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

> On 七月 1, 2016, 7:06 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, lines 212-213 > > > > > > 1) You should add a "'" to the end of the log message. > > 2) s/image/Appc

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review140123 --- src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated June 30, 2016, 6 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated June 30, 2016, 5:39 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated June 28, 2016, 10:53 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

> On June 28, 2016, 3:38 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, lines 334-335 > > > > > > Can we simplify the logic as: > > > > if (imageInfo.layers.size()

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review139806 --- include/mesos/appc/spec.proto

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

> On June 27, 2016, 6:14 p.m., Gilbert Song wrote: > > Srini, I guess you may want to add another patch before this one to > > implement the runtime isolator then plug it in using this patch. And you > > may need to rebase and figure out why your patches failed on review bot. > > Guangya Liu

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated June 28, 2016, 6:39 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

> On June 27, 2016, 11:14 a.m., Gilbert Song wrote: > > Srini, I guess you may want to add another patch before this one to > > implement the runtime isolator then plug it in using this patch. And you > > may need to rebase and figure out why your patches failed on review bot. > > Guangya Liu

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review139621 --- Srini, I guess you may want to add another patch before this one

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

> On 六月 26, 2016, 2:52 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, lines 211-212 > > > > > > VLOG(1) << "Failed to get manifest for image '" > > <<

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review139469 --- src/slave/containerizer/mesos/containerizer.cpp (lines 78 - 83)