Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 10:43 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 10:43 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 5:13 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 5:13 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 10:43 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 229 > > > > > > This is too many threads. An executor of a

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 186 > > > > > > s/isInterrupted/interrupted/... its a

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ImmutableSegment.java, > > line 88 > > > > > > Why we have a MemStoreSegmentsIterator and not

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 120 > > > > > > Has to be public? This method is used by

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 91 > > > > > > Does this need to be atomic reference or volatile

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionPipeline.java, > > line 93 > > > > > > Why not do this always? Why an option? This

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > Patch looks fine to me. What was the fix? A few comments in the below. How > > to test? Thanks Anastasia. The recent bug was in merging MSLABs. We didn't reference the open scan counters from the old MSLABs to the new merged MSLAB. No we

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 15, 2016, 3:18 a.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java, > > line 398 > > > > > > What is an initiateType? I like

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 5:13 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 5:13 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 10:43 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Oct. 16, 2016, 5:13 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 179 > > > > > > Able to get what u r trying to do here.

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51785/ --- (Updated Oct. 14, 2016, 7:19 a.m.) Review request for hbase. Changes ---

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 27, 2016, 10:03 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 238 > > > > > > Asked this already. In case of flattening,

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51785/ --- (Updated Sept. 28, 2016, 11:22 a.m.) Review request for hbase. Changes

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 28, 2016, 9:42 a.m., ramkrishna vasudevan wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ImmutableSegment.java, > > line 197 > > > > > > Previously flattening was using

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 27, 2016, 3:33 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentFactory.java, > > line 95 > > > > > > This is kind of merging all the segent's

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 27, 2016, 3:33 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 238 > > > > > > Asked this already. In case of flattening,

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 27, 2016, 10:03 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSegmentsIterator.java, > > line 36 > > > > > > The 2 impls of this have diff wrt

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 27, 2016, 10:03 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 238 > > > > > > Asked this already. In case of flattening,

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 27, 2016, 10:03 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 48 > > > > > > Why changed from 4 to 2? We have 4 refs no?

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 27, 2016, 10:03 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ImmutableSegment.java, > > line 211 > > > > > > Ok so here the succ boolean is true and so

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 27, 2016, 10:03 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ImmutableSegment.java, > > line 206 > > > > > > I can think of one issue here. Say we have

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 27, 2016, 10:03 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java, > > line 398 > > > > > > Seeing the tests using this method.. Why

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51785/ --- (Updated Sept. 26, 2016, 3:27 p.m.) Review request for hbase. Changes

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 25, 2016, 9:13 p.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionPipeline.java, > > line 93 > > > > > > The hyphen will look weird when the javadoc

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51785/ --- (Updated Sept. 22, 2016, 9:12 a.m.) Review request for hbase. Changes

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 19, 2016, 9:48 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactorIterator.java, > > line 70 > > > > > > useSQM case works with the state

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 19, 2016, 9:48 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentFactory.java, > > line 58 > > > > > > Any way one can mention to use Skip list based

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 19, 2016, 9:48 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 239 > > > > > > When policy is FLATTEN, it should just

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 19, 2016, 9:48 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentFactory.java, > > lines 95-98 > > > > > > Sorry what is this? Why? > > It tries to

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51785/ --- (Updated Sept. 18, 2016, 1:37 p.m.) Review request for hbase. Repository:

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 13, 2016, 6:58 a.m., ramkrishna vasudevan wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java, > > line 115 > > > > > > Because in merge you don't close the

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51785/#review149062 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51785/ --- (Updated Sept. 15, 2016, 12:03 p.m.) Review request for mesos. Repository: